From: "Andreas K. Huettel" <dilfridge@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Daniel Cordero <gentoo.catalyst@xxoo.ws>
Subject: Re: [gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments
Date: Sat, 23 Apr 2022 12:59:59 +0200 [thread overview]
Message-ID: <2208736.iZASKD2KPV@pinacolada> (raw)
In-Reply-To: <20220419174015.3958836-1-gentoo.catalyst@xxoo.ws>
Huh... fine of course and sorry about that.
Strange that it worked though...
Am Dienstag, 19. April 2022, 19:40:15 CEST schrieb Daniel Cordero:
> From: Daniel Cordero <catalyst@0xdc.io>
>
> When enclosed in quotes and expanded with "${variable[@]}", the word is expanded
> to be a single argument, rather than two separate arguments.
>
> i.e. argv[2] = "-iso-level 3"
> instead of
> argv[2] = "-iso-level"
> argv[3] = "3"
>
> This lead to the failure:
> xorriso : FAILURE : -as mkisofs: Unrecognized option '-iso-level 3'
> xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
> grub-mkrescue: error: `xorriso` invocation failed
>
> This patch fixes commit 0b56dbe4d36c88b0b051d24451e15cd6b64c819d.
> ---
> targets/support/create-iso.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
> index 45ef1696..9991b930 100755
> --- a/targets/support/create-iso.sh
> +++ b/targets/support/create-iso.sh
> @@ -194,7 +194,7 @@ case ${clst_hostarch} in
> amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
> isoroot_checksum
>
> - extra_opts=("-joliet" "-iso-level 3")
> + extra_opts=("-joliet" "-iso-level" "3")
> case ${clst_hostarch} in
> sparc*) extra_opts+=("--sparc-boot") ;;
> esac
>
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
prev parent reply other threads:[~2022-04-23 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 17:40 [gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments Daniel Cordero
2022-04-20 23:25 ` Matt Turner
2022-04-23 10:59 ` Andreas K. Huettel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2208736.iZASKD2KPV@pinacolada \
--to=dilfridge@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
--cc=gentoo.catalyst@xxoo.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox