From: Daniel Cordero <gentoo.catalyst@0xdc.io>
To: gentoo-catalyst@lists.gentoo.org
Subject: [gentoo-catalyst] [PATCH 2/4] stage4/groups: don't run split on a list
Date: Thu, 21 Apr 2022 07:08:24 +0000 [thread overview]
Message-ID: <20220421070826.92638-2-gentoo.catalyst@0xdc.io> (raw)
In-Reply-To: <20220421070826.92638-1-gentoo.catalyst@0xdc.io>
"groups" has been normalised into a list and does not have a split()
method.
This fixes an issue introduced in commit 5be6069bcbd5a7fa3f114f28366597bc5ddbb891.
---
catalyst/base/stagebase.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
index 1d71c59d..7e6b9e32 100644
--- a/catalyst/base/stagebase.py
+++ b/catalyst/base/stagebase.py
@@ -931,7 +931,7 @@ class StageBase(TargetBase, ClearBase, GenBase):
env=self.env)
def groups(self):
- for x in self.settings["groups"].split():
+ for x in self.settings["groups"]:
log.notice("Creating group: '%s'", x)
cmd(["groupadd", "-R", self.settings['chroot_path'], x], env=self.env)
--
2.35.1
next prev parent reply other threads:[~2022-04-21 7:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 23:37 [gentoo-catalyst] [PATCH 1/3] catalyst: support 3 new options Matt Turner
2022-03-27 23:37 ` [gentoo-catalyst] [PATCH 2/3] catalyst: add new options to stage4 step list Matt Turner
2022-03-27 23:37 ` [gentoo-catalyst] [PATCH 3/3] example: document new options Matt Turner
2022-04-19 14:17 ` [gentoo-catalyst] [PATCH 1/3] catalyst: support 3 " Daniel Cordero
2022-04-20 23:25 ` Matt Turner
2022-04-19 15:23 ` Daniel Cordero
2022-04-20 23:26 ` Matt Turner
2022-04-21 7:08 ` [gentoo-catalyst] [PATCH 1/4] stage4: fix handling of groups, users and keys Daniel Cordero
2022-04-21 7:08 ` Daniel Cordero [this message]
2022-04-21 7:08 ` [gentoo-catalyst] [PATCH 3/4] stage4/users: don't split a single entry Daniel Cordero
2022-04-21 7:08 ` [gentoo-catalyst] [PATCH 4/4] stage4/groups: improve log message Daniel Cordero
2022-04-21 21:01 ` Daniel Cordero
2022-05-09 11:20 ` [gentoo-catalyst] [PATCH v2 4/4] stage4/users: " Daniel Cordero
2022-05-09 17:06 ` [gentoo-catalyst] [PATCH 1/4] stage4: fix handling of groups, users and keys Matt Turner
2022-05-12 10:09 ` Daniel Cordero
2022-05-13 17:45 ` Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421070826.92638-2-gentoo.catalyst@0xdc.io \
--to=gentoo.catalyst@0xdc.io \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox