public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Daniel Cordero <gentoo.catalyst@xxoo.ws>
To: gentoo-catalyst@lists.gentoo.org
Subject: [gentoo-catalyst] [PATCH 2/2] Add shdir to valid config values
Date: Fri, 29 May 2020 10:05:52 +0000	[thread overview]
Message-ID: <20200529100551.916987-2-gentoo.catalyst@xxoo.ws> (raw)
In-Reply-To: <20200529100551.916987-1-gentoo.catalyst@xxoo.ws>

From: Daniel Cordero <catalyst@0xdc.io>

The catalyst.git script specified this configuration option, which would
not pass validation because shdir was not in the list of
valid_config_file_values.

Add shdir to the list of allowed valid_config_file_values.

Remove shdir from the catalyst.git script anyway, as it would match the default.

Fixes: 8443f89f3c5df (catalyst: Verify config options against valid_config_file_values)

  NOTICE  : Loading configuration file: /tmp/catalyst.conf.tyxsgh1l
  CRITICAL: Unknown option 'shdir' in config file /tmp/catalyst.conf.tyxsgh1l
---
 bin/catalyst.git     | 1 -
 catalyst/defaults.py | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/catalyst.git b/bin/catalyst.git
index 071bf58b..29b72c30 100755
--- a/bin/catalyst.git
+++ b/bin/catalyst.git
@@ -28,7 +28,6 @@ def main(argv):
 		# Set up a config file with paths to the local tree.
 		conf.write(
 			('sharedir="%(source_root)s"\n'
-			 'shdir="%(source_root)s/targets"\n'
 			 'envscript="%(source_root)s/etc/catalystrc"\n'
 			 % {'source_root': source_root}).encode('utf8')
 		)
diff --git a/catalyst/defaults.py b/catalyst/defaults.py
index 14f671fe..b5026e95 100644
--- a/catalyst/defaults.py
+++ b/catalyst/defaults.py
@@ -18,6 +18,7 @@ valid_config_file_values = frozenset([
     "repo_name",
     "repos",
     "sharedir",
+    "shdir",
     "storedir",
     "target_distdir",
     "target_pkgdir",
-- 
2.26.2



      reply	other threads:[~2020-05-29 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29 10:05 [gentoo-catalyst] [PATCH 1/2] catalyst.git: Quote toml paths in custom catalyst.conf Daniel Cordero
2020-05-29 10:05 ` Daniel Cordero [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529100551.916987-2-gentoo.catalyst@xxoo.ws \
    --to=gentoo.catalyst@xxoo.ws \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox