Re: [gentoo-catalyst] [PATCH 3/3] catalyst: Mount squashfs with -o ro

[Brian Dolbec <dolsen@gentoo.org>]

On Thu, 14 May 2020 23:37:30 -0700
Matt Turner <mattst88@gentoo.org> wrote:

> Even though squashfs is not writeable, it must be mounted with -o ro
> in order to be mounted multiple times. This allows, for example, the
> same snapshot to be mounted simultaneously in multiple catalyst
> chroots.
> 
> Signed-off-by: Matt Turner <mattst88@gentoo.org>
> ---
>  catalyst/base/stagebase.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
> index 55d1032d..651bf4e4 100644
> --- a/catalyst/base/stagebase.py
> +++ b/catalyst/base/stagebase.py
> @@ -868,7 +868,9 @@ class StageBase(TargetBase, ClearBase, GenBase):
>                  mount += ['-t', 'tmpfs', '-o', 'noexec,nosuid,nodev']
>              else:
>                  source_path = Path(self.mount[x]['source'])
> -                if source_path.suffix != '.sqfs':
> +                if source_path.suffix == '.sqfs':
> +                    mount += ['-o', 'ro']
> +                else:
>                      mount.append('--bind')
>  
>                      # We may need to create the source of the bind
> mount. E.g., in the

Yes to patch #2 and #3

Please make a header email for multiple commits series, Is easier to
approve all with one email ;)

I don't know why but I'm getting yours out of numerical order in
claws-mail...