From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 3/3] catalyst: Mount squashfs with -o ro
Date: Fri, 15 May 2020 18:48:28 -0700 [thread overview]
Message-ID: <20200515184828.674e5508@storm> (raw)
In-Reply-To: <20200515063730.2582596-3-mattst88@gentoo.org>
On Thu, 14 May 2020 23:37:30 -0700
Matt Turner <mattst88@gentoo.org> wrote:
> Even though squashfs is not writeable, it must be mounted with -o ro
> in order to be mounted multiple times. This allows, for example, the
> same snapshot to be mounted simultaneously in multiple catalyst
> chroots.
>
> Signed-off-by: Matt Turner <mattst88@gentoo.org>
> ---
> catalyst/base/stagebase.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
> index 55d1032d..651bf4e4 100644
> --- a/catalyst/base/stagebase.py
> +++ b/catalyst/base/stagebase.py
> @@ -868,7 +868,9 @@ class StageBase(TargetBase, ClearBase, GenBase):
> mount += ['-t', 'tmpfs', '-o', 'noexec,nosuid,nodev']
> else:
> source_path = Path(self.mount[x]['source'])
> - if source_path.suffix != '.sqfs':
> + if source_path.suffix == '.sqfs':
> + mount += ['-o', 'ro']
> + else:
> mount.append('--bind')
>
> # We may need to create the source of the bind
> mount. E.g., in the
Yes to patch #2 and #3
Please make a header email for multiple commits series, Is easier to
approve all with one email ;)
I don't know why but I'm getting yours out of numerical order in
claws-mail...
next prev parent reply other threads:[~2020-05-16 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 6:37 [gentoo-catalyst] [PATCH 1/3] catalyst: Rename shmfs -> shm Matt Turner
2020-05-15 6:37 ` [gentoo-catalyst] [PATCH 2/3] catalyst: Factor out mount/source/target in bind() Matt Turner
2020-05-15 6:37 ` [gentoo-catalyst] [PATCH 3/3] catalyst: Mount squashfs with -o ro Matt Turner
2020-05-16 1:48 ` Brian Dolbec [this message]
2020-05-16 1:45 ` [gentoo-catalyst] [PATCH 1/3] catalyst: Rename shmfs -> shm Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515184828.674e5508@storm \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox