public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 1/3] catalyst: Rename shmfs -> shm
Date: Fri, 15 May 2020 18:45:44 -0700	[thread overview]
Message-ID: <20200515184544.38cde09b@storm> (raw)
In-Reply-To: <20200515063730.2582596-1-mattst88@gentoo.org>

On Thu, 14 May 2020 23:37:28 -0700
Matt Turner <mattst88@gentoo.org> wrote:

> This will allow us to factor out the ['source', 'target'] from each
> case.
> 
> Signed-off-by: Matt Turner <mattst88@gentoo.org>
> ---
>  catalyst/base/stagebase.py | 4 ++--
>  catalyst/defaults.py       | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
> index 68945da8..52f9cd5b 100644
> --- a/catalyst/base/stagebase.py
> +++ b/catalyst/base/stagebase.py
> @@ -864,9 +864,9 @@ class StageBase(TargetBase, ClearBase, GenBase):
>                          target]
>              elif source == 'tmpfs':
>                  _cmd = ['mount', '-t', 'tmpfs', source, target]
> -            elif source == 'shmfs':
> +            elif source == 'shm':
>                  _cmd = ['mount', '-t', 'tmpfs', '-o',
> 'noexec,nosuid,nodev',
> -                        'shm', target]
> +                        source, target]
>              else:
>                  _cmd = ['mount', source, target]
>  
> diff --git a/catalyst/defaults.py b/catalyst/defaults.py
> index 9d5771d5..404f4892 100644
> --- a/catalyst/defaults.py
> +++ b/catalyst/defaults.py
> @@ -99,7 +99,7 @@ MOUNT_DEFAULTS = OrderedDict([
>      }),
>      ('shm', {
>          'enable': True,
> -        'source': 'shmfs',
> +        'source': 'shm',
>          'target': '/dev/shm',
>      }),
>      ('run', {

Looks fine


      parent reply	other threads:[~2020-05-16  1:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15  6:37 [gentoo-catalyst] [PATCH 1/3] catalyst: Rename shmfs -> shm Matt Turner
2020-05-15  6:37 ` [gentoo-catalyst] [PATCH 2/3] catalyst: Factor out mount/source/target in bind() Matt Turner
2020-05-15  6:37 ` [gentoo-catalyst] [PATCH 3/3] catalyst: Mount squashfs with -o ro Matt Turner
2020-05-16  1:48   ` Brian Dolbec
2020-05-16  1:45 ` Brian Dolbec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515184544.38cde09b@storm \
    --to=dolsen@gentoo.org \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox