From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 3/8] targets: Inline filesystem-functions.sh
Date: Sat, 2 May 2020 17:25:11 -0700 [thread overview]
Message-ID: <20200502172511.73e45afb@storm> (raw)
In-Reply-To: <CAEdQ38EHR5rJFgnBoTQeyKwh0bKfz0RTpQd1fjnv+yT74Cghmw@mail.gmail.com>
On Sat, 2 May 2020 16:18:43 -0700
Matt Turner <mattst88@gentoo.org> wrote:
> On Sat, May 2, 2020 at 4:03 PM Brian Dolbec <dolsen@gentoo.org> wrote:
> >
> > On Fri, 1 May 2020 18:40:31 -0700
> > Matt Turner <mattst88@gentoo.org> wrote:
> >
> > > Signed-off-by: Matt Turner <mattst88@gentoo.org>
> > > ---
> >
> > Again, no reasoning
>
> Sorry. I think it's pretty apparent.
>
> Simple functions that are called only from a single place and exist in
> a different file should just be inlined.
>
> Should I just add that to the commit message?
>
No, like I commented in patch #6, list what was inlined. Was a poor
choice of words on my part.
The way your commit message are, you have to have the commits open in
gitg or gitweb log view, or git log yyyyyyyyy to see the changes to
know what was changed, or why.
It is about readability.
eg:
# git log
...
commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy
Author: Matt Turner <mattst88@gentoo.org>
Date: Tue Apr 22 17:57:34 2020 -0700
targets: Inline functions with one caller
commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Author: Matt Turner <mattst88@gentoo.org>
Date: Tue Apr 21 17:57:34 2020 -0700
targets: Inline filesystem-functions.sh
commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww
Author: Matt Turner <mattst88@gentoo.org>
Date: Tue Apr 21 17:57:34 2020 -0700
targets: Drop most fstypes
==================================================================
Better is
==================================================================
commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy
Author: Matt Turner <mattst88@gentoo.org>
Date: Tue Apr 22 17:57:34 2020 -0700
targets: Inline functions with one caller
check_bootargs, check_filesystem_type were only
used in bootloader_setup.sh
commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Author: Matt Turner <mattst88@gentoo.org>
Date: Tue Apr 21 17:57:34 2020 -0700
targets: Inline filesystem-functions.sh
create_squashfs, create_jffs2 were only used in
target_image_setup.sh
commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww
Author: Matt Turner <mattst88@gentoo.org>
Date: Tue Apr 21 17:57:34 2020 -0700
targets: Drop most fstypes
drop ziofs, normal, noloop filesystem types
They are old/obsolete/ no longer relavent...
next prev parent reply other threads:[~2020-05-03 0:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 1:40 [gentoo-catalyst] [PATCH 1/8] targets: Use gensquashfs instead of mksquashfs Matt Turner
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 2/8] targets: Drop most fstypes Matt Turner
2020-05-02 23:00 ` Brian Dolbec
2020-05-02 23:17 ` Matt Turner
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 3/8] targets: Inline filesystem-functions.sh Matt Turner
2020-05-02 23:03 ` Brian Dolbec
2020-05-02 23:18 ` Matt Turner
2020-05-03 0:25 ` Brian Dolbec [this message]
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 4/8] targets: Remove unused source filesystem-functions.sh Matt Turner
2020-05-02 23:06 ` Brian Dolbec
2020-05-02 23:20 ` Matt Turner
2020-05-02 23:51 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 5/8] targets: Remove run_crossdev() function Matt Turner
2020-05-02 23:06 ` Brian Dolbec
2020-05-02 23:22 ` Matt Turner
2020-05-02 23:45 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 6/8] targets: Inline functions with one caller Matt Turner
2020-05-02 23:12 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 7/8] targets: Remove unused extract_kernel() Matt Turner
2020-05-02 23:15 ` Brian Dolbec
2020-05-02 1:40 ` [gentoo-catalyst] [PATCH 8/8] catalyst: Replace target_portdir with repo_basedir+repo_name Matt Turner
2020-05-02 23:28 ` Brian Dolbec
2020-05-02 22:56 ` [gentoo-catalyst] [PATCH 1/8] targets: Use gensquashfs instead of mksquashfs Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200502172511.73e45afb@storm \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox