From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 815A4138350 for ; Wed, 8 Apr 2020 02:11:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B8386E094B; Wed, 8 Apr 2020 02:10:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 95C98E094B for ; Wed, 8 Apr 2020 02:10:59 +0000 (UTC) Received: from professor-x (d108-172-193-125.bchsia.telus.net [108.172.193.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 39E9E34F0AB for ; Wed, 8 Apr 2020 02:10:58 +0000 (UTC) Date: Tue, 7 Apr 2020 19:10:44 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 1/2] targets: Set LANG=C.UTF8 Message-ID: <20200407191044.18551b69@professor-x> In-Reply-To: References: <20200330032644.3086274-1-mattst88@gentoo.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: f22ff3b9-106d-4ce6-9315-aa5e1cef08be X-Archives-Hash: 0830a9302df0dad43f6c9b3c3e2431c5 On Tue, 7 Apr 2020 17:25:44 -0700 Matt Turner wrote: > On Tue, Apr 7, 2020 at 2:26 PM Alec Warner wrote: > > On Sun, Mar 29, 2020 at 8:26 PM Matt Turner > > wrote: > >> > >> Stable glibc now always provides a UTF-8 capable locale, which many > >> packages require. Set this as the default LANG. > >> > >> Running locale-gen in stage1 should also solve bug #536938. > >> > >> Bug: https://bugs.gentoo.org/536938 > >> Bug: https://bugs.gentoo.org/710762 > >> Bug: https://bugs.gentoo.org/714906 > >> Signed-off-by: Matt Turner > >> --- > >> targets/stage1/chroot.sh | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/targets/stage1/chroot.sh b/targets/stage1/chroot.sh > >> index 0caf49ee..88a36481 100755 > >> --- a/targets/stage1/chroot.sh > >> +++ b/targets/stage1/chroot.sh > >> @@ -57,6 +57,11 @@ make_destpath /tmp/stage1root > >> run_merge "--oneshot --nodeps sys-apps/baselayout" > >> ${clst_sed} -i "/USE=\"${USE} -build\"/d" ${clst_make_conf} > >> > >> +for etc in /etc /tmp/stage1root/etc; do > >> + echo "LANG=C.UTF8" > ${etc}/env.d/02locale > >> +done > >> +update_env_settings > >> + > > > > > > if /tmp/stage1root is "${clst_root_path}" I think it might behoove > > you to use it here rather than hard coding it. Same as below. > > Thank you. Fixed and pushed (since I realized that USE=compile-locales > is actually already unmasked on the latest stable glibc). > Thanks Matt And yes, after all the work it took to fix the hard coded paths throughout the code... If need be add another variable to the defaults so that it is all in one place where it is easier to change or override as the need may arise.