From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 1/7] Move the signal handler into the StageBase class so it can handle unbind() cleanup
Date: Sat, 11 Mar 2017 16:31:34 -0500 [thread overview]
Message-ID: <20170311213134.GD31094@vapier> (raw)
In-Reply-To: <20170310112247.1c8fff5d.dolsen@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
On 10 Mar 2017 11:22, Brian Dolbec wrote:
> Subject: [PATCH 1/7] Move the signal handler into the StageBase class so it
> can handle unbind() cleanup
>
> Not quite complete, still errors on some unmounting
i don't think moving signal handling into a random module makes sense.
the main loop should be responsible for this business. i.e. where the
code is now (or in catalyst._main).
if the only thing you want to handle is clean up of mounts, then we
should be looking at mount namespaces instead. unlike other namespaces,
support for mount namespaces has been around forever and can't be turned
off in the kernel.
the releng repo deals with this by running everything through unshare.
snakeoil already includes namespace support. i'll send a patch.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-11 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 19:22 [gentoo-catalyst] [PATCH 0/7] Latest pending branch fixes Brian Dolbec
2017-03-10 19:22 ` [gentoo-catalyst] [PATCH 1/7] Move the signal handler into the StageBase class so it can handle unbind() cleanup Brian Dolbec
2017-03-11 21:31 ` Mike Frysinger [this message]
2017-03-10 19:23 ` [gentoo-catalyst] [PATCH 6/7] defaults.py: Update all repository, DISTDIR, PKGDIR settings to new /var paths Brian Dolbec
2017-03-10 19:51 ` Zac Medico
2017-03-10 20:36 ` Brian Dolbec
2017-03-10 21:02 ` Brian Dolbec
2017-03-20 9:02 ` Mike Frysinger
2017-03-20 9:21 ` Brian Dolbec
2017-03-20 9:32 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170311213134.GD31094@vapier \
--to=vapier@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox