From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 92E331388C1 for ; Tue, 5 Jan 2016 23:30:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 00EEFE0884; Tue, 5 Jan 2016 23:30:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8031CE0884 for ; Tue, 5 Jan 2016 23:30:48 +0000 (UTC) Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 3B1ED3409B9; Tue, 5 Jan 2016 23:30:47 +0000 (UTC) Date: Tue, 5 Jan 2016 18:30:47 -0500 From: Mike Frysinger To: gentoo-catalyst@lists.gentoo.org Cc: kevin.zhaoshuai@gmail.com Subject: Re: [gentoo-catalyst][PATCH v1 2/3] Modify the create iso parameter of ppc64le and power8 Message-ID: <20160105233047.GP25548@vapier.lan> Mail-Followup-To: gentoo-catalyst@lists.gentoo.org, kevin.zhaoshuai@gmail.com References: <1450284052-13005-1-git-send-email-kevin.zhaoshuai@gmail.com> <1450284067-13049-1-git-send-email-kevin.zhaoshuai@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dT+85zccSFkyJC53" Content-Disposition: inline In-Reply-To: <1450284067-13049-1-git-send-email-kevin.zhaoshuai@gmail.com> X-Archives-Salt: a8c53419-b637-423a-9196-3ee2ae9014fb X-Archives-Hash: 0b6c4f086b840c327eec99a3ba0c62ae --dT+85zccSFkyJC53 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 16 Dec 2015 11:41, Kevin Zhao wrote: > - run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/ > + if [ "${clst_subarch}" == "ppc64le" ]||[ "${clst_subarch}" == "power8" ] please put spaces around the || operator, and use = instead of == isn't this power8 specific ? so do you really need to look at ppc64le ? > + then > + run_mkisofs -v -r -T -U -l -cache-inodes -chrp-boot -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}" > + else > + run_mkisofs -r -U -chrp-boot -netatalk -hfs -probe -map "${clst_target_path}"/boot/map.hfs -part -no-desktop -hfs-volid "${clst_iso_volume_id}" -hfs-bless "${clst_target_path}"/boot -hide-hfs "zisofs" -hide-hfs "stages" -hide-hfs "distfiles" -hide-hfs "snapshots" -J ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}"/ > + fi i know the existing code is ugly, but please fix that here. rather than duplicate the huge command line, factor out the common bits. something like: flags=( -r -U ) if [ "${clst_subarch}" = "power8" ] then flags+=( -v -T -l -cache-inodes -chrp-boot ) else flags+=( ... ) fi run_mkisofs "${flags[@]}" \ -J ${mkisofs_zisofs_opts} -V "${clst_iso_volume_id}" -o "${1}" "${clst_target_path}" also, it seems like some of the flags you dropped for power8 should stay there. -mike --dT+85zccSFkyJC53 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWjFImAAoJEEFjO5/oN/WBsUwQAJSxH7OhT7PT+u7HBOItEucR 0i8wBUO2/Rip6qSbYfKNHjm7AEfkP7YAcYa+UXguFZdUCVgAQV3devX5eh1mO/cz jv+wKR41Thrte+Zrs+BbVxw7UkohyhkmpdOpUdrKgRmjTh0gtSvVTp566PNm62f2 FTCYkRt0UiUKgDTOHMW+HQlrb+RY/L2Tmb560WzD6dj2eSN2euinhTeZ0wajG864 ax0E1AWmG1AoCScE8iWiIVbuq9vdGqSNVWvg0mMNK0tCdAup0iBPB+5giWJMu9iU /jFNu54pbpwcUS86fQax0yyeAUQo1p6/HNogdEmuwHAtTjxWRJIq5XhneD+An4lG tQMnanHDXm4d3+si5febEwiXdM248r+8ZkmLEIy8/hvbCNMntszh/0XLTLDhfKah qVGZthYs/Tw1ibDl9aWt6PKmSZxOhx2YasRJzt2rPajoNLtcjwR6J75ONUqQ0GKE QXyLB7Dr/NRG/dOPZXXFvh2VFZYusUd9m/gixEUqRJHhh/ctp85IDpEUi5nShtJI 4LXK4ox+yY9L5CqhWDFitNiRMAPFqcQIFYIEqJ/d4XpdRPz9vvNeq2ly2bF7acYj Tk5iJOXtc1idjVNbesjsLHMVVxtuXL87nEqtFEEZ/5vP0pSr5dl3TGGjmYiTicnU t37Pa43H+wjXcJOmff3k =w7vK -----END PGP SIGNATURE----- --dT+85zccSFkyJC53--