From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id AD50913838B for ; Tue, 9 Sep 2014 18:38:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BF466E07F7; Tue, 9 Sep 2014 18:38:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6AE46E07F7 for ; Tue, 9 Sep 2014 18:38:51 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 5F1BA3400A4 for ; Tue, 9 Sep 2014 18:38:50 +0000 (UTC) Date: Tue, 9 Sep 2014 11:38:44 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH v2] stage1-controller.sh: Remove some old poor cleaning code Message-ID: <20140909113844.6220aee6.dolsen@gentoo.org> In-Reply-To: <1409634345-5378-1-git-send-email-dolsen@gentoo.org> References: <1409625101-27112-4-git-send-email-dolsen@gentoo.org> <1409634345-5378-1-git-send-email-dolsen@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 5a7907a1-f7eb-4204-b38c-61caccfe9784 X-Archives-Hash: 80edc9aa57cfdd583505369bb8cd8e75 On Mon, 1 Sep 2014 22:05:45 -0700 Brian Dolbec wrote: > This code had portage bin path hard coded. That path needed to be > changed for a new portage ebuild and install system. > After testing the origianl code and comparing it with some updated > code supplied by Douglas Freed. It turned out both code chunks > resulted in nothing being cleaned. > > Tested and confirmed by zero_chaos. I have gone over things more and tested the new find command. It does work on my host system. However, the question remains... DOES this particular cleaning operation NEED to be performed? With current the tree snapshot for my testing 20140829. It does not find anything to clean. BUT, will that remain the same in the future as pkgs are bumped? For safety, I'd be inclined to keep the find command (v1 of the patch) and clean any it does find just in case. -- Brian Dolbec