From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 059A813877A for ; Tue, 2 Sep 2014 05:28:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9A0C2E0C6D; Tue, 2 Sep 2014 05:28:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3C67AE0C6D for ; Tue, 2 Sep 2014 05:28:04 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id EC35833F7D6 for ; Tue, 2 Sep 2014 05:28:02 +0000 (UTC) Date: Mon, 1 Sep 2014 22:26:40 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 7/7] Fix a relative path bug Message-ID: <20140901222640.78f9d3a9.dolsen@gentoo.org> In-Reply-To: <20140902050634.GI8263@odin.tremily.us> References: <1409625101-27112-1-git-send-email-dolsen@gentoo.org> <1409625101-27112-8-git-send-email-dolsen@gentoo.org> <20140902050634.GI8263@odin.tremily.us> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/fr_SSL0oWsg_Me7e9ZGdF0H"; protocol="application/pgp-signature" X-Archives-Salt: 8bc76396-db5b-4d9d-b212-226b46dbce6d X-Archives-Hash: 4d86fc68657ae2eb1ada9fdc781b70c7 --Sig_/fr_SSL0oWsg_Me7e9ZGdF0H Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 1 Sep 2014 22:06:34 -0700 "W. Trevor King" wrote: > On Mon, Sep 01, 2014 at 07:31:41PM -0700, Brian Dolbec wrote: > > Conflicts: > > targets/support/functions.sh >=20 > Presumably these are conflicts from rebasing from 3.0. I don't think > we care about those, so I'd remove this note from the commit message. >=20 > What are the symptoms of the bug this fixes? How do I trigger it in > Catalysts without this patch? >=20 > Cheers, > Trevor >=20 Yeah, sorry, I was leaving those in place while fixing rebase errors... it helps to find them. I'll clean them out once review is done. This is only half the original problem. The other half is fixed in a previous commit. What it orginally did was assign destdir with a leading '.' then when I made some other seemingly unrelated change, moving the '.' from the assignment to the usage fixed the relative path issue. It drove me nuts trying to find it. --=20 Brian Dolbec --Sig_/fr_SSL0oWsg_Me7e9ZGdF0H Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAEBCgBmBQJUBVUQXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfLoIAIAIfiuXko88gSyjSosWcUo5wJ hcPLaqbcCT35VtUfGV/1+L2te86pHUB8MEMRMEnsdJd7FfrPViHODA+sgPB6VQ1P SYPLvmbIqsrHMmVbl+J3LAcmDZl7wIToKisKUyATQfdn+wX/nvec/K+1tS/UtIKT JlO53nkmgq1OmvqYI/1eMR9MwJqmVsSBdf4kyUwxi7/3+E+6oVH9lWYhMv2k+w7l QqPQRws44lcpBMBcPUzDqaFt9sHaUPV/+lGcsX+FuOp45txIGvQPcBqA+3v3PZv2 D5aTPNDtoQXyTHvMCyiKDijeG9iyOozCOusfPl/8WDYQvlhd8UGdLi9XKojSNYs= =A4hl -----END PGP SIGNATURE----- --Sig_/fr_SSL0oWsg_Me7e9ZGdF0H--