From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0C70D13873B for ; Wed, 5 Mar 2014 04:47:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CC150E0A04; Wed, 5 Mar 2014 04:47:49 +0000 (UTC) Received: from QMTA11.westchester.pa.mail.comcast.net (qmta11.westchester.pa.mail.comcast.net [76.96.59.211]) by pigeon.gentoo.org (Postfix) with ESMTP id 4D0E2E0A04 for ; Wed, 5 Mar 2014 04:47:49 +0000 (UTC) Received: from omta22.westchester.pa.mail.comcast.net ([76.96.62.73]) by QMTA11.westchester.pa.mail.comcast.net with comcast id ZglA1n0011ap0As5BgnpqE; Wed, 05 Mar 2014 04:47:49 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta22.westchester.pa.mail.comcast.net with comcast id Zgnn1n00m152l3L3ignoY2; Wed, 05 Mar 2014 04:47:48 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 8927C10683F3; Tue, 4 Mar 2014 20:47:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1393994867; bh=sGpW7riv98VYnsDKuj9mwCDyjsVx+ECLpxBfAc5Cbcc=; h=Date:From:To:Subject:References:In-Reply-To; b=pj2ybnBzKO99gibLKfJNiLgGlj0SG/UmhP18qkQoBR4O+AiEWmCsfM2XwYUfX/Z+h b2982usUfNz8sN0hV7i2ZLQwZ7JG2PvJa+BzDJNdPkp25j2l3aCKfBIloBEDGtfIAb G/P+83K4SOk6HB4QLwvt1QLRNFMBtmlE3Ju4/JZo= Date: Tue, 4 Mar 2014 20:47:47 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: [gentoo-catalyst] Re: [PATCH 2/5] generic_stage_target.py: Fix an intermittent snapshot_cache_path keyerror Message-ID: <20140305044747.GD25297@odin.tremily.us> References: <1393801262-13820-2-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BRE3mIcgqKzpedwo" Content-Disposition: inline In-Reply-To: <1393801262-13820-2-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1393994869; bh=ERpDoioVBhLod/W7GpN34kZJ4cuBTdD6BQQ+qmGeJLE=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=V9EdN4qjVLxEacSXONKMmkJF86O+4BQvSI3ECcw52S1CsL/jJCJc+slfTfibGomW0 LZ/lzosQLrSKmqw7H+yrxlTufRE+m5BrdBuXA01IWdXSxRmDuJevhYOankvbPxmHUZ yUXUH3sauvD/yzyFmcI2LlUdbMc892HrYCoJsISGbzBmNPBeGUglFWkahQwPejEfcN f7EsGT5f5RFyBnjhhXUOhIMkA+vL17LXUWZInWjW5T36JPegUbe0c+EHcre65UnheL DlcSlzNeBfBOMdYpq/I0m84wMMRtdVsul0I4bfJNWPG8iqZrqZeBJOgcKfXKbomRTZ PTW0ewS6uarLQ== X-Archives-Salt: 74fa8465-7259-48ed-9328-25c10542a54c X-Archives-Hash: d8d015892e5cc3489864a38e5474ccc6 --BRE3mIcgqKzpedwo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 02, 2014 at 03:00:59PM -0800, Brian Dolbec wrote: > def set_snapcache_path(self): > + self.settings["snapshot_cache_path"] =3D \ > + normpath(self.settings["snapshot_cache"] + "/" + > + self.settings["snapshot"]) > if "SNAPCACHE" in self.settings: > - self.settings["snapshot_cache_path"] =3D \ > - normpath(self.settings["snapshot_cache"] + "/" + > - self.settings["snapshot"]) If we're getting snapshot_cache_path key errors, I think the solution is to protect those call sites with: if 'SNAPCACHE' in self.settings: blocks, not to define a snapcache-only setting for folks who are not using snapcaches. There are not particularly many snapshot_cache_path references in catalyst. Grepping through them, the following looks suspicious: catalyst/targets/generic_stage_target.py-215- self.mountmap["port= dir"] =3D normpath("/".join([ catalyst/targets/generic_stage_target.py:216: self.settin= gs["snapshot_cache_path"], catalyst/targets/generic_stage_target.py-217- self.settin= gs["repo_name"], catalyst/targets/generic_stage_target.py-218- ])) catalyst/targets/generic_stage_target.py-219- if "SNAPCACHE" not = in self.settings: Everything else looks fine. So what should portdir be if SNAPCACHE isn't set? Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --BRE3mIcgqKzpedwo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTFqxyAAoJEKKfehoaNkbtNy4P/iQNkILktVw2oH8HjeJjtw3h qp9D/MqPoWoOxmQMY17DqydGMJaB9OCPS9WNyOOlv65WryevjzFJD2AUNEOd40+0 vBrAIQ5690e5+3XXH9a/gScnHsR6sh2H0p9hsqgYz5MhRVDq7rmdQH7odtnetCKn Pgu0hvZs84A1gdD5xoLmH7AzFKVxraofLMM3ytXaJWKc9yRUAn9Ci4y+gv/gR43C m9ZiseQNekyLMz2njX4O5o2aD9dy7XBasYCnUrPxHX7dcnhmaZtigxBVczP1HBav dDw+6RG8d+kAuKbaCh3U8uoMmRq/ngYPzegAJOTg/G0gBSXZvh6d5VjCogkRlyhO 7uDC/8QZUmwIwO6Q2G28LKA2Ey+CbSXOCKbdRPZQpd5egZMDVH8c5hnq197thqsH GGuWdkNCvwbovPUbTyjJXXHVt4KotuqKtGMa027mpCdXE6ev680COiDw8mY4WyDC /ade9WyI3NHf39mljsrvJklUQQ+SbzCfSFfCCrm/crOum7iFu7tZBLy6L2ME7OKd y/KRiyaDre0mMebrhENPG9oGx+GMfG1xBm+wAOtEB9DAhuFILbYdT0OjgKv+8Qq3 OBZAxzFfVNn+BVCivWQR0eGX/LwLrbx3ivxRLxMsRSAO0s6CpvJ88LqwFnKUuk6e dVPXzHTuJbq7VJVE+Yl/ =cYYc -----END PGP SIGNATURE----- --BRE3mIcgqKzpedwo--