From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B0923138010 for ; Sun, 31 Mar 2013 14:46:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4C3B7E09C7; Sun, 31 Mar 2013 14:46:08 +0000 (UTC) Received: from vms173005pub.verizon.net (vms173005pub.verizon.net [206.46.173.5]) by pigeon.gentoo.org (Postfix) with ESMTP id B22BBE09C7 for ; Sun, 31 Mar 2013 14:46:07 +0000 (UTC) Received: from odin.tremily.us ([unknown] [72.68.93.192]) by vms173005.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MKJ00C5250OYP70@vms173005.mailsrvcs.net> for gentoo-catalyst@lists.gentoo.org; Sun, 31 Mar 2013 09:46:01 -0500 (CDT) Received: by odin.tremily.us (Postfix, from userid 1000) id 905BF945B33; Sun, 31 Mar 2013 10:45:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1364741159; bh=Afn30IbOVny94k0SlqUIV+fmY30YZ91L/i0MunyA0No=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=QYFklomLJ7RQ6Dmvg2n4NCNlnU/k72T48kQJQyfm/vU4/bi8NiQi3japmXJ9d4AGj 7sOprV6ljlQhVG04rhLDyPzj9JYhu704BYU2oPyvsA8iQ+da+663pth2NvfgK1nCGM 6/sNeyNjHf/InuXt7U5tMdf9HLuZZcCnnLzJODqE= Date: Sun, 31 Mar 2013 10:45:59 -0400 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Cc: "Jorge Manuel B. S. Vicetto (jmbsvicetto)" Subject: [gentoo-catalyst] Re: [PATCH] Make the use of preserved_libs optional by setting the options variable. Message-id: <20130331144559.GA27632@odin.tremily.us> References: <1364697105-23663-1-git-send-email-jmbsvicetto@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-version: 1.0 Content-type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary=17pEHd4RhPHOinZp Content-disposition: inline In-reply-to: <1364697105-23663-1-git-send-email-jmbsvicetto@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: c266a902-31e2-49e1-9f53-f037b6d5f09f X-Archives-Hash: df9b88bc2b54c333f307bc9440136c6b --17pEHd4RhPHOinZp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 31, 2013 at 02:31:45AM +0000, Jorge Manuel B. S. Vicetto (jmbsv= icetto) wrote: > diff --git a/catalyst b/catalyst > index 9f8dd30..f885dd4 100755 > --- a/catalyst > +++ b/catalyst > @@ -147,6 +147,9 @@ def parse_config(myconfig): > if "pkgcache" in string.split(conf_values["options"]): > print "Package cache support enabled." > conf_values["PKGCACHE"]=3D"1" > + if "preserve_libs" in string.split(conf_values["options"]); > + print "Preserving libs during unmerge." > + conf_values["PRESERVE_LIBS"]=3D"1" > =20 > if "purge" in string.split(conf_values["options"]): > print "Purge support enabled." > diff --git a/files/catalyst.conf b/files/catalyst.conf > index f88f105..2983acc 100644 > --- a/files/catalyst.conf > +++ b/files/catalyst.conf > @@ -59,6 +59,8 @@ hash_function=3D"crc32" > # build stops in livecd-stage2) > # pkgcache =3D keeps a tbz2 of every built package (useful if your build= stops > # prematurely) > +# preserve_libs =3D enables portage to preserve used libs when unmerging= packages > +# (used on installcd-stage2 and stage4 targets) > # seedcache =3D use the build output of a previous target if it exists t= o speed up > # the copy > # snapcache =3D cache the snapshot so that it can be bind-mounted into t= he chroot. Your whitespace looks inconsistent. You're missing a blank line before `if "preserve_libs" =E2=80=A6`, and you've got some extra space in t= he wrapped catalyst.conf comment. It looks like the existing catalyst.conf comments aren't particularly consistent, but the two existing choices seem to be `#` and `#`. Other than that, I like this patch. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --17pEHd4RhPHOinZp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRWEwmAAoJEEUbTsx0l5OMa60P/0P11GBXOPR5GfrjO4ZNMad8 XRwT/cLYZS2mGSp/lGPCvnxAsFleOj7HR7V6EQjnWcNB+tx3rUGfPZMXJg72s7b9 cqx0408Scv1hZt4g7Ttejm77LQwP+Om6FI/mbmHt6XOPcwsuGNM7vMU7NINWGH6L 8JXJ+YmBaYI00jihhOxhxXTzupRClgDcu79bfG7BM5GpdKXxsZukzAeXhNr+PwMY nIId4TAWN9Ateh+pQ0VCgILa4xDuGvM67WWJDCrfcpY2fwEX7qv2usdAOmMYEOMk HlIj5ZJ7t59y1nWVzJRmhwTUk5oilfUxzFNCRdcVOSCM2jccFnBHRng9L4WamDFL Z6ZIGt/KngMmiAgczxpxWiOTBxQ82Yp+OOTRA557RTM9L7nRrRgJz+XodOHCnLcK CpYRVqfarQeZ8kv6/+3FMa2PFuHXaVjPchn1KpCtKQ492V5GVxcQl+Y0am6cfJcd sNij8CsmcoNKGurcPTYKWXU/lv2X6GE7S6cOgro8ZzowTzx+pw4czIzKTy5J85qQ Td5ksRIDVTwjLw9M+NGs5gcJpCKuuHxBam5Uzx/qexSV9B/VXPp2nyuUoWiuXmxh ITICGOSJ151dzF+B/L9JH/FMI2L0tD2ANGJ3+WDD4ezyXN4JA94A6L70ChWKatKb AZxsXc/+SetEyxIOaE7K =fJkU -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--