public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: "W. Trevor King" <wking@tremily.us>
To: gentoo-catalyst@lists.gentoo.org
Cc: "Jorge Manuel B. S. Vicetto (jmbsvicetto)" <jmbsvicetto@gentoo.org>
Subject: [gentoo-catalyst] Re: [PATCH] Make the use of preserved_libs optional by setting the options variable.
Date: Sun, 31 Mar 2013 10:45:59 -0400	[thread overview]
Message-ID: <20130331144559.GA27632@odin.tremily.us> (raw)
In-Reply-To: <1364697105-23663-1-git-send-email-jmbsvicetto@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]

On Sun, Mar 31, 2013 at 02:31:45AM +0000, Jorge Manuel B. S. Vicetto (jmbsvicetto) wrote:
> diff --git a/catalyst b/catalyst
> index 9f8dd30..f885dd4 100755
> --- a/catalyst
> +++ b/catalyst
> @@ -147,6 +147,9 @@ def parse_config(myconfig):
>  	if "pkgcache" in string.split(conf_values["options"]):
>  		print "Package cache support enabled."
>  		conf_values["PKGCACHE"]="1"
> +	if "preserve_libs" in string.split(conf_values["options"]);
> +		print "Preserving libs during unmerge."
> +		conf_values["PRESERVE_LIBS"]="1"
>  
>  	if "purge" in string.split(conf_values["options"]):
>  		print "Purge support enabled."
> diff --git a/files/catalyst.conf b/files/catalyst.conf
> index f88f105..2983acc 100644
> --- a/files/catalyst.conf
> +++ b/files/catalyst.conf
> @@ -59,6 +59,8 @@ hash_function="crc32"
>  #	build stops in livecd-stage2)
>  # pkgcache = keeps a tbz2 of every built package (useful if your build stops
>  #	prematurely)
> +# preserve_libs = enables portage to preserve used libs when unmerging packages
> +#   (used on installcd-stage2 and stage4 targets)
>  # seedcache = use the build output of a previous target if it exists to speed up
>  #	the copy
>  # snapcache = cache the snapshot so that it can be bind-mounted into the chroot.

Your whitespace looks inconsistent.  You're missing a blank line
before `if "preserve_libs" …`, and you've got some extra space in the
wrapped catalyst.conf comment.  It looks like the existing
catalyst.conf comments aren't particularly consistent, but the two
existing choices seem to be `#<TAB><COMMENT>` and
`#<SPACE><TAB><COMMENT>`.

Other than that, I like this patch.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-03-31 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-31  2:31 [gentoo-catalyst] [PATCH] Make the use of preserved_libs optional by setting the options variable Jorge Manuel B. S. Vicetto (jmbsvicetto)
2013-03-31 14:45 ` W. Trevor King [this message]
2013-04-01  2:21 ` Rick "Zero_Chaos" Farina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130331144559.GA27632@odin.tremily.us \
    --to=wking@tremily.us \
    --cc=gentoo-catalyst@lists.gentoo.org \
    --cc=jmbsvicetto@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox