Re: [gentoo-catalyst] [PATCH] livecdfs-update.sh: Fix '/etc/sshd' check for sshd_config tweaks

["W. Trevor King" <wking@tremily.us>]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Sun, Mar 03, 2013 at 08:13:37AM -0800, Brian Dolbec wrote:
> On Sun, 2013-03-03 at 08:01 -0500, W. Trevor King wrote:
> > sshd_config lives in /etc/ssh, not /etc/sshd.  This typo has been
> > present since the block was introduced by c06264e (Initial import of
> > Catalyst 2.0.0, 2005-04-04), so it's obviously not a widely used
> > feature ;).  It might be better to just remove the block entirely.
> > ---
> > …
> It would be better to move the hard coding out of the bash script and
> either into the config defaults or in this case (it's only used in the
> one target) added to the target stage py file.  In that way the default
> value can be overwritten in the target spec file. 

I think I'd rather remove this block entirely.  Adding a separate
“enable root logins via SSH” option (and phase?) doesn't sound very
appealing.  This sort of thing is better suited to a per-user
fsscript, especially if the in-catalyst support has always been
broken.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]