From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-catalyst+bounces-3288-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A14F113888F for <garchives@archives.gentoo.org>; Tue, 6 Oct 2015 15:06:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7329721C05A; Tue, 6 Oct 2015 15:05:49 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2A34F21C05A for <gentoo-catalyst@lists.gentoo.org>; Tue, 6 Oct 2015 15:05:44 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 669BE340AB5 for <gentoo-catalyst@lists.gentoo.org>; Tue, 6 Oct 2015 15:05:38 +0000 (UTC) From: Mike Frysinger <vapier@gentoo.org> To: gentoo-catalyst@lists.gentoo.org Subject: [gentoo-catalyst] [PATCH 13/13] lint: clean up superfluous parens Date: Tue, 6 Oct 2015 11:05:29 -0400 Message-Id: <1444143929-26705-13-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 2.5.2 In-Reply-To: <1444143929-26705-1-git-send-email-vapier@gentoo.org> References: <1444143929-26705-1-git-send-email-vapier@gentoo.org> Precedence: bulk List-Post: <mailto:gentoo-catalyst@lists.gentoo.org> List-Help: <mailto:gentoo-catalyst+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-catalyst+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-catalyst+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-catalyst.gentoo.org> X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Archives-Salt: f3bc2457-62b7-4853-a94c-b66c885a5e5f X-Archives-Hash: 3abcf0cd4ae0d48ff6154c3e0ec34d57 These don't need the parens, so omit them. In the case of setup.py, we were expecting a print function, not a keyword, so make sure to import that module. --- catalyst/lock.py | 6 +++--- doc/make_subarch_table_guidexml.py | 6 +++--- setup.py | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/catalyst/lock.py b/catalyst/lock.py index d079b2d..3d50c06 100644 --- a/catalyst/lock.py +++ b/catalyst/lock.py @@ -179,7 +179,7 @@ class LockDir(object): if not os.path.exists(self.lockfile): print "lockfile does not exist '%s'" % self.lockfile #print "fcntl_unlock() , self.myfd:", self.myfd, type(self.myfd) - if (self.myfd != None): + if self.myfd != None: #print "fcntl_unlock() trying to close it " try: os.close(self.myfd) @@ -236,7 +236,7 @@ class LockDir(object): #if type(lockfilename) == types.StringType: # os.close(myfd) #print "fcntl_unlock() trying a last ditch close", self.myfd - if (self.myfd != None): + if self.myfd != None: os.close(self.myfd) self.myfd=None self.locked=False @@ -256,7 +256,7 @@ class LockDir(object): start_time = time.time() reported_waiting = False - while(time.time() < (start_time + max_wait)): + while time.time() < (start_time + max_wait): # We only need it to exist. self.myfd = os.open(self.myhardlock, os.O_CREAT|os.O_RDWR,0660) os.close(self.myfd) diff --git a/doc/make_subarch_table_guidexml.py b/doc/make_subarch_table_guidexml.py index 54e0a4a..a6a9022 100755 --- a/doc/make_subarch_table_guidexml.py +++ b/doc/make_subarch_table_guidexml.py @@ -30,7 +30,7 @@ def handle_line(line, subarch_title_to_subarch_id, subarch_id_to_pattern_arch_ge # Apply alias grouping arch = _pattern_arch_genericliases.get(arch, arch) - assert(subarch not in subarch_id_to_pattern_arch_genericrch_id) + assert subarch not in subarch_id_to_pattern_arch_genericrch_id subarch_id_to_pattern_arch_genericrch_id[subarch] = arch return @@ -40,7 +40,7 @@ def handle_line(line, subarch_title_to_subarch_id, subarch_id_to_pattern_arch_ge child_subarch = x.group(1) parent_subarch = x.group(2) - assert(child_subarch not in subarch_id_to_pattern_arch_genericrch_id) + assert child_subarch not in subarch_id_to_pattern_arch_genericrch_id subarch_id_to_pattern_arch_genericrch_id[child_subarch] = subarch_id_to_pattern_arch_genericrch_id[parent_subarch] return @@ -49,7 +49,7 @@ def handle_line(line, subarch_title_to_subarch_id, subarch_id_to_pattern_arch_ge subarch_title = x.group(1) subarch_id = x.group(2) - assert(subarch_title not in subarch_title_to_subarch_id) + assert subarch_title not in subarch_title_to_subarch_id subarch_title_to_subarch_id[subarch_title] = subarch_id diff --git a/setup.py b/setup.py index e4569ee..a875db1 100755 --- a/setup.py +++ b/setup.py @@ -1,5 +1,6 @@ """Catalyst is a release building tool used by Gentoo Linux""" +from __future__ import print_function import codecs as _codecs from distutils.core import setup as _setup, Command as _Command -- 2.5.2