From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C2ACA13888F for ; Tue, 6 Oct 2015 15:06:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 90FA921C04F; Tue, 6 Oct 2015 15:05:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0609721C04C for ; Tue, 6 Oct 2015 15:05:38 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 5026B340AB5 for ; Tue, 6 Oct 2015 15:05:37 +0000 (UTC) From: Mike Frysinger To: gentoo-catalyst@lists.gentoo.org Subject: [gentoo-catalyst] [PATCH 10/13] lint: init all members in __init__ Date: Tue, 6 Oct 2015 11:05:26 -0400 Message-Id: <1444143929-26705-10-git-send-email-vapier@gentoo.org> X-Mailer: git-send-email 2.5.2 In-Reply-To: <1444143929-26705-1-git-send-email-vapier@gentoo.org> References: <1444143929-26705-1-git-send-email-vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org X-Archives-Salt: c8eca762-d454-49e8-9800-40caed515eb4 X-Archives-Hash: 6dfa70abcdce008291264273b6709f96 A few class members were being set outside of __init__. Usually this is an oversight, so having the linter complain is helpful. Set up the few places in the code that don't do this. --- catalyst/base/stagebase.py | 2 ++ catalyst/lock.py | 1 + 2 files changed, 3 insertions(+) diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py index e393c5b..7bc7522 100644 --- a/catalyst/base/stagebase.py +++ b/catalyst/base/stagebase.py @@ -73,6 +73,7 @@ class StageBase(TargetBase, ClearBase, GenBase): previously. -agaffney """ + self.makeconf = {} self.archmap = {} self.subarchmap = {} machinemap = {} @@ -156,6 +157,7 @@ class StageBase(TargetBase, ClearBase, GenBase): self.set_source_subpath() """ Set paths """ + self.snapshot_lock_object = None self.set_snapshot_path() self.set_root_path() self.set_source_path() diff --git a/catalyst/lock.py b/catalyst/lock.py index d6653f7..d079b2d 100644 --- a/catalyst/lock.py +++ b/catalyst/lock.py @@ -54,6 +54,7 @@ class LockDir(object): else: LockDir.lock_dirs_in_use.append(lockdir) + self.myhardlock = None self.hardlock_paths={} def delete_lock_from_path_list(self): -- 2.5.2