Re: [gentoo-catalyst] [PATCH 4/6] Fix mounts and mountmap port_logdir code block.

[Brian Dolbec <dolsen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

On Sun, 2013-12-29 at 20:09 -0800, W. Trevor King wrote:
> On Sun, Dec 29, 2013 at 05:50:51PM -0800, Brian Dolbec wrote:
> > +PORT_LOGDIR_CLEAN = \
> > +	'find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delete'
> 
> Pulling out this global variable is new for v2.  I don't think I'm a
> fan.  I think it should either be hard-coded where we setup
> env["PORT_LOGDIR_CLEAN"] (as it was before) or pulled out of
> self.settings (like PORT_LOGDIR).
> 
> > -			self.mounts.append("/var/log/portage")
> > -			self.mountmap["/var/log/portage"]=self.settings["port_logdir"]
> > -			self.env["PORT_LOGDIR"]="/var/log/portage"
> > -			self.env["PORT_LOGDIR_CLEAN"]='find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delete'
> > +			self.mounts.append("port_logdir")
> > +			self.mountmap["port_logdir"] = self.settings["port_logdir"]
> > +			self.env["PORT_LOGDIR"] = self.settings["port_logdir"]
> > +			self.env["PORT_LOGDIR_CLEAN"] = PORT_LOGDIR_CLEAN
> 
> Other than the newly-global PORT_LOGDIR_CLEAN, this looks good to me.
> 
> Cheers,
> Trevor
> 

PORT_LOGDIR_CLEAN is a copy of the setting directly from portage.  I
fully intend on importing it later when it makes more sense to actually
make use of some of portage's api.  In the meantime this moves it out of
a long line situation in the code block that would have meant cutting
and splicing it back together.  When the commit that makes the new
defaults.py file is merged.  It will be moved there.  Later when we
import some info/code from portage. We can assign it accordingly.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 620 bytes --]