public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Dylan Baker <baker.dylan.c@gmail.com>
To: gentoo-catalyst@lists.gentoo.org
Cc: Dylan Baker <baker.dylan.c@gmail.com>
Subject: [gentoo-catalyst] [Patch v2 3/4] catalyst: split combined import
Date: Sun, 13 Oct 2013 02:07:37 -0700	[thread overview]
Message-ID: <1381655258-6084-3-git-send-email-baker.dylan.c@gmail.com> (raw)
In-Reply-To: <1381655258-6084-1-git-send-email-baker.dylan.c@gmail.com>

Combining multiple modules into a single import is discouraged in
python's PEP8 style guide:

"""
Imports should usually be on separate lines, e.g.:

Yes: import os
     import sys

     No:  import sys, os
"""
---
 catalyst | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/catalyst b/catalyst
index 2378a87..36bd709 100755
--- a/catalyst
+++ b/catalyst
@@ -7,7 +7,11 @@
 # Chris Gianelloni <wolf31o2@wolf31o2.org>
 # $Id$
 
-import os, sys, imp, string, getopt
+import os
+import sys
+import imp
+import string
+import getopt
 import pdb
 import os.path
 
-- 
1.8.1.5



  parent reply	other threads:[~2013-10-13  9:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-13  9:07 [gentoo-catalyst] [Patch v2 1/4] catalyst: Specify python2 rather than the generic python Dylan Baker
2013-10-13  9:07 ` [gentoo-catalyst] [Patch v2 2/4] Catalyst: use a more pythonic method to import modules Dylan Baker
2013-10-13  9:07 ` Dylan Baker [this message]
2013-10-13  9:07 ` [gentoo-catalyst] [Patch v2 4/4] catalyst: Remove commented sections of code Dylan Baker
2013-10-13 20:15 ` [gentoo-catalyst] [Patch v2 1/4] catalyst: Specify python2 rather than the generic python Brian Dolbec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381655258-6084-3-git-send-email-baker.dylan.c@gmail.com \
    --to=baker.dylan.c@gmail.com \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox