public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-catalyst] [patch] Whitespace cleanup
@ 2013-02-27  9:03 ` Brian Dolbec
  2013-02-27 12:25   ` W. Trevor King
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Dolbec @ 2013-02-27  9:03 UTC (permalink / raw
  To: gentoo-catalyst@lists.gentoo.org

I've rebased the commit, removing the whitespace changes in COPYING as
Matt suggested.

This commit is suitable for current master as well.  It should apply
cleanly.

================================================

diff --git a/ChangeLog b/ChangeLog
index 893cfec..12b41f2 100644
@@ -1798,7 +1798,7 @@
   Removed famd from the default runlevel for gentoo-release-livecd. It really
   shouldn't cause a problem, but I prefer it stay a bit clean.
 
-  11 Jul 2006; Chris Gianelloni <wolf31o2@gentoo.org> 
+  11 Jul 2006; Chris Gianelloni <wolf31o2@gentoo.org>
   modules/generic_stage_target.py, targets/support/bootloader-setup.sh,
   targets/support/create-iso.sh, targets/support/kmerge.sh,
   targets/support/livecdfs-update.sh, targets/support/mips-arcload_conf.sh:
@@ -2432,7 +2432,7 @@
   10 Jan 2006; Eric Edgar <rocket@gentoo.org>
   modules/generic_stage_target.py, targets/support/kmerge.sh:
   filter kname - and . for kmerge.sh
-  
+
   10 Jan 2006; Chris Gianelloni <wolf31o2@gentoo.org>
   targets/support/create-iso.sh:
   Added sparc64 to sparc lines for create-iso.sh to fix ISO creation on sparc64.
@@ -3437,7 +3437,7 @@
 
   06 Jul 2005; Eric Edgar <rocket@gentoo.org> targets/support/create-iso.sh:
   Fix iso creation script.  Case statement out of place
-  
+
   05 Jul 2005; Chris Gianelloni <wolf31o2@gentoo.org> arch/alpha.py,
   arch/amd64.py, arch/hppa.py, arch/ia64.py, arch/mips.py, arch/ppc.py,
   arch/ppc64.py, arch/s390.py, arch/sparc.py, arch/sparc64.py, arch/x86.py,
@@ -4762,10 +4762,10 @@
   fixes for bugs #55192 and #54137
   added a new key for all specfiles, portage_confdir.
   this should point to a directory similar in functionality to /etc/portage.
-  
+
   cleaned up the module code a bit so that unnecessary modules
   are not imported.
-  
+
   more work on resuming. it is getting there, but it still needs a ton of work,
   so please test, and report bugs.
 
@@ -4790,7 +4790,7 @@
   of me doing this is that SIGINT (ctrl-c) makes catalyst die nice and proper
   now. Additionally, catalyst will stop when there is an error with an ebuild
   ... it didn't do this before, it just plowed along and packed things up.
-  
+
   Much thanks to <carpaski@gentoo.org> for (writing) pointing me to the spawn()
   code in portage.py and then answering my noob questions.
 
@@ -4974,7 +4974,7 @@
   05 Apr 2004; John Davis <zhen@gentoo.org> modules/targets.py:
   bugfix for #46861
 
-  04 Apr 2004; Benjamin Judas <beejay@gentoo.org> 
+  04 Apr 2004; Benjamin Judas <beejay@gentoo.org>
   livecd/kconfig/config-2004.1-gentoo-dev-sources-2.6.3-r1,
   livecd/kconfig/config-2004.1-xfs-sources-2.4.24-r3:
   Added the two kernel-configs for 2004.1 x86
@@ -5052,8 +5052,8 @@
   examples/livecd/runscript/alpha-archscript.sh, files/catalyst.conf:
   fixes for bugs 43676, 43701. Alpha support added as well.
 
-  25 Feb 2004; Pieter Van den Abeele <pvdabeel@gentoo.org>: 
-  added powerpc livecd support, preparing for 2004.0 release. Preliminary 
+  25 Feb 2004; Pieter Van den Abeele <pvdabeel@gentoo.org>:
+  added powerpc livecd support, preparing for 2004.0 release. Preliminary
   kde/gnome cd specs added.
 
   18 Feb 2004; John Davis <zhen@gentoo.org> files/catalyst.conf:
@@ -5070,7 +5070,7 @@
   point to a file to use in place of /etc/catalyst.conf. By setting this
   variable in your shell, catalyst can easily be used by multiple people on the
   same machine. Also, ccache support now works for genkernel.
-  
+
   11 Feb 2004; Daniel Robbins <drobbins@gentoo.org>:
   removed file for livecd-stage2 target, as this is handled by the runscript
   now. Added support for "/boot/kernel/foo/use", "/boot/kernel/foo/packages,"
@@ -5097,34 +5097,34 @@
 
   29 Nov 2003; Daniel Robbins <drobbins@gentoo.org>:
   Tinderbox target added. See tinderbox examples in examples/ dir.
-  
+
   08 Nov 2003; Daniel Robbins <drobbins@gentoo.org>:
   spec file support integrated into catalyst. Use "-f/--file specfile" as
   argument; see examples dir for examples.
   "grp" target now functional. See examples/x86-grp-20031102.spec for an
   example of how to use it.
- 
+
   08 Nov 2003; Daniel Robbins <drobbins@gentoo.org>:
   support functions for spec file parsing and reading added. Will get added to
   the code soon.
-  
+
   05 Nov 2003; Daniel Robbins <drobbins@gentoo.org>:
   Many bug fixes later, things seem to be working well for stage1/2/3 so I've
   added a README.
-  
+
   28 Oct 2003; Daniel Robbins <drobbins@gentoo.org>:
   Significant rework of code structure. Everything is falling nicely into place.
-  
+
   28 Oct 2003; Daniel Robbins <drobbins@gentoo.org>:
   Exception handling fully-integrated into current prototype code.
-  
+
   27 Oct 2003; Daniel Robbins <drobbins@gentoo.org>:
   beginning of exception handling integration, got some of the target code
   nicely fleshed out.
-  
+
   24 Oct 2003; Daniel Robbins <drobbins@gentoo.org>:
   major code rework in progress on the python parts.
-  
+
   17 Oct 2003; John Davis <zhen@gentoo.org> files/grp/x86/x86.conf,
   files/grp/x86/x86.pkg.cd1, files/grp/x86/x86.pkg.cd2, files/grp/x86/x86.src,
   files/livecd/x86-basic/base.pkg, files/livecd/x86-basic/kern.pkg:
@@ -5146,7 +5146,7 @@
 
   12 Oct 2003; Daniel Robbins <drobins@gentoo.org>:
   subarch test outsourced to python catalyst-subarches function.
-  
+
   12 Oct 2003; John Davis <zhen@gentoo.org> include/build_functions.sh:
   fixed the entry in include/build_functions.sh for location of bootstrap.sh
 
@@ -5159,7 +5159,7 @@
   12 Oct 2003; Robin H. Johnson <robbat2@gentoo.org> catalyst:
   Fix valid subarch test.
 
-  12 Oct 2003; John Davis <zhen@gentoo.org> catalyst, 
+  12 Oct 2003; John Davis <zhen@gentoo.org> catalyst,
   include/build_functions.sh, include/functions.sh:
   thanks to robbat2, the cmdline argument handling is now fixed. I moved
   start_build to build_functions.sh cleaning up the main catalyst script some
@@ -5183,7 +5183,7 @@
   08 Oct 2003; John Davis <zhen@gentoo.org> catalyst:
   I changed the is_special handling so that it is cleaner and faster
 
-  08 Oct 2003; John Davis <zhen@gentoo.org> catalyst, include/functions.sh, 
+  08 Oct 2003; John Davis <zhen@gentoo.org> catalyst, include/functions.sh,
   livecd/foundations/x86-basic/base.pkg, livecd/foundations/x86-basic/kern.pkg,
   livecd/foundations/x86-basic/post-clean.sh,
   livecd/foundations/x86-basic/pre-clean.sh,
@@ -5231,7 +5231,7 @@
   stage*-arch-etdyn-ssp.* re method's request. This will not be the first time
   I change naming conventions, as catalyst will be eventually extended to
   do selinux-* stages also.
-  
+
   Additionally, I updated README.catalyst to include profile information.
 
   10 Sep 2003; John Davis <zhen@gentoo.org> README.catalyst, README.stager,
diff --git a/arch/alpha.py b/arch/alpha.py
index 3fd9b3d..f0fc95a 100644
@@ -71,5 +71,5 @@ def register():
 	"Inform main catalyst program of the contents of this plugin."
 	return ({ "alpha":arch_alpha, "ev4":arch_ev4, "ev45":arch_ev45,
 		"ev5":arch_ev5, "ev56":arch_ev56, "pca56":arch_pca56,
-		"ev6":arch_ev6, "ev67":arch_ev67 }, 
+		"ev6":arch_ev6, "ev67":arch_ev67 },
 	("alpha", ))
diff --git a/arch/arm.py b/arch/arm.py
index 4ba5a83..2de3942 100644
@@ -8,7 +8,7 @@ class generic_arm(builder.generic):
 		builder.generic.__init__(self,myspec)
 		self.settings["CHROOT"]="chroot"
 		self.settings["CFLAGS"]="-O2 -pipe"
-   
+
 class generic_armeb(builder.generic):
 	"Abstract base class for all arm (big endian) builders"
 	def __init__(self,myspec):
@@ -129,5 +129,5 @@ def register():
 		"armv7a_hardfp" : arch_armv7a_hardfp,
 		"armeb"  : arch_armeb,
 		"armv5teb" : arch_armv5teb
-	}, ("arm", "armv4l", "armv4tl", "armv5tl", "armv5tel", "armv5tejl", "armv6l", 
+	}, ("arm", "armv4l", "armv4tl", "armv5tl", "armv5tel", "armv5tejl", "armv6l",
 "armv7l", "armeb", "armv5teb") )
diff --git a/arch/mips.py b/arch/mips.py
index 9ea2d0e..b3730fa 100644
@@ -398,7 +398,7 @@ class arch_cobalt_n32(generic_mips64el):
 
 def register():
 	"Inform main catalyst program of the contents of this plugin."
-	return ({ 
+	return ({
 			"cobalt"				: arch_cobalt,
 			"cobalt_n32"			: arch_cobalt_n32,
 			"mips"					: arch_mips1,
diff --git a/arch/x86.py b/arch/x86.py
index 9d1acb3..0391b79 100644
@@ -55,7 +55,7 @@ class arch_pentium_mmx(generic_x86):
 		generic_x86.__init__(self,myspec)
 		self.settings["CFLAGS"]="-O2 -march=pentium-mmx -pipe"
 		self.settings["HOSTUSE"]=["mmx"]
-	
+
 class arch_pentium2(generic_x86):
 	"Intel Pentium 2 CPU with MMX support"
 	def __init__(self,myspec):
diff --git a/catalyst b/catalyst
index 9f8dd30..c29c814 100755
@@ -66,7 +66,7 @@ def parse_config(myconfig):
 		"portdir":"/usr/portage","options":"",\
 		"snapshot_cache":"/var/tmp/catalyst/snapshot_cache",\
 		"hash_function":"crc32"}
-		
+
 	# first, try the one passed (presumably from the cmdline)
 	if myconfig:
 		if os.path.exists(myconfig):
@@ -77,12 +77,12 @@ def parse_config(myconfig):
 			print "!!! catalyst: Could not use specified configuration file "+\
 				myconfig
 			sys.exit(1)
-	
+
 	# next, try the default location
 	elif os.path.exists("/etc/catalyst/catalyst.conf"):
 		print "Using default Catalyst configuration file, /etc/catalyst/catalyst.conf"
 		config_file="/etc/catalyst/catalyst.conf"
-	
+
 	# can't find a config file (we are screwed), so bail out
 	else:
 		print "!!! catalyst: Could not find a suitable configuration file"
@@ -93,11 +93,11 @@ def parse_config(myconfig):
 #		execfile(config_file, myconf, myconf)
 		myconfig = catalyst.config.ConfigParser(config_file)
 		myconf.update(myconfig.get_values())
-	
+
 	except:
 		print "!!! catalyst: Unable to parse configuration file, "+myconfig
 		sys.exit(1)
-	
+
 	# now, load up the values into conf_values so that we can use them
 	for x in confdefaults.keys():
 		if x in myconf:
@@ -216,9 +216,9 @@ def build_target(addlargs, targetmap):
 	try:
 		if addlargs["target"] not in targetmap:
 			raise CatalystError,"Target \""+addlargs["target"]+"\" not available."
-		
+
 		mytarget=targetmap[addlargs["target"]](conf_values, addlargs)
-	
+
 		mytarget.run()
 
 	except:
@@ -228,7 +228,7 @@ def build_target(addlargs, targetmap):
 
 if __name__ == "__main__":
 	targetmap={}
-	
+
 	version()
 	if os.getuid() != 0:
 		# catalyst cannot be run as a normal user due to chroots, mounts, etc
@@ -244,11 +244,11 @@ if __name__ == "__main__":
 	try:
 		opts,args = getopt.getopt(sys.argv[1:], "apPThvdc:C:f:FVs:", ["purge", "purgeonly", "purgetmponly", "help", "version", "debug",\
 			"clear-autoresume", "config=", "cli=", "file=", "fetch", "verbose","snapshot="])
-	
+
 	except getopt.GetoptError:
 		usage()
 		sys.exit(2)
-	
+
 	# defaults for commandline opts
 	debug=False
 	verbose=False
@@ -269,7 +269,7 @@ if __name__ == "__main__":
 		if o in ("-h", "--help"):
 			usage()
 			sys.exit(1)
-		
+
 		if o in ("-V", "--version"):
 			print "Catalyst version "+__version__
 			sys.exit(1)
@@ -287,14 +287,14 @@ if __name__ == "__main__":
 			while x < len(sys.argv):
 				mycmdline.append(sys.argv[x])
 				x=x+1
-			
+
 		if o in ("-f", "--file"):
 			run = True
 			myspecfile=a
 
 		if o in ("-F", "--fetchonly"):
 			conf_values["FETCH"]="1"
-			
+
 		if o in ("-v", "--verbose"):
 			conf_values["VERBOSE"]="1"
 
@@ -307,7 +307,7 @@ if __name__ == "__main__":
 				run = True
 				mycmdline.append("target=snapshot")
 				mycmdline.append("version_stamp="+a)
-		
+
 		if o in ("-p", "--purge"):
 			conf_values["PURGE"] = "1"
 
@@ -329,7 +329,7 @@ if __name__ == "__main__":
 	parse_config(myconfig)
 	sys.path.append(conf_values["sharedir"]+"/modules")
 	from catalyst_support import *
-	
+
 	# Start checking that digests are valid now that the hash_map was imported
 	# from catalyst_support
 	if "digests" in conf_values:
@@ -373,11 +373,11 @@ if __name__ == "__main__":
 	targetmap=import_modules()
 
 	addlargs={}
-	
+
 	if myspecfile:
 		spec = catalyst.config.SpecParser(myspecfile)
 		addlargs.update(spec.get_values())
-	
+
 	if mycmdline:
 		try:
 			cmdline = catalyst.config.ConfigParser()
@@ -393,7 +393,7 @@ if __name__ == "__main__":
 	# everything is setup, so the build is a go
 	try:
 		build_target(addlargs, targetmap)
-			
+
 	except CatalystError:
 		print
 		print "Catalyst aborting...."
diff --git a/examples/generic_stage_template.spec b/examples/generic_stage_template.spec
index b386c7c..45268ca 100644
@@ -12,7 +12,7 @@ subarch:
 # it to be, but it is usually a date.
 # example:
 # version_stamp: 2006.1
-version_stamp: 
+version_stamp:
 
 # The target specifies what target we want catalyst to do. For stages, the
 # supported targets are: stage1 stage2 stage3
@@ -45,7 +45,7 @@ snapshot:
 # default/stage3-x86-2006.1
 source_subpath:
 
-# These are the hosts used as distcc slaves when distcc is enabled in your 
+# These are the hosts used as distcc slaves when distcc is enabled in your
 # catalyst.conf.  It follows the same syntax as distcc-config --set-hosts and
 # is entirely optional.
 # example:
diff --git a/examples/grp_template.spec b/examples/grp_template.spec
index 97e49dc..8cf9e27 100644
@@ -17,7 +17,7 @@ version_stamp:
 # supported targets are: grp
 # example:
 # target: grp
-target: grp 
+target: grp
 
 # The rel_type defines what kind of build we are doing.  This is merely another
 # identifier, but it useful for allowing multiple concurrent builds.  Usually,
diff --git a/examples/livecd-stage2_template.spec b/examples/livecd-stage2_template.spec
index 18a06a4..1e27918 100644
@@ -110,7 +110,7 @@ livecd/cdtar:
 livecd/iso:
 
 # A fsscript is simply a shell script that is copied into the chroot of the CD
-# after the kernel(s) and any external modules have been compiled and is 
+# after the kernel(s) and any external modules have been compiled and is
 # executed within the chroot.  It can contain any commands that are available
 # via the packages installed by our stages or by the packages installed during
 # the livecd-stage1 build.  We do not use one for the official release media, so
@@ -204,7 +204,7 @@ livecd/rcdel:
 
 # This overlay is dropped onto the CD filesystem and is outside any loop which
 # has been configured.  This is typically used for adding the documentation,
-# distfiles, snapshots, and stages to the official media.  These files will not 
+# distfiles, snapshots, and stages to the official media.  These files will not
 # be available if docache is enabled, as they are outside the loop.
 # example:
 # livecd/overlay: /tmp/overlay-minimal
@@ -323,7 +323,7 @@ boot/kernel/gentoo/machine_type:
 # This is only supported on ppc64 currently.  This entry sets up the console=
 # boot parameters required for sending the output to the appropriate console.
 # example:
-# boot/kernel/gentoo/console: hvsi0 
+# boot/kernel/gentoo/console: hvsi0
 # boot/kernel/gentoo/console: hvc0
 # boot/kernel/gentoo/console: tty0 ttyS0
 boot/kernel/gentoo/console:
diff --git a/examples/stage4_template.spec b/examples/stage4_template.spec
index 9da5e5e..33fc0e6 100644
@@ -66,7 +66,7 @@ portage_overlay:
 # catalyst.  Mainly used as a way for different spec files to access the same
 # cache directory.  Default behavior is for this location to be autogenerated
 # by catalyst based on the spec file.
-# example: 
+# example:
 # pkgcache_path: /tmp/packages
 pkgcache_path:
 
@@ -80,7 +80,7 @@ kerncache_path:
 
 # The stage4 target is where you will build packages for basically updated
 # stage3.  These packages can be built with customized USE settings.  The
-# settings here are additive to the default USE configured by the profile.  
+# settings here are additive to the default USE configured by the profile.
 # Leaving this blank will default to the system use flags
 # example:
 # stage4/use: ipv6 socks5 fbcon ncurses readline ssl
@@ -95,7 +95,7 @@ stage4/use:
 stage4/packages:
 
 # A fsscript is simply a shell script that is copied into the chroot of the stage4
-# after the kernel(s) and any external modules have been compiled and is 
+# after the kernel(s) and any external modules have been compiled and is
 # executed within the chroot.  It can contain any commands that are available
 # via the packages installed by our stages or by the packages installed during
 # the stage4-stage1 build.  We do not use one for the official release media, so
@@ -126,7 +126,7 @@ stage4/gk_mainargs:
 # stage4/linuxrc:
 stage4/linuxrc:
 
-# This is for the message of the day.  It is not required 
+# This is for the message of the day.  It is not required
 # release media, as catalyst builds a default motd when the stage4/type is set
 # to one of the gentoo-* options.  This setting overrides the default motd even
 # on official media.  Since we do not use this for the official releases, it is
diff --git a/examples/tinderbox_template.spec b/examples/tinderbox_template.spec
index 65ccbe3..09cc20f 100644
@@ -15,7 +15,7 @@ version_stamp:
 # The target specifies what target we want catalyst to do.
 # example:
 # target: tinderbox
-target: tinderbox 
+target: tinderbox
 
 # The rel_type defines what kind of build we are doing.  This is merely another
 # identifier, but it useful for allowing multiple concurrent builds.  Usually,
diff --git a/files/catalyst.conf b/files/catalyst.conf
index f88f105..b74c546 100644
@@ -34,7 +34,7 @@ distdir="/usr/portage/distfiles"
 # export FOO="bar"
 envscript="/etc/catalyst/catalystrc"
 
-# Internal hash function catalyst should use for things like autoresume, 
+# Internal hash function catalyst should use for things like autoresume,
 # seedcache, etc.  The default and fastest is crc32.  You should not ever need
 # to change this unless your OS does not support it.
 # Supported hashes:
diff --git a/livecd/files/minimal.motd.txt b/livecd/files/minimal.motd.txt
index 1f702fc..55f6158 100644
@@ -2,7 +2,7 @@ The latest version of the Handbook is always available from the Gentoo web
 site by typing "links http://www.gentoo.org/doc/en/handbook/handbook.xml".
 
 To start an ssh server on this system, type "/etc/init.d/sshd start".  If you
-need to log in remotely as root, type "passwd root" to reset root's password 
+need to log in remotely as root, type "passwd root" to reset root's password
 to a known value.
 
 Please report any bugs you find to http://bugs.gentoo.org. Be sure to include
diff --git a/targets/stage1/build.py b/targets/stage1/build.py
index 539c4c7..bf20bcf 100644
@@ -12,7 +12,7 @@ def scan_profile(file):
 	else:
 		if "grab_multiple" in dir(portage):
 			return portage.stack_lists( portage.grab_multiple(file, portage.settings.profiles, portage.grabfile), incremental=1);
-		else:	
+		else:
 			return portage.stack_lists( [portage.grabfile_package(os.path.join(x, file)) for x in portage.settings.profiles], incremental=1);
 
 # loaded the stacked packages / packages.build files




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [gentoo-catalyst] [patch] mixed spaces/tabs and indent cleanup.
@ 2013-02-27  9:37 Brian Dolbec
  2013-02-27  9:03 ` [gentoo-catalyst] [patch] Whitespace cleanup Brian Dolbec
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Dolbec @ 2013-02-27  9:37 UTC (permalink / raw
  To: gentoo-catalyst@lists.gentoo.org

Will need to be applied manually to master, but should be done if you
intend to release another bugfix release in the 2.x series. At least use
the files changed to fix the files in current master.  I'm not sure if
this one would easily apply to master.


==============================================================


diff --git a/catalyst/targets/livecd_stage2.py b/catalyst/targets/livecd_stage2.py
index a583028..37cdd40 100644
@@ -50,7 +50,7 @@ class livecd_stage2(StageBase):
 					print_traceback=True)
 
 	def set_spec_prefix(self):
-	    self.settings["spec_prefix"]="livecd"
+		self.settings["spec_prefix"]="livecd"
 
 	def set_target_path(self):
 		self.settings["target_path"]=normpath(self.settings["storedir"]+"/builds/"+self.settings["target_subpath"]+"/")
diff --git a/catalyst/targets/netboot.py b/catalyst/targets/netboot.py
index 7ae1d75..de8dc85 100644
@@ -122,13 +122,12 @@ class netboot(StageBase):
 			self.unbind()
 			raise CatalystError("netboot build aborting due to error.",
 				print_traceback=True)
-
 		# end
 		print "netboot: build finished !"
 
 	def set_action_sequence(self):
-	    self.settings["action_sequence"]=["unpack","unpack_snapshot",
-	    				"config_profile_link","setup_confdir","bind","chroot_setup",\
-						"setup_environment","build_packages","build_busybox",\
-						"build_kernel","copy_files_to_image",\
-						"clean","create_netboot_files","unbind","clear_autoresume"]
+		self.settings["action_sequence"]=["unpack","unpack_snapshot",
+			"config_profile_link","setup_confdir","bind","chroot_setup",\
+			"setup_environment","build_packages","build_busybox",\
+			"build_kernel","copy_files_to_image",\
+			"clean","create_netboot_files","unbind","clear_autoresume"]
diff --git a/catalyst/targets/netboot2.py b/catalyst/targets/netboot2.py
index e8e7d22..f9b2a7b 100644
@@ -165,8 +165,8 @@ class netboot2(StageBase):
 		touch(self.settings["autoresume_path"]+"empty")
 
 	def set_action_sequence(self):
-	    self.settings["action_sequence"]=["unpack","unpack_snapshot","config_profile_link",
-	    				"setup_confdir","portage_overlay","bind","chroot_setup",\
-					"setup_environment","build_packages","root_overlay",\
-					"copy_files_to_image","setup_overlay","build_kernel","move_kernels",\
-					"remove","empty","unbind","clean","clear_autoresume"]
+		self.settings["action_sequence"]=["unpack","unpack_snapshot","config_profile_link",
+			"setup_confdir","portage_overlay","bind","chroot_setup",\
+			"setup_environment","build_packages","root_overlay",\
+			"copy_files_to_image","setup_overlay","build_kernel","move_kernels",\
+			"remove","empty","unbind","clean","clear_autoresume"]
diff --git a/catalyst/targets/stage4.py b/catalyst/targets/stage4.py
index f959c4a..310344c 100644
@@ -15,10 +15,10 @@ class stage4(StageBase):
 		self.required_values=["stage4/packages"]
 		self.valid_values=self.required_values[:]
 		self.valid_values.extend(["stage4/use","boot/kernel",\
-				"stage4/root_overlay","stage4/fsscript",\
-				"stage4/gk_mainargs","splash_theme",\
-				"portage_overlay","stage4/rcadd","stage4/rcdel",\
-				"stage4/linuxrc","stage4/unmerge","stage4/rm","stage4/empty"])
+			"stage4/root_overlay","stage4/fsscript",\
+			"stage4/gk_mainargs","splash_theme",\
+			"portage_overlay","stage4/rcadd","stage4/rcdel",\
+			"stage4/linuxrc","stage4/unmerge","stage4/rm","stage4/empty"])
 		StageBase.__init__(self,spec,addlargs)
 
 	def set_cleanables(self):
@@ -26,11 +26,11 @@ class stage4(StageBase):
 
 	def set_action_sequence(self):
 		self.settings["action_sequence"]=["unpack","unpack_snapshot",\
-					"config_profile_link","setup_confdir","portage_overlay",\
-					"bind","chroot_setup","setup_environment","build_packages",\
-					"build_kernel","bootloader","root_overlay","fsscript",\
-					"preclean","rcupdate","unmerge","unbind","remove","empty",\
-					"clean"]
+			"config_profile_link","setup_confdir","portage_overlay",\
+			"bind","chroot_setup","setup_environment","build_packages",\
+			"build_kernel","bootloader","root_overlay","fsscript",\
+			"preclean","rcupdate","unmerge","unbind","remove","empty",\
+			"clean"]
 
 #		if "TARBALL" in self.settings or \
 #			"fetch" not in self.settings['options']:
diff --git a/catalyst/targets/tinderbox.py b/catalyst/targets/tinderbox.py
index 1c91aac..2cebaa8 100644
@@ -26,7 +26,7 @@ class tinderbox(StageBase):
 		# example call: "grp.sh run xmms vim sys-apps/gleep"
 		try:
 			if os.path.exists(self.settings["controller_file"]):
-			    cmd(self.settings["controller_file"]+" run "+\
+				cmd(self.settings["controller_file"]+" run "+\
 				list_bashify(self.settings["tinderbox/packages"]),"run script failed.",env=self.env)
 
 		except CatalystError:
@@ -35,12 +35,12 @@ class tinderbox(StageBase):
 				print_traceback=True)
 
 	def set_cleanables(self):
-	    self.settings["cleanables"]=["/etc/resolv.conf","/var/tmp/*","/root/*",
+		self.settings["cleanables"]=["/etc/resolv.conf","/var/tmp/*","/root/*",
 					self.settings['portdir']]
 
 	def set_action_sequence(self):
 		#Default action sequence for run method
 		self.settings["action_sequence"]=["unpack","unpack_snapshot",\
-		              "config_profile_link","setup_confdir","bind","chroot_setup",\
-		              "setup_environment","run_local","preclean","unbind","clean",\
-		              "clear_autoresume"]
+			"config_profile_link","setup_confdir","bind","chroot_setup",\
+			"setup_environment","run_local","preclean","unbind","clean",\
+			"clear_autoresume"]


-- 
Brian Dolbec <dolsen@gentoo.org>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-catalyst] [patch] Whitespace cleanup
  2013-02-27  9:03 ` [gentoo-catalyst] [patch] Whitespace cleanup Brian Dolbec
@ 2013-02-27 12:25   ` W. Trevor King
  0 siblings, 0 replies; 3+ messages in thread
From: W. Trevor King @ 2013-02-27 12:25 UTC (permalink / raw
  To: gentoo-catalyst

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On Wed, Feb 27, 2013 at 01:03:42AM -0800, Brian Dolbec wrote:
> I've rebased the commit, removing the whitespace changes in COPYING as
> Matt suggested.

On Wed, Feb 27, 2013 at 01:37:33AM -0800, Brian Dolbec wrote:
> Will need to be applied manually to master, but should be done if you
> intend to release another bugfix release in the 2.x series. At least use
> the files changed to fix the files in current master.  I'm not sure if
> this one would easily apply to master.

The tab/space cleanup should be easy to reach agreement on, and can
probably come right after the trailing whitespace patch.

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-02-27 12:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-27  9:37 [gentoo-catalyst] [patch] mixed spaces/tabs and indent cleanup Brian Dolbec
2013-02-27  9:03 ` [gentoo-catalyst] [patch] Whitespace cleanup Brian Dolbec
2013-02-27 12:25   ` W. Trevor King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox