[gentoo-catalyst] [PATCH] make.conf and make.profile moved to /etc/portage so stop cleaning it to avoid multiple fatal errors

[gentoo-catalyst] [PATCH] make.conf and make.profile moved to /etc/portage so stop cleaning it to avoid multiple fatal errors

[Rick Farina]

Signed-off-by: Rick Farina <sidhayn@gmail.com>
---
 modules/stage1_target.py |    3 +--
 modules/stage2_target.py |    1 -
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/modules/stage1_target.py b/modules/stage1_target.py
index 32e6334..560efdb 100644
--- a/modules/stage1_target.py
+++ b/modules/stage1_target.py
@@ -31,8 +31,7 @@ class stage1_target(generic_stage_target):
 		"/usr/lib/python2.2/lib-tk", "/usr/lib/python2.3/test",\
 		"/usr/lib/python2.3/email", "/usr/lib/python2.3/lib-tk",\
 		"/usr/lib/python2.4/test", "/usr/lib/python2.4/email",\
-		"/usr/lib/python2.4/lib-tk", "/usr/share/zoneinfo",\
-		"/etc/portage"])
+		"/usr/lib/python2.4/lib-tk", "/usr/share/zoneinfo"])
 
 	# XXX: How do these override_foo() functions differ from the ones in generic_stage_target and why aren't they in stage3_target?
 
diff --git a/modules/stage2_target.py b/modules/stage2_target.py
index f529721..97ea7fe 100644
--- a/modules/stage2_target.py
+++ b/modules/stage2_target.py
@@ -35,7 +35,6 @@ class stage2_target(generic_stage_target):
 
 	def set_cleanables(self):
 		generic_stage_target.set_cleanables(self)
-		self.settings["cleanables"].extend(["/etc/portage"])
 	
 	def override_chost(self):
 		if self.settings.has_key("chost"):
-- 
1.7.8.6

[gentoo-catalyst] Re: [PATCH] make.conf and make.profile moved to /etc/portage so stop cleaning it to avoid multiple fatal errors

[Richard Farina]

Sorry that was a little iffy on the git send email, it's been a while.

An example of some of the errors solved by this patch is :
http://slexy.org/view/s20oDYzxrC

I was completely unable to build stage2 before this change (and stage1
completed but was REALLY ugly at the end).

Has anyone else run into this yet? I mean the issue can't get much more
obvious, we clean out /etc/portage near the end of each stage but
/etc/portage/make.conf and /etc/portage/make.profile are rather required....

Thanks!

-Zero

On 07/27/2012 04:57 AM, Rick Farina wrote:
> Signed-off-by: Rick Farina <sidhayn@gmail.com>
> ---
>  modules/stage1_target.py |    3 +--
>  modules/stage2_target.py |    1 -
>  2 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/modules/stage1_target.py b/modules/stage1_target.py
> index 32e6334..560efdb 100644
> --- a/modules/stage1_target.py
> +++ b/modules/stage1_target.py
> @@ -31,8 +31,7 @@ class stage1_target(generic_stage_target):
>  		"/usr/lib/python2.2/lib-tk", "/usr/lib/python2.3/test",\
>  		"/usr/lib/python2.3/email", "/usr/lib/python2.3/lib-tk",\
>  		"/usr/lib/python2.4/test", "/usr/lib/python2.4/email",\
> -		"/usr/lib/python2.4/lib-tk", "/usr/share/zoneinfo",\
> -		"/etc/portage"])
> +		"/usr/lib/python2.4/lib-tk", "/usr/share/zoneinfo"])
>  
>  	# XXX: How do these override_foo() functions differ from the ones in generic_stage_target and why aren't they in stage3_target?
>  
> diff --git a/modules/stage2_target.py b/modules/stage2_target.py
> index f529721..97ea7fe 100644
> --- a/modules/stage2_target.py
> +++ b/modules/stage2_target.py
> @@ -35,7 +35,6 @@ class stage2_target(generic_stage_target):
>  
>  	def set_cleanables(self):
>  		generic_stage_target.set_cleanables(self)
> -		self.settings["cleanables"].extend(["/etc/portage"])
>  	
>  	def override_chost(self):
>  		if self.settings.has_key("chost"):

Re: [gentoo-catalyst] Re: [PATCH] make.conf and make.profile moved to /etc/portage so stop cleaning it to avoid multiple fatal errors

[Jorge Manuel B. S. Vicetto]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05-08-2012 22:56, Richard Farina wrote:
> Sorry that was a little iffy on the git send email, it's been a
> while.
> 
> An example of some of the errors solved by this patch is : 
> http://slexy.org/view/s20oDYzxrC


The answer to my question on IRC is that you are using autoresume:

...
The autoresume path is
/mnt/storage/catalyst/tmp/default/.autoresume-stage2-amd64-2012.0/
...

So as I thought we need to review the logic in chroot_setup and
config_profile_link in modules/generic_stage_target.py

> I was completely unable to build stage2 before this change (and
> stage1 completed but was REALLY ugly at the end).
> 
> Has anyone else run into this yet? I mean the issue can't get much
> more obvious, we clean out /etc/portage near the end of each stage
> but /etc/portage/make.conf and /etc/portage/make.profile are rather
> required....

Yes, but we are supposed to create them at the start of every stage -
except we're currently not doing it if autoresume is enabled.

> Thanks!
> 
> -Zero

- -- 
Regards,

Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org
Gentoo- forums / Userrel / Devrel / KDE / Elections / RelEng
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJQH555AAoJEC8ZTXQF1qEPZYQP/2Xct2k7ErAbG69tfCr5MHb/
3Fn9BIAO/WWxxIDxNRFj96kSs36m4yqDPLoYaUtbNTlAodlV5Ca9qnToZ3DhxRHw
Pi8kdJnT04lS7hONsJr87yfU06933q9cWPOSWC0MrUNZNWCVs+tla8QS9G6p75jl
C3l3cN+Q1Zo08dMzREVZEph+m3Wh0LpkqLyM8RRVJIVPZJRue9abvy/VyQB/Cu13
pZNSXvvfXnA5n51oETtKuyjQPthqUTRMmsu5Of9E5q/MIfvAC1y2VWhBrXdw3nv8
hznWKZPNZFIiCRkfxLOtXljTjBPm/N8BvkW/wJKZYda+G8WR34LOthXA1ynK9bfR
qY1V5NpgA52PPLigkt263bEPG6akWVJPB05kRivzhNlT3UsxHHh0SU/RojxBrS7q
H36TgDdP6pcWallnHissOT++7a6a/siKnVqBxd2g/TO+PHO/moufQSKyafBMsQ3r
hzByQm5p9ou8zT9R/aYthS9sFbd3d7afh34g4r8h8FPmtJPnla/d0P29Ity315lh
7xcu0gEOB/WqInqTzFNk6VMrwUbFTrqPlQ3Qa/GJ7UsqauWoQFWwJ1orZFbdty0U
9/ZiwGS/JwvMuGMJX13slcXYt5I9+ynzpozCBvYr4VtLer0l73mTD3fNJWEHgGpH
fPQiuPnzOvFH1qqpusB+
=0ckk
-----END PGP SIGNATURE-----

Re: [gentoo-catalyst] Re: [PATCH] make.conf and make.profile moved to /etc/portage so stop cleaning it to avoid multiple fatal errors

[Richard Farina]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/06/2012 06:37 AM, Jorge Manuel B. S. Vicetto wrote:
> On 05-08-2012 22:56, Richard Farina wrote:
>> Sorry that was a little iffy on the git send email, it's been a
>> while.
> 
>> An example of some of the errors solved by this patch is : 
>> http://slexy.org/view/s20oDYzxrC
> 
> 
> The answer to my question on IRC is that you are using autoresume:
> 
> ...
> The autoresume path is
> /mnt/storage/catalyst/tmp/default/.autoresume-stage2-amd64-2012.0/
> ...
> 
> So as I thought we need to review the logic in chroot_setup and
> config_profile_link in modules/generic_stage_target.py
> 
>> I was completely unable to build stage2 before this change (and
>> stage1 completed but was REALLY ugly at the end).
> 
>> Has anyone else run into this yet? I mean the issue can't get much
>> more obvious, we clean out /etc/portage near the end of each stage
>> but /etc/portage/make.conf and /etc/portage/make.profile are rather
>> required....
> 
> Yes, but we are supposed to create them at the start of every stage -
> except we're currently not doing it if autoresume is enabled.

So my workaround for now is to simply not use autoresume?

Thanks,
Rick

> 
>> Thanks!
> 
>> -Zero
> 
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJQH8kMAAoJEKXdFCfdEflKjKUP/0sFolJbeKjUPDRzX5MkCRYL
sWT7lVHB1cfoZGQGFez/8Mrz/9KMHe1mzz1WpMQGp0a7/l8MLOxuXKx78C9rPZnb
yeDeixT+9gIDGyJKw9bpCtmBJcurZ+0fQPWn48Lzqi7hD7EpirOaC3CS2F/Xe0vh
JXTwkQhBNWoDea9NdJEz4MzAJYEnAb/EIi3v0dxSb2E4lBIbrskNuw5VjHJy4I8x
mfrO0+8LdQCRicSs0oec1uEclZJBILhPspnmR0Zbpn3W5hrSiq78YLgPHFqgt8UR
gtav1SDiuPCcPHt1/Rm6bcfH72QI9zmmqv4kE5mKsSJiZ/ZOgmlVFepMUfaJTe1I
QGtZeGOY8oDDc93LSgaCgJflyP1HFh9WI8TC7QFVLBT6WihizNVnOUP9ilq6G3+t
7P0D6Jsnief/tG1RtOwjE6GdnAX8cW6d/z4OQ5omT0XAsNcFTH7KqO0tHA5qivBp
hbdUo5isKuMMHt2XVp20jVP0wNXHKx1QKSNeZj3GpL3J6eBqk2fLj5P3PrQfUwdx
gcZTGv8h/agmDM2/pQD5XNJ7NnMq8pwTwTC6qCLyvDGvjOvM1eomGMMotRp+47bU
vxexI84/KM4Fde2vpxNcJNQBlgLukEWYBynMnL3WKs6qQhSOyNCyhlfVdIU8/r5a
9squ077jGOP/0+thDCyC
=GVct
-----END PGP SIGNATURE-----