public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-catalyst] Autoresuming hides modifications in config file?
@ 2008-09-18  8:51 Amit Dor-Shifer
  2008-09-18 13:52 ` Andrew Gaffney
  0 siblings, 1 reply; 3+ messages in thread
From: Amit Dor-Shifer @ 2008-09-18  8:51 UTC (permalink / raw
  To: gentoo-catalyst

Hi,
I've modified my livecd stage2 file, adding an 'livecd/rcadd' entry.
Cranking up catalyst I got this message:

--- Running action sequence: rcupdate
Resume point detected, skipping rcupdate operation...

When I looked in 
$storedir/tmp/$rel_type/livecd-stage2-amd64-101/etc/runlevels/, indeed 
the  service wasn't there. 

I restarted catalyst, clearing autoresume points, and got a confirming 
message that the rcscript was added, and also found it in the a/m tmp 
folder.

Is that the way autoresume's intended to work? If so, should I clear 
autoresume points upon every modification in a conf file?

Amit





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-catalyst] Autoresuming hides modifications in config file?
  2008-09-18  8:51 [gentoo-catalyst] Autoresuming hides modifications in config file? Amit Dor-Shifer
@ 2008-09-18 13:52 ` Andrew Gaffney
  2008-09-18 22:38   ` Chris Gianelloni
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Gaffney @ 2008-09-18 13:52 UTC (permalink / raw
  To: gentoo-catalyst

Amit Dor-Shifer wrote:
> Is that the way autoresume's intended to work? If so, should I clear 
> autoresume points upon every modification in a conf file?

Catalyst doesn't store any metadata about the spec file for a particular build, 
so it has no way to know if the spec has changed. That will probably chance in 
the future. For now, just make sure to use -a when you change the spec file.

-- 
Andrew Gaffney                                 http://dev.gentoo.org/~agaffney/
Gentoo Linux Developer            Catalyst/Genkernel + Release Engineering Lead



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-catalyst] Autoresuming hides modifications in config file?
  2008-09-18 13:52 ` Andrew Gaffney
@ 2008-09-18 22:38   ` Chris Gianelloni
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Gianelloni @ 2008-09-18 22:38 UTC (permalink / raw
  To: gentoo-catalyst

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

On Thu, 2008-09-18 at 08:52 -0500, Andrew Gaffney wrote:
> Amit Dor-Shifer wrote:
> > Is that the way autoresume's intended to work? If so, should I clear 
> > autoresume points upon every modification in a conf file?
> 
> Catalyst doesn't store any metadata about the spec file for a particular build, 
> so it has no way to know if the spec has changed. That will probably chance in 
> the future. For now, just make sure to use -a when you change the spec file.

The general rule I use is to use -a if I changed anything that affects
dependencies, or if I'm making a change in a section that has already
been processed.  The autoresume support was really designed to recover
from failed merges, rather than to be a robust solution.  As Andrew
said, I'd eventually like to make the autoresume much smarter, which
means we'd likely need to store the spec file in the autoresume data.
If the keys in the spec for a particular function has changed and that
function has already been run, delete the autoresume for that function.
As we make things more and more modular, this could allow for an
"autoresume" of a nearly-completed build where only the changes need to
be processed.  Using your "rcadd" as an example, let's say you were at
the point of the ISO being made and realized that you forgot to add a
service.  You hit CTRL+C, edit the spec, then re-run catalyst, which
would see that only the rcadd changed, so it would remove the autoresume
data for the rc-update function
(targets/livecd-stage2/livecd-stage2-controller.sh) and process only
that function and the remaining ones, giving you an ISO with the least
amount of processing time.

-- 
Chris Gianelloni
Developer
wolf31o2.org

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-09-18 22:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-18  8:51 [gentoo-catalyst] Autoresuming hides modifications in config file? Amit Dor-Shifer
2008-09-18 13:52 ` Andrew Gaffney
2008-09-18 22:38   ` Chris Gianelloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox