From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1S3ZdM-00071A-0K for garchives@archives.gentoo.org; Fri, 02 Mar 2012 21:03:24 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9A456E091D for ; Fri, 2 Mar 2012 21:03:23 +0000 (UTC) Received: from amber.ccs.neu.edu (amber.ccs.neu.edu [129.10.116.51]) by pigeon.gentoo.org (Postfix) with ESMTP id CED12E09CC for ; Fri, 2 Mar 2012 18:38:49 +0000 (UTC) Received: from alumni-linux.ccs.neu.edu ([129.10.116.115]) by amber.ccs.neu.edu with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1S3XNR-0000H2-3V; Fri, 02 Mar 2012 13:38:49 -0500 Received: from jfaulkne by alumni-linux.ccs.neu.edu with local (Exim 4.69) (envelope-from ) id 1S3XNR-00076b-0z; Fri, 02 Mar 2012 13:38:49 -0500 Date: Fri, 2 Mar 2012 13:38:49 -0500 From: Jim Faulkner To: mattst88@gmail.com Cc: gentoo-alpha@lists.gentoo.org Subject: [gentoo-alpha] Re: [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y Message-ID: <20120302183849.GA26354@alumni-linux.ccs.neu.edu> References: <20120109003504.GA19756@alumni-linux.ccs.neu.edu> <20120218212431.GA25058@alumni-linux.ccs.neu.edu> <4F40264E.6050602@orcon.net.nz> <20120218223957.GB28758@alumni-linux.ccs.neu.edu> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-alpha@lists.gentoo.org Reply-to: gentoo-alpha@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20120218223957.GB28758@alumni-linux.ccs.neu.edu> X-Archives-Salt: ba19f936-b1b7-4e1d-b753-c34913d05b3c X-Archives-Hash: 62d16395b48d4ad06162dcc6da64efd1 Hi Matt, I see that you're one of the maintainers of the alpha architecture in the Linux kernel. Compiling with CONFIG_ALPHA_TSUNAMI=y has been broken for a while, and the fix seems simple. Is there any chance you can sign off on the patch I proposed on Feb 18? Or is there a better solution for this build problem? On Sat, Feb 18, 2012 at 05:39:57PM -0500, Jim Faulkner wrote: > On Sun, Feb 19, 2012 at 11:29:34AM +1300, Michael Cree wrote: > > > > > > +#include > > > > Wouldn't be better? I seem to recall that this was a > > problem with EXPORT_SYMBOL not being defined and I see my own personal > > fix (which I had completely forgotten to send upstream) was to include > > > > core_marvel.c and core_titan.c both include in the > mainline kernel, which is why I thought it was the appropriate fix for > core_tsunami.c. >