From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <eudev+bounces-48-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by finch.gentoo.org (Postfix) with ESMTPS id DA1D3138806
for <garchives@archives.gentoo.org>; Mon, 4 Dec 2017 12:59:46 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id 42545E0F2E;
Mon, 4 Dec 2017 12:59:46 +0000 (UTC)
Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by pigeon.gentoo.org (Postfix) with ESMTPS id DE621E0F2E
for <eudev@lists.gentoo.org>; Mon, 4 Dec 2017 12:59:45 +0000 (UTC)
Received: by mail-lf0-x244.google.com with SMTP id t197so19033390lfe.7
for <eudev@lists.gentoo.org>; Mon, 04 Dec 2017 04:59:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20161025;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to:user-agent;
bh=rrNKK+mymzCn6ijjgT0jRSj1htRu00BoLdSVey1UQjQ=;
b=o2QOkzcPosRFmlM36ntkuwWiCkvyn4Tf5tcg+QL3jwRm8+VOaFDxeiyct0z7KEGBNm
J+oN8Bk9vi5E77xr8ACPuwbNkrYFyYppS8pw3aKF8siufUdI7y5Pu7/4bk+zx9zuJhzj
EVsH6vJBJlWki0msc8xOWOavPj9YEQFbsflBrWKubyjPQAJ/2mB9NFXnpG3QEV/A8n6C
tFUz6eFvMuiCrd8Vq8z5hTZVnTPix9cb+WcNJvjqFU1oxqDUQJ9LoX2Ud1GX11eDmo/G
7zCF14lXzLlljeQom+j5Y31PhTPPnAzThvKgf9ja5k84i9c0PFxmMN9ULRncmIxRJJyH
Kjdw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to:user-agent;
bh=rrNKK+mymzCn6ijjgT0jRSj1htRu00BoLdSVey1UQjQ=;
b=qcsm4FHjHT3P8aWEBtbvREWVyrQsgnflJSofszdp5xZoYfaiytJSZ2omwnyhG+J3r9
6DEOENZdoD2ad05LStGNlsmGVN+Rimqctzd7Q0xYnyiQXdwQbGLtJWs2Y64E3o8Mg+Pz
NGUdE2JQyAW2kkoQyyk39SjMw5bX57VMIdB+Gdl+1lvnwQbValTk0Kjxu7Ed/2SLLBWu
gNEBjixBIUQqbqrnuWIXMXN7U8PF6p2zIDtKDSrrm0FP8C1M4Y2FHysiSrvwdRjbsWtr
UJg01d+YCsdtmAQKVNKFzhroF/EKPWGCiv3R9J+zNpQrD3TL0EW9IJ0x9Z4bvdWlIYSs
EAIA==
X-Gm-Message-State: AJaThX6HwiMEjvIv7s9tYPy7CS2o9pJ92SNYC1pF6mD08ZOC2JUsmXaR
rkqAz4Mp9A1xIIAu1UfHmJY9NPQS
X-Google-Smtp-Source: AGs4zMZ8Izv/Rst9ZVsaUORubRh00S4XMQz2ct7U+g5ngUpAjOy77gAwzgtcLLFd+PEpom3CVMJo7A==
X-Received: by 10.46.17.18 with SMTP id f18mr8558824lje.167.1512392384186;
Mon, 04 Dec 2017 04:59:44 -0800 (PST)
Received: from gmail.com (c-5eea33a1-74736162.cust.telenor.se. [94.234.51.161])
by smtp.gmail.com with ESMTPSA id q27sm2377125lfd.55.2017.12.04.04.59.42
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Mon, 04 Dec 2017 04:59:42 -0800 (PST)
Date: Mon, 4 Dec 2017 13:59:35 +0100
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: "Anthony G. Basile" <basile@freeharbor.net>
Cc: eudev@lists.gentoo.org
Subject: Re: [eudev] [PATCH] udev-event.c: do not assign s to address to
pointer
Message-ID: <20171204125935.GA19650@gmail.com>
References: <20171202172103.2355-1-marcus.folkesson@gmail.com>
<8983f836-f9f0-7c4a-3b17-dd9b6857eec0@freeharbor.net>
Precedence: bulk
List-Post: <mailto:eudev@lists.gentoo.org>
List-Help: <mailto:eudev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:eudev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:eudev+subscribe@lists.gentoo.org>
List-Id: eudev mailing list <eudev.gentoo.org>
X-BeenThere: eudev@gentoo.org
X-BeenThere: eudev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99"
Content-Disposition: inline
In-Reply-To: <8983f836-f9f0-7c4a-3b17-dd9b6857eec0@freeharbor.net>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Archives-Salt: 2761b64f-201f-4d36-bfac-bac6a9940491
X-Archives-Hash: 7cb2e4fe803896937d12529b1a83245b
--5vNYLRcllDrimb99
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
On Mon, Dec 04, 2017 at 07:47:46AM -0500, Anthony G. Basile wrote:
> On 12/2/17 12:21 PM, Marcus Folkesson wrote:
> > Solve a bug that could result in really nasty behavior.
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > ---
> > src/udev/udev-event.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c
> > index 19079bf02..4120c04f2 100644
> > --- a/src/udev/udev-event.c
> > +++ b/src/udev/udev-event.c
> > @@ -201,7 +201,7 @@ subst:
> > _s =3D s;
> > _l =3D l;
> > /* temporarily use sbuf */
> > - s =3D &sbuf;
> > + s =3D sbuf;
> > l =3D UTIL_PATH_SIZE;
> > }
> > =20
>=20
>=20
> Do you know if this was caught upstream?
>=20
It is not, 's' is later used in strpcpy() where memcpy() operates
directly on it.
Best regards
Marcus Folkesson
--5vNYLRcllDrimb99
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlolRrcACgkQiIBOb1ld
UjLCfRAAxJNqUtxCa+Go79K/K3h86WxNq5iN3mOD3M1ukl9bPK2Uagdd+JYOaahm
LjqqUi9mpbcWQ83Nham1NDMV4P7ANKMPUwhF2vUlWBPmfRzfFdqf8KRjIGh6M6Mo
nmUbATtybDTwp0xrGlYdMuKlJJvf7AriWhd4WbFB3ItnM0y4knqH7UD1x/8ZdlNY
HCB0aQqiFm7Zf3EzvcMaqXT9uOTFHp7BqKHycbAMJ1N06enJLew5RRtm7Vym7HDp
ICZAXn0IpgCbwgZU49kBi5FgC9TAgBLIGQuH9j5Ot8EkexZb5/ljjohSGRdflFCd
2w/g5MLy7/b7FFL3CRjlO/0eUDUpB37OMtWsCIR+NDXfo+5Ri1yjhaELNbfeS1rO
0IATOuTrYSQEI3uZrRwHBdOzKbFBTfNA2vl7e0Q3vyhoqVBhVqR8JKc6vEiLJDPQ
rp6nUlcjvjMxV4JY79G0sBTIKVovs6XTD4uLYwPTV48UTD+qvkji7ZHZZfWzFV3j
uliJMbqLEmO5rezYoXyaeprShjVwMGXF2yCOEMNxGrqPT+kAaR2XCKx9GyRFO/VW
9GU8pnJznHNbazg0g44XYMdCVqTjd0tmKze7ATuqQ+6McYJ4LtE7Q1RQ6Rk6xd+t
jFSU9wVN3N+40GEzprR+K1jMRTgKfwnzfJ2qawEyHM/c+DjFrj0=
=r9fM
-----END PGP SIGNATURE-----
--5vNYLRcllDrimb99--