public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 4/7] cargo.eclass: set progress.when = "never" in config
Date: Sat, 11 Feb 2023 07:22:10 +0100	[thread overview]
Message-ID: <e1a30cba62e8b6dacf5453c310b8a32f0c48843e.camel@gentoo.org> (raw)
In-Reply-To: <cefb0572882358ce3cb780b5ffafd939495f7921.camel@gentoo.org>

On Fri, 2023-02-10 at 13:13 -0800, Georgy Yakovlev wrote:
> On Fri, 2023-02-10 at 07:03 +0100, Michał Górny wrote:
> > On Thu, 2023-02-09 at 12:48 -0800, Georgy Yakovlev wrote:
> > > to avoid possible log file pollution
> > > 
> > > Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
> > > ---
> > >  eclass/cargo.eclass | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
> > > index 9c624d607cdd..0ab7ee0dc9b2 100644
> > > --- a/eclass/cargo.eclass
> > > +++ b/eclass/cargo.eclass
> > > @@ -273,6 +273,7 @@ cargo_gen_config() {
> > >         [term]
> > >         verbose = true
> > >         $([[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo
> > > "color = 'never'")
> > > +       progress.when = "never"
> > >         $(_cargo_gen_git_config)
> > >         _EOF_
> > >  
> > 
> > What's that and why don't we want it?  I thought we generally
> > preferred
> > more verbosity.
> > 
> This knob controls progress bar that can pollute logs in rare cases,
> not build verbosity. verbose is set just above.
> 

Ah, ok.  I thought it was maybe "output something every N minutes when
nothing else visible is happening".

-- 
Best regards,
Michał Górny



  reply	other threads:[~2023-02-11  6:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 20:48 [gentoo-dev] cargo.eclass improvements Georgy Yakovlev
2023-02-09 20:48 ` [gentoo-dev] [PATCH 1/7] cargo.eclass: bump minimum rust to 1.57.0 Georgy Yakovlev
2023-02-09 20:48 ` [gentoo-dev] [PATCH 2/7] cargo.eclass: pass --no-track to cargo install Georgy Yakovlev
2023-02-09 20:48 ` [gentoo-dev] [PATCH 3/7] cargo.eclass: document undocumented variables, mark as readonly Georgy Yakovlev
2023-02-09 20:48 ` [gentoo-dev] [PATCH 4/7] cargo.eclass: set progress.when = "never" in config Georgy Yakovlev
2023-02-10  6:03   ` Michał Górny
2023-02-10 21:13     ` Georgy Yakovlev
2023-02-11  6:22       ` Michał Górny [this message]
2023-02-09 20:48 ` [gentoo-dev] [PATCH 5/7] cargo.eclass: use custom profile for all builds Georgy Yakovlev
2023-02-09 21:35   ` Ionen Wolkens
2023-02-10 21:15     ` Georgy Yakovlev
2023-02-09 20:48 ` [gentoo-dev] [PATCH 6/7] cargo.eclass: set codegen-units = 1 Georgy Yakovlev
2023-02-09 20:48 ` [gentoo-dev] [PATCH 7/7] cargo.eclass: filter out lto flags for C/CXX compilers Georgy Yakovlev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1a30cba62e8b6dacf5453c310b8a32f0c48843e.camel@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox