From: "Maciej Barć" <xgqt@gentoo.org>
To: gentoo-dev@lists.gentoo.org, Matt Jolly <kangie@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 2/2] eclass/nuget: add eclassdoc that describes how to generate the NUGETS list
Date: Thu, 21 Nov 2024 10:24:11 +0100 [thread overview]
Message-ID: <d2d7936b-db27-45e1-ac3f-67b6616d124e@gentoo.org> (raw)
In-Reply-To: <0d49bd80-a087-48aa-abd8-7e99698c63af@gentoo.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1429 bytes --]
> Is there any existing policy that favours one of these over the
> other?
I don't think so, dev/user is free to decide on their own.
But IMO it is better to not use any space/tabs for NUGETS to reduce
char. space taken by the list. We already force tabs in ebuilds to
shrink number of characters.
Also, IMHO indentation for those huge chunks that are **defined
globally** like CRATES and EGO_SUM makes them less readable.
.NET project pkgs use the """no-char""" style. In fact were using that
since the conception and nobody complained.
W dniu 21.11.2024 o 01:09, Matt Jolly pisze:
> Hi,
>
> On 21/11/24 07:50, xgqt@gentoo.org wrote:
>> +# When formatting the "NUGETS" list it is better to not indent it,
>> +# but it can be indented with single tab.
>
> This seems at-odds with the general style of ebuilds in ::gentoo.
> Looking at CRATES as an example of a similar variable, this is
> almost always indented, as is the content of any other multiline
> string (e.g. SRC_URI). The now-deprecated EGO_SUM var was also
> by-convention indented (though it was an array...).
>
> Is there any existing policy that favours one of these over the
> other?
>
> LGTM otherwise; better documentation is always good!
>
> Cheers,
>
> Matt
>
>
>
--
Have a great day!
~ Maciej Barć
https://wiki.gentoo.org/wiki/User:Xgqt
9B0A 4C5D 02A3 B43C 9D6F D6B1 14D7 4A1F 43A6 AC3C
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 16315 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2024-11-21 9:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 21:50 [gentoo-dev] [PATCH 1/2] eclass/dotnet-pkg-base: disable MSBUILDTERMINALLOGGER for new .NET 9.0 pkgs xgqt
2024-11-20 21:50 ` [gentoo-dev] [PATCH 2/2] eclass/nuget: add eclassdoc that describes how to generate the NUGETS list xgqt
2024-11-20 22:46 ` James Le Cuirot
2024-11-21 0:09 ` Matt Jolly
2024-11-21 9:24 ` Maciej Barć [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d7936b-db27-45e1-ac3f-67b6616d124e@gentoo.org \
--to=xgqt@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kangie@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox