From: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
To: gentoo-guru@lists.gentoo.org
Subject: Re: [gentoo-guru] Discussion: lower entry barriers to the GURU
Date: Thu, 13 Oct 2022 17:01:49 +0200 [thread overview]
Message-ID: <c4d1b21f-6437-2e31-a214-78ad1c95494f@gentoo.org> (raw)
In-Reply-To: <87mt9zhjjj.fsf@leimstift.de>
On 13/10/2022 16:33, Pascal Jaeger wrote:
> Andrew Ammerlaan <andrewammerlaan@gentoo.org> writes:
>>
>> IMO reviewing and merging PRs is a bit more work for the Trusted Contributors
>> then simply reviewing commits on the dev branch. Besides, the whole point of
>> ::guru is that the contributing process is *not* like it is in ::gentoo (where
>> it might take rather long to get your PR reviewed).
>>
>> That all being said, we do not have a rule against creating/reviewing/merging
>> Pull Requests, so utilizing the process you describe above is technically
>> already allowed. Provided that someone who does have commit access actually
>> merges the opened Pull Requests.
>>
>> Best regards,
>> Andrew
>
> I did not know that. The number of open PRs on the Guru Mirror is practically zero, and there aren’t any instructions for that.
> Are there certain standards the commits in a PR must follow like the PRs people push to dev branch?
The rules for direct commits are the same as for commits in a PR [1]
> Like do they need to be signed off and/or signed with gpg?
A signature/sign-off is required from whoever is going to do the
pushing. It is good practice however to also ask a sign-off from the
author of a PR. For ::gentoo we had this same discussion a while back
about whether a sign-off from the author is strictly required or not. If
I remember correctly the conclusion was that it is not strictly required
if the pusher is absolutely certain that the contribution can legally be
added. (please correct me if I am misremembering)
> Say someone makes a PR to get commits from his fork of guru merged into the dev branch. Can a normal (non trusted) user merge the PR into `dev'-branch?
Yes, anyone with commit access can also merge PRs
[1] https://wiki.gentoo.org/wiki/Project:GURU#The_regulations
next prev parent reply other threads:[~2024-11-24 22:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 12:51 [gentoo-guru] Discussion: lower entry barriers to the GURU Pascal Jaeger
2022-10-13 14:18 ` John Helmert III
2022-10-13 14:18 ` Andrew Ammerlaan
2022-10-13 14:33 ` Pascal Jaeger
2022-10-13 14:53 ` tastytea
2022-10-13 15:01 ` Andrew Ammerlaan [this message]
2022-10-13 14:45 ` tastytea
2022-10-13 16:24 ` Pascal Jaeger
2022-10-13 19:26 ` tastytea
2022-10-13 21:09 ` Pascal Jaeger
2022-10-13 15:25 ` Michał Górny
2022-10-13 17:12 ` Pascal Jaeger
2022-10-13 17:29 ` Nicola Smaniotto
2022-10-13 17:39 ` Pascal Jaeger
2022-10-14 8:30 ` Anna “CyberTailor”
2022-10-17 1:49 ` NRK
2022-10-17 7:00 ` Pascal Jaeger
2022-10-17 7:39 ` Andrew Ammerlaan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d1b21f-6437-2e31-a214-78ad1c95494f@gentoo.org \
--to=andrewammerlaan@gentoo.org \
--cc=gentoo-guru@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox