From: Ionen Wolkens <ionen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: kangie@gentoo.org
Subject: Re: [gentoo-dev] [PATCH] skel.ebuild: update SRC_URI
Date: Sat, 28 Jun 2025 21:43:22 -0400 [thread overview]
Message-ID: <aGCaOjkARO7-EFeF@eversor> (raw)
In-Reply-To: <upleox86u@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
On Sat, Jun 28, 2025 at 04:16:41PM +0200, Ulrich Müller wrote:
> >>>>> On Sat, 28 Jun 2025, kangie wrote:
>
> > -# Portage.
> > -SRC_URI="ftp://foo.example.org/${P}.tar.gz"
> > +# Portage. If a file needs to be renamed, use the "->" syntax.
> > +SRC_URI="https://files.example.org/foo/v${PV}.tar.xz -> ${P}.tar.xz"
>
> Explaining "->" in the comment is fine, but not sure if it is a good
> idea in the actual SRC_URI example. New contributors will inevitably
> copy the line to their ebuild, even if it's not needed. (We've been
> there before, that's why "econf" and "emake" are commented out now).
Think I'd also prefer it be kept an example for "normal" tarballs rather
than what is more often automated git archive with v${PV} which we'd
rather not be used if normal tarballs exist.
I sometime do see people do ${P}.tar.xz -> ${P}.tar.xz just because they
copied it from somewhere too (pkgcheck can warn about that tho).
Note wouldn't hurt, but special knowledge (->) can in general be picked
up later when it's needed, skel.ebuild does not have cover every details
and is just a starting guideline.
--
ionen
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-06-29 1:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 10:49 [gentoo-dev] [PATCH] skel.ebuild: update SRC_URI kangie
2025-06-28 14:16 ` Ulrich Müller
2025-06-29 1:43 ` Ionen Wolkens [this message]
2025-06-29 12:34 ` [gentoo-dev] " Duncan
2025-07-05 7:04 ` [gentoo-dev] [PATCH v2] " kangie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGCaOjkARO7-EFeF@eversor \
--to=ionen@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kangie@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox