From: Ionen Wolkens <ionen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Gentoo Kernel project <kernel@gentoo.org>,
James Le Cuirot <chewi@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH v3] linux-mod-r1.eclass: Fix building with different arch than KV_OUT_DIR
Date: Sat, 24 May 2025 20:40:06 -0400 [thread overview]
Message-ID: <aDJm5mHQJIpSpjAE@eversor> (raw)
In-Reply-To: <20250524215840.24777-2-chewi@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Sat, May 24, 2025 at 10:58:41PM +0100, James Le Cuirot wrote:
> The kernel we're building against may have had its tools (e.g. modpost)
> built for the target arch or even some other arch than the we're
> building with now. To work around this, rebuild those tools with make
> modules_prepare when necessary.
>
> Doing this in pkg_setup is not ideal, but some ebuilds have their own
> src_configure and src_compile functions. It will not trigger in the vast
> majority of cases, and it is not done when installing binary packages.
>
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
> eclass/linux-mod-r1.eclass | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
LGTM
Haven't really looked at linux-info changes closely, but did give the
patchset a test run with non-cross incl. KBUILD_OUTPUT=/out-of-source
and does not seem to regress anything for me. So ok for me there too.
--
ionen
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2025-05-25 0:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 17:30 [gentoo-dev] [PATCH 1/6] linux-mod-r1.eclass: Fix building with different arch than KV_OUT_DIR James Le Cuirot
2025-05-23 17:30 ` [gentoo-dev] [PATCH 2/6] linux-info.eclass: Drop unused myARCH variable in getfilevar_noexec James Le Cuirot
2025-05-23 17:30 ` [gentoo-dev] [PATCH 3/6] linux-info.eclass: Set the correct ARCH for make in getfilevar James Le Cuirot
2025-05-23 17:30 ` [gentoo-dev] [PATCH 4/6] linux-info.eclass: Pass an empty KBUILD_OUTPUT to " James Le Cuirot
2025-05-23 17:30 ` [gentoo-dev] [PATCH 5/6] linux-info.eclass: Don't try to read KBUILD_OUTPUT from the Makefile James Le Cuirot
2025-05-23 17:30 ` [gentoo-dev] [PATCH 6/6] linux-info.eclass: Rework get_version and fix output directory detection James Le Cuirot
2025-05-23 17:40 ` [gentoo-dev] [PATCH v2] linux-mod-r1.eclass: Fix building with different arch than KV_OUT_DIR James Le Cuirot
2025-05-24 0:02 ` Ionen Wolkens
2025-05-24 11:41 ` James Le Cuirot
2025-05-24 21:58 ` [gentoo-dev] [PATCH v3] " James Le Cuirot
2025-05-25 0:40 ` Ionen Wolkens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDJm5mHQJIpSpjAE@eversor \
--to=ionen@gentoo.org \
--cc=chewi@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kernel@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox