From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-portage-dev@lists.gentoo.org
Cc: "Ulrich Müller" <ulm@gentoo.org>
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] ebuild.sh: Update QA notice in inherit()
Date: Sun, 29 Aug 2021 23:27:14 +0200 [thread overview]
Message-ID: <a573e3d4e163538ee239030c8a6e5af6a6f47d65.camel@gentoo.org> (raw)
In-Reply-To: <20210829200639.2373-2-ulm@gentoo.org>
On Sun, 2021-08-29 at 22:06 +0200, Ulrich Müller wrote:
> Bug: https://bugs.gentoo.org/399039
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
> bin/ebuild.sh | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/bin/ebuild.sh b/bin/ebuild.sh
> index 1bca2c965..f5f3d9eec 100755
> --- a/bin/ebuild.sh
> +++ b/bin/ebuild.sh
> @@ -248,8 +248,7 @@ inherit() {
> # previous inherit call in the call stack.
> if [[ -n ${ECLASS} && -n ${!__export_funcs_var} ]] ; then
> eqawarn "QA Notice: EXPORT_FUNCTIONS is called before inherit in ${ECLASS}.eclass."
> - eqawarn "For compatibility with <=portage-2.1.6.7, only call EXPORT_FUNCTIONS"
> - eqawarn "after inherit(s)."
> + eqawarn "For compatibility with PMS, only call EXPORT_FUNCTIONS after inherit(s)."
> fi
> fi
>
Could you add a sentence that the current Portage behavior is going to
change in the future?
--
Best regards,
Michał Górny
next prev parent reply other threads:[~2021-08-29 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 20:06 [gentoo-portage-dev] [PATCH 1/2] Revert "Revert "Generate a QA Notice when EXPORT_FUNCTIONS is called before inherit"" Ulrich Müller
2021-08-29 20:06 ` [gentoo-portage-dev] [PATCH 2/2] ebuild.sh: Update QA notice in inherit() Ulrich Müller
2021-08-29 21:27 ` Michał Górny [this message]
2021-08-29 22:47 ` Ulrich Mueller
2021-08-30 5:42 ` Michał Górny
2021-08-30 6:22 ` [gentoo-portage-dev] [PATCH v2 1/2] Revert "Revert "Generate a QA Notice when EXPORT_FUNCTIONS is called before inherit"" Ulrich Müller
2021-09-03 11:34 ` Michał Górny
2021-08-30 6:22 ` [gentoo-portage-dev] [PATCH v2 2/2] ebuild.sh: Update QA notice in inherit() Ulrich Müller
2021-08-29 20:16 ` [gentoo-portage-dev] [PATCH 1/2] Revert "Revert "Generate a QA Notice when EXPORT_FUNCTIONS is called before inherit"" Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a573e3d4e163538ee239030c8a6e5af6a6f47d65.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-portage-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox