From: Ionen Wolkens <ionen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: Emit a warning if the package uses 300+ crates
Date: Mon, 13 Jan 2025 11:10:59 -0500 [thread overview]
Message-ID: <Z4U7E-s1YFCKYmLR@eversor> (raw)
In-Reply-To: <20250113052354.4bfc2973@Akita>
[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]
On Mon, Jan 13, 2025 at 05:23:54AM -0800, orbea wrote:
> On Mon, 13 Jan 2025 10:40:30 +0100
> Florian Schmaus <flow@gentoo.org> wrote:
>
> > On 12/01/2025 13.56, Michał Górny wrote:
> > > Emit a QA warning suggesting the use of crate tarball, when the
> > > package in question uses 300 crates or more. Such a long crate
> > > lists cause ebuilds and Manifests to grow very fast, causing
> > > significant space consumption on end user systems (including users
> > > who are not using the package in question) and git history growth.
> > > On top of that, fetching that many crates takes significant time.
> > >
> > > The number of 300 is pretty arbitrary, chosen approximately to match
> > > Manifests that are over 100 KiB in size. We should probably look
> > > into lowering in the future, as more packages are transitioned.
> > Thanks for your proposal. I know you wrote it because Gentoo is
> > important to you.
> >
> > I am sorry, however, but the arbitrary limit you propose is harmful,
> > and its necessity is questionable.
>
> Its worth pointing out that is already being done in Gentoo, see
> dev-util/maturin for one example.
ftr this is something I was planning to do either way, but kept
procrastinating given that package needs special handling to
handle crates used by tests (it builds separate rust packages
for its tests with their own crates). This just prompted me to
finally have a look before a potential warning hits.
--
ionen
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-01-13 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 12:56 [gentoo-dev] [PATCH] cargo.eclass: Emit a warning if the package uses 300+ crates Michał Górny
2025-01-12 13:15 ` Agostino Sarubbo
2025-01-12 14:30 ` Alexey Sokolov
2025-01-12 21:20 ` Ionen Wolkens
2025-01-13 9:40 ` Florian Schmaus
2025-01-13 13:23 ` orbea
2025-01-13 16:10 ` Ionen Wolkens [this message]
2025-01-13 13:36 ` Michał Górny
2025-01-14 16:56 ` Florian Schmaus
2025-01-14 17:43 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4U7E-s1YFCKYmLR@eversor \
--to=ionen@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox