From: Mike Gilbert <floppym@gentoo.org>
To: Gentoo Dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] xdg.eclass: add EAPI 8 support
Date: Thu, 15 Jul 2021 14:17:44 -0400 [thread overview]
Message-ID: <CAJ0EP41dApP-Np3=DfCcF-hixR8Y7WCgv1DDGsa2EsXeUNDV0g@mail.gmail.com> (raw)
In-Reply-To: <YPA4SoIzNTXXRAdL@eversor>
On Thu, Jul 15, 2021 at 9:29 AM Ionen Wolkens <ionen@gentoo.org> wrote:
>
> On Thu, Jul 15, 2021 at 03:23:04PM +0200, Ulrich Mueller wrote:
> > >>>>> On Thu, 15 Jul 2021, Ionen Wolkens wrote:
> >
> > > Old DEPEND should be kept as-is not to risk breaking packages with odd
> > > checks that need it present at build time. I'd rather no RDEPEND switch
> > > either as it'll just complicate things with revbumps and tools don't
> > > really need to be in RDEPEND given the above.
> >
> > Well, if the challenge was to pick the _worst_ match out of
> > {,B,R,I}DEPEND then DEPEND would be the correct answer. :)
>
> Well, if really must improve it, I think BDEPEND is the better choice.
>
> Some packages use desktop-file-validate for their tests and the like.
If ebuilds are using these programs directly (like for testing), they
should really declare the dependency explicitly instead of relying on
an implicit dependency in xdg.eclass. The eclass deps should be
limited to functionality utilized by its exported phase functions.
However, I realize older ebuilds were not written with that reasoning
in mind, so I understand the "don't mess with older EAPIs" request
from leio.
Regarding BDEPEND/RDEPEND/IDEPEND, here's what we did with fcaps.eclass:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=789ec15b80a0ad2902d59be5bdb7c5fa6fcd0092
Quoting the commit message:
This defines the native install-time libcap dependency as:
- EAPI < 7: RDEPEND
Only regular ROOT=/ builds can be expected to work.
- EAPI = 7: RDEPEND + BDEPEND
Also install the native setcap at built time, so cross-
compiling will work, but not installing binpkgs in ROOTs.
- EAPI > 7: IDEPEND
Install native setcap at install-time; it works everywhere.
next prev parent reply other threads:[~2021-07-15 18:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 11:19 [gentoo-dev] [PATCH] xdg.eclass: add EAPI 8 support Florian Schmaus
2021-07-15 12:03 ` Ulrich Mueller
2021-07-15 13:22 ` Mart Raudsepp
2021-07-15 13:00 ` Ionen Wolkens
2021-07-15 13:23 ` Ulrich Mueller
2021-07-15 13:29 ` Ionen Wolkens
2021-07-15 18:17 ` Mike Gilbert [this message]
2021-07-21 15:08 ` [gentoo-dev] [PATCH v2] " Florian Schmaus
2021-07-21 16:37 ` Ulrich Mueller
2021-08-03 11:40 ` Mart Raudsepp
2021-08-09 18:32 ` [gentoo-dev] [PATCH v3 1/2] " Florian Schmaus
2021-08-09 18:32 ` [gentoo-dev] [PATCH v3 2/2] xdg.eclass: drop support for EAPI 4 Florian Schmaus
2021-08-10 18:21 ` Andreas Sturmlechner
2021-08-10 8:31 ` [gentoo-dev] [PATCH v3 1/2] xdg.eclass: add EAPI 8 support Andreas Sturmlechner
2021-08-11 11:54 ` Florian Schmaus
2021-08-11 12:40 ` Andreas Sturmlechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ0EP41dApP-Np3=DfCcF-hixR8Y7WCgv1DDGsa2EsXeUNDV0g@mail.gmail.com' \
--to=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox