From: Mart Raudsepp <leio@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Florian Schmaus <flow@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH v2] xdg.eclass: add EAPI 8 support
Date: Tue, 03 Aug 2021 14:40:16 +0300 [thread overview]
Message-ID: <9ddc7a8337b5bbb4edb3b8ffa76e9e0b17c9eabb.camel@gentoo.org> (raw)
In-Reply-To: <20210721150849.175482-1-flow@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]
Ühel kenal päeval, K, 21.07.2021 kell 17:08, kirjutas Florian Schmaus:
> Note that this removes the export of src_prepare in EPAI 8 as
> requested by ionen:
>
> 1. remove src_prepare export in EAPI-8
>
> While "some" packages need xdg_environment_reset, most don't
> because
> the eclass is often only inherited to handle icons/.desktop and
> this
> just needlessly overwrite the src_prepare of other eclasses
> requiring
> more careful inherit ordering (e.g. inherit xdg cmake).
>
> I'd prefer it was clear when a package need this by calling
> xdg_environment_reset directly. Unless there is a non-trivial
> amount
> of packages that need it (e.g. for tests) that I'm not aware of.
asturm asked me to reply here if I think the changes are in the spirit
of xdg.eclass, so..
I'm not sure about the spirit, but I personally am fine with the
changes, after the technical nitpicks are figured out in the thread
here.
I do not like at all that we'll need to remember about calling
xdg_environment_reset sometimes, but the status quo of clashing with
other eclasses src_prepare export is probably worse.
And you needing this reset call or not is not at all immediately
obvious - it causing trouble may only happen during test suite run, for
example, when XDG_RUNTIME_DIR is written to, or something else ends up
causing writes to it. Basically ENV_UNSET was a great start, but does
not completely address our XDG env reset needs and it'd be great if
someone championed a full solution for EAPI-9 or something.
I'm starting to think the easiest is to just make the
xdg_environment_reset call unconditionally in meson.eclass
src_configure like cmake.eclass does, and forget all about this for
almost all possible cases.
That rant aside, I'm happy in spirit with the changes as proposed here.
Mart
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
next prev parent reply other threads:[~2021-08-03 11:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 11:19 [gentoo-dev] [PATCH] xdg.eclass: add EAPI 8 support Florian Schmaus
2021-07-15 12:03 ` Ulrich Mueller
2021-07-15 13:22 ` Mart Raudsepp
2021-07-15 13:00 ` Ionen Wolkens
2021-07-15 13:23 ` Ulrich Mueller
2021-07-15 13:29 ` Ionen Wolkens
2021-07-15 18:17 ` Mike Gilbert
2021-07-21 15:08 ` [gentoo-dev] [PATCH v2] " Florian Schmaus
2021-07-21 16:37 ` Ulrich Mueller
2021-08-03 11:40 ` Mart Raudsepp [this message]
2021-08-09 18:32 ` [gentoo-dev] [PATCH v3 1/2] " Florian Schmaus
2021-08-09 18:32 ` [gentoo-dev] [PATCH v3 2/2] xdg.eclass: drop support for EAPI 4 Florian Schmaus
2021-08-10 18:21 ` Andreas Sturmlechner
2021-08-10 8:31 ` [gentoo-dev] [PATCH v3 1/2] xdg.eclass: add EAPI 8 support Andreas Sturmlechner
2021-08-11 11:54 ` Florian Schmaus
2021-08-11 12:40 ` Andreas Sturmlechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ddc7a8337b5bbb4edb3b8ffa76e9e0b17c9eabb.camel@gentoo.org \
--to=leio@gentoo.org \
--cc=flow@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox