From: Eli Schwartz <eschwartz@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v3 1/3] sec-keys.eclass: new eclass
Date: Mon, 28 Jul 2025 12:27:08 -0400 [thread overview]
Message-ID: <830041d8-20fc-4ebf-9062-1ab607d28dd0@gentoo.org> (raw)
In-Reply-To: <8734agjpru.fsf@gentoo.org>
[-- Attachment #1.1: Type: text/plain, Size: 1068 bytes --]
On 7/28/25 11:31 AM, Sam James wrote:
>> + for key in "${SEC_KEYS_VALIDPGPKEYS[@]}"; do
>> + if [[ ${key##*:} = *github* ]]; then
>> + name=${key#*:}; name=${name%%:*}
>> + wget -qO- https://github.com/${name}.gpg | gpg --import || die
>
> I (still) think this should have a pipestatus, if nothing else to be a
> good example and avoid possible lint issues down the road.
Okay, I remember this private conversation now -- at the time, I refused
on the grounds it would entail using the name "assert". :P
Will add.
>> + fi
>> + done
>> +
>> + for fingerprint in "${SEC_KEYS_VALIDPGPKEYS[@]%%:*}"; do
>> + pgpdump "${fingerprint}.asc" > "${fingerprint}.pgpdump" || die
>> + "${gpg_command[@]}" --export "${fingerprint}" | pgpdump
>>> "${fingerprint}.pgpdump.new" || die
>
> ... and here.
(And for context, this is safe because pgpdump has a reliable exit code
even if given a half-formed key missing the closing boundary. Still, I
agree that for consistency and as a good example it's fine to do.)
--
Eli Schwartz
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2025-07-28 16:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 20:30 [gentoo-dev] [PATCH 1/2] sec-keys.eclass: new eclass Eli Schwartz
2024-11-27 20:30 ` [gentoo-dev] [PATCH 2/2] sec-keys/openpgp-keys-gnutls: update to use sec-keys.eclass Eli Schwartz
2024-11-27 21:12 ` [gentoo-dev] [PATCH 1/2] sec-keys.eclass: new eclass Michał Górny
2024-11-27 21:52 ` Sam James
2024-11-28 4:24 ` Eli Schwartz
2024-11-27 21:57 ` Sam James
2024-11-28 4:17 ` Eli Schwartz
2024-11-28 4:32 ` [gentoo-dev] [PATCH v2 0/2] sec-keys.eclass Eli Schwartz
2024-11-28 4:32 ` [gentoo-dev] [PATCH v2 1/2] sec-keys.eclass: new eclass Eli Schwartz
2024-11-28 13:10 ` Michał Górny
2024-11-28 15:36 ` Eli Schwartz
2024-11-28 16:42 ` Michał Górny
2024-11-28 16:56 ` Sam James
2024-11-28 17:06 ` Michał Górny
2024-11-28 17:22 ` Sam James
2024-11-29 18:31 ` Robin H. Johnson
2024-11-29 19:02 ` Eli Schwartz
2024-11-29 7:30 ` Florian Schmaus
2024-11-28 4:32 ` [gentoo-dev] [PATCH v2 2/2] sec-keys/openpgp-keys-gnutls: update to use sec-keys.eclass Eli Schwartz
2024-11-28 10:35 ` [gentoo-dev] [PATCH 1/2] sec-keys.eclass: new eclass Ulrich Müller
2024-11-28 15:36 ` Eli Schwartz
2025-07-25 4:09 ` [gentoo-dev] [PATCH v3 0/3] sec-keys.eclass Eli Schwartz
2025-07-25 4:09 ` [gentoo-dev] [PATCH v3 1/3] sec-keys.eclass: new eclass Eli Schwartz
2025-07-28 15:31 ` Sam James
2025-07-28 16:27 ` Eli Schwartz [this message]
2025-07-25 4:09 ` [gentoo-dev] [PATCH v3 2/3] sec-keys/openpgp-keys-gnutls: update to use sec-keys.eclass Eli Schwartz
2025-07-28 15:31 ` Sam James
2025-07-25 4:09 ` [gentoo-dev] [PATCH v3 3/3] sec-keys/openpgp-keys-gnutls: add 20250704 Eli Schwartz
2025-07-28 15:32 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=830041d8-20fc-4ebf-9062-1ab607d28dd0@gentoo.org \
--to=eschwartz@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox