From: Joonas Niilola <juippis@gentoo.org>
To: gentoo-proxy-maint@lists.gentoo.org
Subject: Re: [gentoo-proxy-maint] [PATCH 1/2] app-editors/vis: Add -fcommon
Date: Sat, 6 Jun 2020 19:38:37 +0300 [thread overview]
Message-ID: <801095d3-fa20-bda6-0364-eb9bb95c72de@gentoo.org> (raw)
In-Reply-To: <42665f1b-5999-4c21-57ee-945e191e4f9e@gentoo.org>
[-- Attachment #1.1: Type: text/plain, Size: 810 bytes --]
On 5/15/20 4:24 PM, Joonas Niilola wrote:
> On 5/11/20 12:38 AM, Haelwenn (lanodan) Monnier wrote:
>> }
>>
>> src_configure() {
>> + export CFLAGS="$CFLAGS -fcommon" # https://github.com/martanne/vis-test/issues/21
> Let's use the recommended style,
>
> https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common#The_-fcommon_workaround_.28discouraged.29
>
>
You could've just told me it doesn't carry on to test phase. Although
still not happy with it (use {} around variables), merged as
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b015f553ce6b600fd938f381faee5429270d402c
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0615eb3242d0bea42719bea4f34fbcb75a14af5
-9999 seems to have been already fixed by upstream so not touching that
this time.
-- juippis
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 642 bytes --]
prev parent reply other threads:[~2020-06-06 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 21:38 [gentoo-proxy-maint] [PATCH 1/2] app-editors/vis: Add -fcommon Haelwenn (lanodan) Monnier
2020-05-10 21:38 ` [gentoo-proxy-maint] [PATCH 2/2] app-editors/vis: Respect CC and CFLAGS in tests Haelwenn (lanodan) Monnier
2020-05-15 13:24 ` [gentoo-proxy-maint] [PATCH 1/2] app-editors/vis: Add -fcommon Joonas Niilola
2020-06-06 16:38 ` Joonas Niilola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=801095d3-fa20-bda6-0364-eb9bb95c72de@gentoo.org \
--to=juippis@gentoo.org \
--cc=gentoo-proxy-maint@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox