From: David Seifert <soap@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/2] eutils.eclass: Use optfeature() from optfeature.eclass
Date: Sun, 06 Sep 2020 23:11:33 +0200 [thread overview]
Message-ID: <7507991af266f85d082b1dd6fd5e3c94448177b7.camel@gentoo.org> (raw)
In-Reply-To: <utuwahei4@gentoo.org>
On Sun, 2020-09-06 at 21:49 +0200, Ulrich Mueller wrote:
> > > > > > On Sun, 06 Sep 2020, David Seifert wrote:
> > @@ -20,7 +20,7 @@ _EUTILS_ECLASS=1
> > # implicitly inherited (now split) eclasses
> > case ${EAPI:-0} in
> > 0|1|2|3|4|5|6)
> > - inherit desktop epatch estack ltprune multilib preserve-libs \
> > + inherit desktop epatch estack ltprune multilib optfeature
> > preserve-libs \
> > toolchain-funcs vcs-clean
> > ;;
> > esac
>
> I count 163 ebuilds calling optfeature in EAPI 7, but only 24 in older
> EAPIs, which makes me wonder if the conditional inherit makes any
> sense.
>
> Maybe just commit the new eclass, update ebuilds, then remove the
> function from eutils?
>
> Ulrich
I'll get a lot of heat for breaking EAPI 2 ebuilds in some random
abandoned overlay because we guarantee eclass API backwards
compatibility for 20 years!
next prev parent reply other threads:[~2020-09-06 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 15:47 [gentoo-dev] [PATCH 1/2] optfeature.eclass: New eclass with definition from eutils David Seifert
2020-09-06 15:47 ` [gentoo-dev] [PATCH 2/2] eutils.eclass: Use optfeature() from optfeature.eclass David Seifert
2020-09-06 19:49 ` Ulrich Mueller
2020-09-06 21:11 ` David Seifert [this message]
2020-09-07 7:37 ` Ulrich Mueller
2020-09-06 15:51 ` [gentoo-dev] [PATCH 1/2] optfeature.eclass: New eclass with definition from eutils Joonas Niilola
2020-09-06 18:12 ` David Seifert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7507991af266f85d082b1dd6fd5e3c94448177b7.camel@gentoo.org \
--to=soap@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox