From: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
To: gentoo-guru@lists.gentoo.org
Subject: Re: [gentoo-guru] Discussion: lower entry barriers to the GURU
Date: Mon, 17 Oct 2022 09:39:57 +0200 [thread overview]
Message-ID: <6ffdfb62-925f-b046-610e-99e1e22e2e4e@gentoo.org> (raw)
In-Reply-To: <8735bmdiq6.fsf@leimstift.de>
On 17/10/2022 09:00, Pascal Jaeger wrote:
> NRK <nrk@disroot.org> writes:
>
>> On Fri, Oct 14, 2022 at 01:30:36PM +0500, Anna “CyberTailor” wrote:
>>> one-time contributions (especially of poor quality) don’t really
>>> benefit the project and its users.
>>
>> I wouldn’t assume one-time neither poor quality. There are people who
>> may want to maintain a single package or two (which might get updated
>> rarely); at which point (assuming you already have a github account)
>> it’s easier to just open a PR.
>>
>
> This is what I think, too. As an app developer you want to distribute your work to people of course, but you don’t want to put that much energy into every distro.
> Those people would only maintain one program, their own. I think we would benefit from this.
>
>> And if someone _does_ open a low-quality PR, I bet there will be plenty
>> of people who would be willing to guide him to improve it. And of
>> course, if the author is unwilling to improve then we can just reject
>> the PR.
>>
>> So I think accepting PRs via github would be a net positive. At the very
>> least, I see no reason not to try it out and see how it goes :)
>>
>> —
>>
>> Re: lowering entry barrier: in my experience, I’ve seen more people shy
>> away from GURU (and create their own overlay) due to the “real-name”
>> requirement compared to having to set up gpg+ssh.
>>
>> - NRK
>
> I will write some instructions for it in the Wiki. Since they are basically the same instructions like the ones for proxy maintainers this should not be too much work.
> When ready I will also advertise it a bit.
>
> But we need to clarify some things first:
> • Do the people that contribute via PR need to sign their commit or is it enough if the GURU contributor who moves them over to the GURU dev branch (via git am or pram) signs them?
No, AFAIK this is also not a requirement for proxy maintained
contributions to ::gentoo. That being said I would encourage everyone to
sign their commits anyway because it is good practice and once you have
the key setup it is very easy.
> • If we require signing by the people who do the PR, is ’Signed off by’ enough, or do they need to sign them with GPG?
Signing off, and cryptographic signing are two completely separate
things (the similar naming is confusing). The first is just some text in
the commit message to indicate that your contribution is legally sound.
The second is a signature to verify that the contribution really
originates from you. See my previous email about whether 'signed-off'by'
is strictly required. Short version is "yes, unless the merger is
absolutely certain that the contribution is legally sound (i.e. does not
contain copyrighted material)".
> • Do people who contribute via PR need to sign with their real name?
A sign-off only makes sense if it is done using a name that can hold
legal status in the country where you're making the contribution from.
Signing-off with some random username is meaningless since it defeats
the whole point of the sign-off. This is also something that has already
been discussed at length on the gentoo-dev mailinglist. If I recall
correctly the conclusion was that you have to use a name that you would
also use IRL with e.g. colleagues or friends. [1,2]
[1]
https://archives.gentoo.org/gentoo-dev/message/7d1ad38a1d77ea5726520d2ec90cffe4
[2]
https://archives.gentoo.org/gentoo-dev/message/fe298704bd13f56909277949e66c8f62
Best regards,
Andrew
prev parent reply other threads:[~2024-11-24 22:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 12:51 [gentoo-guru] Discussion: lower entry barriers to the GURU Pascal Jaeger
2022-10-13 14:18 ` John Helmert III
2022-10-13 14:18 ` Andrew Ammerlaan
2022-10-13 14:33 ` Pascal Jaeger
2022-10-13 14:53 ` tastytea
2022-10-13 15:01 ` Andrew Ammerlaan
2022-10-13 14:45 ` tastytea
2022-10-13 16:24 ` Pascal Jaeger
2022-10-13 19:26 ` tastytea
2022-10-13 21:09 ` Pascal Jaeger
2022-10-13 15:25 ` Michał Górny
2022-10-13 17:12 ` Pascal Jaeger
2022-10-13 17:29 ` Nicola Smaniotto
2022-10-13 17:39 ` Pascal Jaeger
2022-10-14 8:30 ` Anna “CyberTailor”
2022-10-17 1:49 ` NRK
2022-10-17 7:00 ` Pascal Jaeger
2022-10-17 7:39 ` Andrew Ammerlaan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ffdfb62-925f-b046-610e-99e1e22e2e4e@gentoo.org \
--to=andrewammerlaan@gentoo.org \
--cc=gentoo-guru@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox