From: Andreas Sturmlechner <asturm@gentoo.org>
To: gentoo-dev@lists.gentoo.org, Sergei Trofimovich <slyfox@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH v2 2/5] flag-o-matic.eclass: get rid of eutils in <EAPI-8, fix eclassdoc, make some funcs internal
Date: Thu, 01 Apr 2021 11:58:07 +0200 [thread overview]
Message-ID: <2127539.vFx2qVVIhK@tuxbook> (raw)
In-Reply-To: <2537255.vuYhMxLoTh@tuxbook>
[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]
From 6d1c665d06186dde5361905d5fb2057e044b040e Mon Sep 17 00:00:00 2001
From: Andreas Sturmlechner <asturm@gentoo.org>
Date: Wed, 31 Mar 2021 00:22:12 +0200
Subject: [PATCH 2/5] flag-o-matic.eclass: Make setup-allowed-flags() internal
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
---
eclass/flag-o-matic.eclass | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
index ab79f70392d..d511a140592 100644
--- a/eclass/flag-o-matic.eclass
+++ b/eclass/flag-o-matic.eclass
@@ -26,9 +26,23 @@ all-flag-vars() {
echo {ADA,C,CPP,CXX,CCAS,F,FC,LD}FLAGS
}
+# @FUNCTION: setup-allowed-flags
+# @INTERNAL
+# @DESCRIPTION:
# {C,CPP,CXX,CCAS,F,FC,LD}FLAGS that we allow in strip-flags
# Note: shell globs and character lists are allowed
setup-allowed-flags() {
+ [[ ${EAPI} == [5-7] ]] ||
+ die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
+ _setup-allowed-flags
+}
+
+# @FUNCTION: _setup-allowed-flags
+# @INTERNAL
+# @DESCRIPTION:
+# {C,CPP,CXX,CCAS,F,FC,LD}FLAGS that we allow in strip-flags
+# Note: shell globs and character lists are allowed
+_setup-allowed-flags() {
ALLOWED_FLAGS=(
-pipe -O '-O[12sg]' -mcpu -march -mtune
'-fstack-protector*' '-fsanitize*' '-fstack-check*' -fno-stack-check
@@ -412,7 +426,7 @@ strip-flags() {
local x y var
local ALLOWED_FLAGS
- setup-allowed-flags
+ _setup-allowed-flags
set -f # disable pathname expansion
--
2.31.0
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
next prev parent reply other threads:[~2021-04-01 9:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 6:39 [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in <EAPI-8, fix eclassdoc, make some funcs internal Andreas Sturmlechner
2021-03-31 7:33 ` Sergei Trofimovich
2021-03-31 7:45 ` Andreas Sturmlechner
2021-03-31 9:13 ` Sergei Trofimovich
2021-03-31 10:03 ` Wolfgang E. Sanyer
2021-04-01 13:42 ` Andreas Sturmlechner
2021-04-01 9:57 ` [gentoo-dev] [PATCH v2 1/5] " Andreas Sturmlechner
2021-04-01 9:58 ` Andreas Sturmlechner [this message]
2021-04-01 9:59 ` [gentoo-dev] [PATCH v2 3/5] " Andreas Sturmlechner
2021-04-01 10:01 ` [gentoo-dev] [PATCH v2 4/5] " Andreas Sturmlechner
2021-04-01 10:02 ` [gentoo-dev] [PATCH v2 5/5] " Andreas Sturmlechner
2021-04-01 18:40 ` Sergei Trofimovich
2021-04-01 18:39 ` [gentoo-dev] [PATCH v2 4/5] " Sergei Trofimovich
2021-04-01 18:37 ` [gentoo-dev] [PATCH v2 3/5] " Sergei Trofimovich
2021-04-01 21:42 ` Ulrich Mueller
2021-04-02 9:49 ` Andreas Sturmlechner
2021-04-01 18:30 ` [gentoo-dev] [PATCH v2 2/5] " Sergei Trofimovich
2021-04-01 18:26 ` [gentoo-dev] [PATCH v2 1/5] " Sergei Trofimovich
2021-03-31 7:36 ` [gentoo-dev] [PATCH] " Sam James
2021-03-31 9:09 ` Ulrich Mueller
2021-04-01 21:57 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2127539.vFx2qVVIhK@tuxbook \
--to=asturm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox