From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-pms@lists.gentoo.org
Cc: "Ulrich Müller" <ulm@gentoo.org>
Subject: [gentoo-pms] [PATCH] pkg-mgr-commands.tex: Update condition for econf --disable-static (again)
Date: Sat, 19 Nov 2022 21:37:09 +0100 [thread overview]
Message-ID: <20221119203709.24307-1-ulm@gentoo.org> (raw)
The intention is to pass --disable-static, in order to (only) disable
static libtool archive building. The current condition asks for either
of --{disable,enable}-static in configure --help output, which causes
false positives:
https://archives.gentoo.org/gentoo-portage-dev/message/efc3f424d1dffd3415da538ec25532a9
Therefore, narrow the condition to require both --enable-static and
--enable-shared. In addition, backport the check for proper end of
string from the EAPI 9 feature list, but restrict it to this option
for now.
Bug: https://bugs.gentoo.org/814368
Bug: https://bugs.gentoo.org/815169
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
---
pkg-mgr-commands.tex | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
index d4dcffe..a3e8a41 100644
--- a/pkg-mgr-commands.tex
+++ b/pkg-mgr-commands.tex
@@ -341,8 +341,9 @@ commands once the current phase function has returned.
as using it. This option will only be passed if the string \t{-{}-disable-silent-rules}
occurs in the output of \t{configure -{}-help}.
\item \t{-{}-disable-static}, if the EAPI is listed in table~\ref{tab:econf-options-table}
- as using it. This option will only be passed if the string \t{-{}-disable-static} or
- \t{-{}-enable-static} occurs in the output of \t{configure -{}-help}.
+ as using it. This option will only be passed if both strings \t{-{}-enable-static} and
+ \t{-{}-enable-shared} occur in the output of \t{configure -{}-help}, and if neither of them
+ is immediately followed by any of the characters \t{[A-Za-z0-9+_.-]}.
\end{itemize}
\ChangeWhenAddingAnEAPI{8}
--
2.38.1
reply other threads:[~2022-11-19 20:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221119203709.24307-1-ulm@gentoo.org \
--to=ulm@gentoo.org \
--cc=gentoo-pms@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox