From: "Haelwenn (lanodan) Monnier" <contact@hacktivis.me>
To: gentoo-proxy-maint@lists.gentoo.org
Subject: Re: [gentoo-proxy-maint] Posting patches on this mailing list instead of using GitHub
Date: Sun, 7 Jun 2020 18:42:27 +0200 [thread overview]
Message-ID: <20200607164227.GC25629@cloudsdale.the-delta.net.eu.org> (raw)
In-Reply-To: <a7de2063-1264-9703-e693-86f4111f1c7b@gentoo.org>
[2020-06-07 10:01:43+0300] Joonas Niilola:
> On 6/7/20 2:45 AM, Ralph Seichter wrote:
> > Still, I wonder why patches are posted here instead of using GitHub,
> > because there is no public review process going on. To me, email-based
> > patches on the Gentoo Proxy Maintainer mailing list are at best mildly
> > annoying, and at worst an attempt at jumping the queue, i.e. to get
> > one's changes processed faster than those made through GitHub. They
> > also, in my perception, have a smell of "ooh, look at me, I am working"
> > about them.
>
> I also wonder that. Especially when I know some of the contributors DO
> use Github. If you've read this list, you know my feelings about this
> subject.
>
> The automated CI check is a huge plus for both parties, and when I think
> about it, the time spent should be rather equal whether you choose
> git-send-email or git push. But the review and the 'fixing' part is
> definitely cleaner with git push.
>
> Now to your last sentence, I don't believe it's a matter of "attention
> seeking", but more some disgust towards Github. But I'd also like hear
> what's this all about. Would Gitlab be better than Github due to principles?
>
> -- juippis
Since I'm the one which does send patches through email on proxy-maint:
- It's not to jump the queue, in fact I get about the same lag in my
experience between GitHub PRs and using email. But it's much less predictable.
- I'd rather avoid GitHub completely, I do use it from time to time but because
I have to.
And while sending via GitHub sometimes works I also got at least one PR later
reverted because it didn't get a proper ACK from the maintainers, if I have to
also ping them through email, why not just send the patch via email?
Specially as metadata.xml already gives me the emails.
There is also the problem of having to sync your repo to GitHub,
if I forget to push gentoo's master to my fork I end up having to send all
the past history manually, and I discovered this one quite later on.
This was a huge pain when I only had the choice between a slow connection or
a metered one.
Also see https://forgeperf.org/ for how slow GitHub can get as just a web view.
Finally, I don't have this issue but github isn't available to everyone
depending on where they live, and often a VPN isn't an option there,
so another option needs to exists.
Best Regards,
next prev parent reply other threads:[~2020-06-07 16:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 23:45 [gentoo-proxy-maint] Posting patches on this mailing list instead of using GitHub Ralph Seichter
2020-06-07 7:01 ` Joonas Niilola
2020-06-07 16:42 ` Haelwenn (lanodan) Monnier [this message]
2020-06-07 17:24 ` Ralph Seichter
2020-06-07 18:15 ` Joonas Niilola
2020-06-08 8:42 ` Robert Günzler
2020-06-08 14:41 ` Randy Barlow
2020-06-08 16:59 ` Jimi Huotari
2020-06-09 6:01 ` Joonas Niilola
2020-06-07 16:58 ` tastytea
2020-06-09 6:10 ` Joonas Niilola
2020-06-09 11:37 ` tastytea
2020-06-09 12:30 ` Michał Górny
2020-06-07 17:36 ` Ralph Seichter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200607164227.GC25629@cloudsdale.the-delta.net.eu.org \
--to=contact@hacktivis.me \
--cc=gentoo-proxy-maint@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox