From: Matt Turner <mattst88@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Matt Turner <mattst88@gentoo.org>
Subject: [gentoo-catalyst] [PATCH] targets: Don't delete pyc/pyo files
Date: Sat, 16 May 2020 16:29:39 -0700 [thread overview]
Message-ID: <20200516232939.2709013-1-mattst88@gentoo.org> (raw)
These files are actually owned by their packages now, and removing them
can break subsequent builds.
See https://archives.gentoo.org/gentoo-releng-autobuilds/message/a115781f8e7fb4bd5adfb94a7f2e63b4
Signed-off-by: Matt Turner <mattst88@gentoo.org>
---
I'm minimally concerned about the potential for increasing the size of
the ISO. I'll report back with numbers.
targets/livecd-stage1/controller.sh | 4 ----
targets/livecd-stage2/controller.sh | 2 --
targets/stage1/preclean-chroot.sh | 2 --
3 files changed, 8 deletions(-)
diff --git a/targets/livecd-stage1/controller.sh b/targets/livecd-stage1/controller.sh
index ced2634e..c4572ff9 100755
--- a/targets/livecd-stage1/controller.sh
+++ b/targets/livecd-stage1/controller.sh
@@ -13,9 +13,5 @@ case $1 in
${clst_shdir}/${clst_target}/chroot.sh
echo "${clst_packages}" > ${clst_chroot_path}/tmp/packages.txt
;;
-
- clean)
- find ${clst_chroot_path}/usr/lib -iname "*.pyc" -exec rm -f {} \;
- ;;
esac
exit $?
diff --git a/targets/livecd-stage2/controller.sh b/targets/livecd-stage2/controller.sh
index 8ee46d7c..0701a26b 100755
--- a/targets/livecd-stage2/controller.sh
+++ b/targets/livecd-stage2/controller.sh
@@ -85,8 +85,6 @@ case $1 in
then
# Clean out man, info and doc files
rm -rf ${clst_chroot_path}/usr/share/{man,doc,info}/*
- # Zap all .pyc and .pyo files
- find ${clst_chroot_path}/usr/lib* -iname "*.py[co]" -exec rm -f {} \;
fi
rm -f ${clst_chroot_path}/tmp/packages.txt
;;
diff --git a/targets/stage1/preclean-chroot.sh b/targets/stage1/preclean-chroot.sh
index ea9056e8..2dc761e9 100755
--- a/targets/stage1/preclean-chroot.sh
+++ b/targets/stage1/preclean-chroot.sh
@@ -22,8 +22,6 @@ fi
# Clean out man, info and doc files
rm -rf "${ROOT}"/usr/share/{man,doc,info}/*
-# Zap all .pyc and .pyo files
-find "${ROOT}"/ -iname "*.py[co]" -exec rm -f {} \;
# unset ROOT for safety (even though cleanup_stages doesn't use it)
unset ROOT
--
2.26.2
next reply other threads:[~2020-05-16 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 23:29 Matt Turner [this message]
2020-05-17 0:38 ` [gentoo-catalyst] Re: [PATCH] targets: Don't delete pyc/pyo files Matt Turner
2020-05-20 22:59 ` Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516232939.2709013-1-mattst88@gentoo.org \
--to=mattst88@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox