From: Andreas Sturmlechner <asturm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2 2/3] virtualx.eclass: Make VIRTUALX_DEPEND readonly in EAPI-8
Date: Wed, 04 Aug 2021 13:13:52 +0200 [thread overview]
Message-ID: <1831835.7Z3S40VBb9@tuxbook> (raw)
In-Reply-To: <ufsvpzenf@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]
On Mittwoch, 4. August 2021 12:29:40 CEST Ulrich Mueller wrote:
> >>>>> On Wed, 04 Aug 2021, Andreas Sturmlechner wrote:
> > +# Standard dependencies string that is automatically added to BDEPEND
> > +# (in EAPI-6: DEPEND) unless VIRTUALX_REQUIRED is set to "manual".
> > +# DEPRECATED: Pre-EAPI-8 you can specify the variable BEFORE inherit
> > +# to add more dependencies.
> > +[[ ${EAPI} == [67] ]] || VIRTUALX_DEPEND=""
> > +VIRTUALX_DEPEND+="
> >
> > x11-base/xorg-server[xvfb]
> > x11-apps/xhost
> >
> > "
> >
> > +[[ ${EAPI} == [67] ]] || readonly VIRTUALX_DEPEND
>
> I wonder about this one, because the *DEPEND variables are automatically
> accumulated across eclasses and ebuild. What is the advantage of the
> ebuild specifying VIRTUALX_DEPEND, instead of specifying BDEPEND
> directly?
>
The answer is in the updated description in this patch: ebuilds/eclasses
specifying VIRTUALX_REQUIRED=manual have (so far) been relying on the content
of VIRTUALX_DEPEND to add the standard dependencies from within the ebuild
instead of having virtualx.eclass do it for them, for whatever complex
dependency situation they might have.
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
next prev parent reply other threads:[~2021-08-04 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 9:25 [gentoo-dev] [PATCH v2 1/3] virtualx.eclass: Support EAPI-8 Andreas Sturmlechner
2021-08-04 9:26 ` [gentoo-dev] [PATCH v2 2/3] virtualx.eclass: Make VIRTUALX_DEPEND readonly in EAPI-8 Andreas Sturmlechner
2021-08-04 10:29 ` Ulrich Mueller
2021-08-04 11:13 ` Andreas Sturmlechner [this message]
2021-08-04 9:27 ` [gentoo-dev] [PATCH v2 3/3] virtualx.eclass: Remove leftover variable VIRTUALX_COMMAND Andreas Sturmlechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1831835.7Z3S40VBb9@tuxbook \
--to=asturm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox