From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: eclass/tests/
Date: Mon, 04 Aug 2025 20:03:00 +0000 (UTC) [thread overview]
Message-ID: <1754337762.ee83b41b824cc10dd263e34ca42644acf037e360.sam@gentoo> (raw)
commit: ee83b41b824cc10dd263e34ca42644acf037e360
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Mon Aug 4 20:01:56 2025 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Aug 4 20:02:42 2025 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ee83b41b
eclass/tests: dot-a: test strip doesn't break foreign architectures
... with binutils[-multitarget].
Make sure that strip doesn't break binaries for another architecture
and instead bails out (bug #960493, https://sourceware.org/PR33230).
Bug: https://bugs.gentoo.org/960493
Bug: ttps://sourceware.org/PR33230
Signed-off-by: Sam James <sam <AT> gentoo.org>
eclass/tests/dot-a.sh | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/eclass/tests/dot-a.sh b/eclass/tests/dot-a.sh
index bb17e62b5afc..a70ea20e632a 100755
--- a/eclass/tests/dot-a.sh
+++ b/eclass/tests/dot-a.sh
@@ -564,6 +564,48 @@ test_strip_nolto() {
tend ${ret} "strip -d ignored an archive when it shouldn't"
}
+test_strip_cross() {
+ # Make sure that strip doesn't break binaries for another architecture
+ # and instead bails out (bug #960493, https://sourceware.org/PR33230).
+ local machine=$($(tc-getCC) -dumpmachine)
+ # Just assume we're on x86_64-pc-linux-gnu and have a
+ # aarch64-unknown-linux-gnu toolchain available for testing.
+ if [[ ${machine} != x86_64-pc-linux-gnu ]] || ! type -P aarch64-unknown-linux-gnu-gcc &> /dev/null ; then
+ # TODO: Iterate over cross toolchains available?
+ return
+ fi
+ # The test only makes sense with binutils[-multitarget], otherwise
+ # binutils will iterate over all available targets and just pick one
+ # rather than not-figuring-it-out and setting EM_NONE.
+ if $(tc-getSTRIP) |& grep -q aarch ; then
+ return
+ fi
+
+ tbegin "whether strip breaks binaries for a foreign architecture"
+ ret=0
+ (
+ rm foo.a foo.a.bak 2>/dev/null
+ _create_test_progs
+
+ aarch64-unknown-linux-gnu-gcc a.c -o a.o -c -ggdb3 || return 1
+ cp a.o a.o.bak || return 1
+ # We want this to error out with binutils[-multitarget]
+ # and we skip the test earlier on if binutils[multitarget].
+ $(tc-getSTRIP) -p a.o &>/dev/null || return 0
+
+ if file a.o |& grep "no machine" ; then
+ return 1
+ fi
+
+ # They should not differ because it's unsafe to touch
+ # for a foreign architecture.
+ cmp -s a.a a.a.bak || return 1
+
+ return 0
+ ) || ret=1
+ tend ${ret} ""
+}
+
_repeat_tests_with_compilers() {
# Call test_lto_guarantee_fat and test_strip_lto_bytecode with
# various compilers and linkers.
@@ -623,4 +665,5 @@ test_search_recursion
test_strip_lto
test_strip_lto_mixed
test_strip_nolto
+test_strip_cross
texit
next reply other threads:[~2025-08-04 20:03 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 20:03 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-08-15 5:20 [gentoo-commits] repo/gentoo:master commit in: eclass/tests/ Sam James
2025-08-08 17:39 Sam James
2025-08-04 21:22 Sam James
2025-08-04 21:22 Sam James
2025-08-04 20:04 Sam James
2025-08-04 20:03 Sam James
2025-08-04 19:19 Sam James
2025-08-04 19:19 Sam James
2025-07-23 22:36 Sam James
2025-07-23 22:36 Sam James
2025-06-13 9:21 Sam James
2025-06-13 8:52 Sam James
2025-06-13 8:32 Sam James
2025-06-13 8:32 Sam James
2025-06-10 7:59 Sam James
2025-05-23 18:59 Michał Górny
2025-05-06 8:46 Sam James
2025-05-02 18:25 Michał Górny
2025-05-02 8:06 Petr Vaněk
2025-05-01 11:36 Michał Górny
2024-12-30 11:35 Michał Górny
2024-12-30 11:35 Michał Górny
2024-12-21 8:11 Michał Górny
2024-12-20 20:39 Michał Górny
2024-12-20 20:39 Michał Górny
2024-12-09 18:49 Ulrich Müller
2024-09-19 4:13 Sam James
2024-09-18 15:51 Sam James
2024-09-18 15:51 Sam James
2024-08-07 8:58 Andrew Ammerlaan
2024-08-07 8:58 Andrew Ammerlaan
2024-08-06 8:47 Michał Górny
2024-08-06 8:47 Michał Górny
2024-07-29 17:02 Michał Górny
2024-07-28 9:32 Ulrich Müller
2024-06-13 19:53 Ulrich Müller
2024-06-13 19:53 Ulrich Müller
2024-06-13 18:35 Ulrich Müller
2024-06-13 18:35 Ulrich Müller
2024-06-12 16:47 Ulrich Müller
2024-06-12 15:35 Michał Górny
2024-06-12 15:32 Ulrich Müller
2024-06-12 9:47 Ulrich Müller
2024-05-25 8:24 Ulrich Müller
2023-11-03 19:00 Michał Górny
2023-09-14 5:30 Michał Górny
2023-06-18 14:57 Michał Górny
2023-06-17 10:10 Michał Górny
2023-06-15 12:19 Michał Górny
2023-05-23 4:36 Michał Górny
2023-05-01 13:43 Sam James
2023-04-20 23:14 Sam James
2022-12-14 10:18 Michał Górny
2022-10-28 8:24 Michał Górny
2022-10-15 17:35 Mike Gilbert
2022-10-10 20:52 Michał Górny
2022-10-01 17:19 Michał Górny
2022-10-01 17:19 Michał Górny
2022-09-27 20:28 Michał Górny
2022-05-09 20:33 Michał Górny
2022-05-09 20:33 Michał Górny
2022-04-21 15:19 Michał Górny
2022-04-19 21:32 Mike Gilbert
2022-02-14 21:13 Mike Gilbert
2022-02-14 17:25 Mike Gilbert
2021-12-31 9:10 Michał Górny
2021-12-31 9:10 Michał Górny
2021-12-31 9:10 Michał Górny
2021-06-22 20:44 David Seifert
2021-05-12 20:55 Mike Gilbert
2021-05-12 19:39 Michał Górny
2021-05-05 18:20 Michał Górny
2021-03-28 11:48 Michał Górny
2020-11-23 18:11 Ulrich Müller
2020-07-02 8:29 Michał Górny
2020-07-02 8:29 Michał Górny
2020-07-02 8:29 Michał Górny
2020-07-02 8:29 Michał Górny
2020-06-19 11:52 Michał Górny
2020-05-28 11:41 Michał Górny
2020-05-10 1:02 Sergei Trofimovich
2020-04-30 9:45 Michał Górny
2020-04-19 16:47 Michał Górny
2020-03-30 13:11 Michał Górny
2020-03-30 11:57 Michał Górny
2020-03-27 23:54 Sergei Trofimovich
2020-02-27 16:29 Michał Górny
2020-02-09 18:09 Michał Górny
2019-12-23 11:47 Sergei Trofimovich
2019-12-13 22:37 Sergei Trofimovich
2019-12-07 16:59 Michał Górny
2019-12-01 11:29 Sergei Trofimovich
2019-11-24 15:09 Michał Górny
2019-11-20 20:30 Sergei Trofimovich
2019-11-20 19:51 Sergei Trofimovich
2019-11-20 9:23 Michał Górny
2019-11-20 9:16 Michał Górny
2019-11-20 9:15 Michał Górny
2019-11-20 9:00 Michał Górny
2019-11-20 9:00 Michał Górny
2019-11-20 9:00 Michał Górny
2019-11-20 8:46 Michał Górny
2019-11-20 8:46 Michał Górny
2019-11-20 8:46 Michał Górny
2019-11-20 7:47 Michał Górny
2019-11-06 22:44 Sergei Trofimovich
2018-12-09 20:32 Sergei Trofimovich
2018-12-09 20:32 Sergei Trofimovich
2018-12-09 20:32 Sergei Trofimovich
2017-09-19 13:15 Michał Górny
2017-09-14 19:05 Mike Gilbert
2017-08-08 19:42 Michał Górny
2017-04-14 16:28 Michał Górny
2017-03-08 7:35 Michał Górny
2016-06-27 5:58 Michał Górny
2016-01-08 5:14 Michał Górny
2015-12-09 20:42 Michał Górny
2015-11-21 19:58 Ulrich Müller
2015-11-12 16:03 Michał Górny
2015-11-11 10:27 Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1754337762.ee83b41b824cc10dd263e34ca42644acf037e360.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox