public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Eli Schwartz" <eschwartz@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/newt/
Date: Fri, 09 May 2025 07:12:23 +0000 (UTC)	[thread overview]
Message-ID: <1746774590.88a2f23c6c3b2bce6f45bbbc899380cfb456394d.eschwartz@gentoo> (raw)

commit:     88a2f23c6c3b2bce6f45bbbc899380cfb456394d
Author:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
AuthorDate: Tue May  6 08:14:59 2025 +0000
Commit:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
CommitDate: Fri May  9 07:09:50 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88a2f23c

dev-libs/newt: vastly simplify configure/build without copying sources

configuring building and installing multiple times is very complicated
and also tends to slow down due to repeated configures. Upstream since
2002 (!!!) has supported configuring and building for multiple python
versions in a single `./configure && make`

It is unclear why the copy+configure route was ever taken.

Acked-by: Ben Kohler <bkohler <AT> gentoo.org>
Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org>

 dev-libs/newt/newt-0.52.25.ebuild | 34 ++++++++++++++--------------------
 1 file changed, 14 insertions(+), 20 deletions(-)

diff --git a/dev-libs/newt/newt-0.52.25.ebuild b/dev-libs/newt/newt-0.52.25.ebuild
index a6855be8aa13..74ea42133082 100644
--- a/dev-libs/newt/newt-0.52.25.ebuild
+++ b/dev-libs/newt/newt-0.52.25.ebuild
@@ -59,34 +59,28 @@ src_prepare() {
 
 	default
 	eautoreconf
-
-	# can't build out-of-source
-	python_copy_sources
 }
 
 src_configure() {
-	configuring() {
-		econf \
-			--with-python="${EPYTHON}" \
-			$(use_with gpm gpm-support) \
-			$(use_with tcl) \
-			$(use_enable nls)
+	local versions=
+	getversions() {
+		versions+="${EPYTHON} "
 	}
-	python_foreach_impl run_in_build_dir configuring
-}
+	python_foreach_impl getversions
 
-src_compile() {
-	python_foreach_impl run_in_build_dir emake
+	econf \
+		--with-python="${versions}" \
+		$(use_with gpm gpm-support) \
+		$(use_with tcl) \
+		$(use_enable nls)
 }
 
 src_install() {
-	installit() {
-		emake \
-			DESTDIR="${D}" \
-			install
-		python_optimize
-	}
-	python_foreach_impl run_in_build_dir installit
+	emake \
+		DESTDIR="${D}" \
+		install
+	python_foreach_impl python_optimize
+
 	dodoc peanuts.py popcorn.py tutorial.sgml
 	doman whiptail.1
 	einstalldocs


             reply	other threads:[~2025-05-09  7:12 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09  7:12 Eli Schwartz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-09-06 15:31 [gentoo-commits] repo/gentoo:master commit in: dev-libs/newt/ Sam James
2025-07-03 12:34 Ben Kohler
2025-06-21 18:57 Arthur Zamarin
2025-06-21  3:59 Sam James
2025-06-16 16:38 Sam James
2025-06-16 16:38 Sam James
2025-06-16 16:38 Sam James
2025-06-16 16:38 Sam James
2025-05-11  6:41 Eli Schwartz
2025-05-09  7:12 Eli Schwartz
2025-05-09  7:12 Eli Schwartz
2025-05-09  7:12 Eli Schwartz
2025-05-09  7:12 Eli Schwartz
2025-03-13 17:45 Ben Kohler
2025-01-16 17:42 Ben Kohler
2024-08-25 15:24 Andreas K. Hüttel
2024-04-26 18:16 Sam James
2024-04-26 17:16 Sam James
2024-04-26 17:16 Sam James
2024-04-26 17:16 Sam James
2024-04-26 17:16 Sam James
2024-04-26 17:10 Sam James
2024-04-26 17:10 Sam James
2024-02-06 20:53 Ben Kohler
2023-10-30 16:35 Ben Kohler
2023-08-02  9:05 Arthur Zamarin
2023-07-15  6:08 Sam James
2023-07-15  3:10 Sam James
2023-07-14  0:42 Sam James
2023-07-13 20:28 Sam James
2023-07-13 20:23 Sam James
2023-07-13 20:23 Sam James
2023-01-10 18:17 Ben Kohler
2023-01-10 18:17 Ben Kohler
2022-12-30 18:19 Arthur Zamarin
2022-12-30 18:18 Arthur Zamarin
2022-12-30 18:18 Arthur Zamarin
2022-12-30 18:04 Sam James
2022-12-30 18:04 Sam James
2022-12-30 18:04 Sam James
2022-12-30 17:09 Sam James
2022-11-30  2:00 Ben Kohler
2022-11-22 11:39 Ben Kohler
2022-07-28 13:55 Ben Kohler
2022-07-25 14:26 Ben Kohler
2022-05-24 11:14 WANG Xuerui
2022-05-05 14:26 Joonas Niilola
2022-04-15  8:22 Arthur Zamarin
2022-04-15  7:16 Arthur Zamarin
2022-04-15  7:16 Arthur Zamarin
2022-04-15  6:21 Agostino Sarubbo
2022-04-15  6:15 Arthur Zamarin
2022-04-14 19:36 Jakov Smolić
2022-04-14 19:36 Jakov Smolić
2021-08-08 19:46 Marek Szuba
2021-05-18 14:38 Ben Kohler
2020-07-07 14:35 Ben Kohler
2020-05-27 14:59 Ben Kohler
2020-04-28 18:11 Sergei Trofimovich
2020-04-26 15:31 Agostino Sarubbo
2020-04-26 15:30 Agostino Sarubbo
2020-04-26 14:19 Agostino Sarubbo
2020-04-26 14:16 Agostino Sarubbo
2020-04-26  8:58 Sergei Trofimovich
2020-04-25 18:04 Matt Turner
2020-01-08 18:09 Ben Kohler
2020-01-02  8:40 Sergei Trofimovich
2019-12-28 15:49 Mikle Kolyada
2019-12-24 14:47 Mikle Kolyada
2019-12-17 14:03 Ben Kohler
2019-12-10 12:19 Agostino Sarubbo
2019-12-09 12:10 Agostino Sarubbo
2019-12-09  8:48 Agostino Sarubbo
2019-12-08 23:37 Sergei Trofimovich
2019-12-08  4:02 Aaron Bauman
2019-12-07 16:59 Michał Górny
2019-12-05 22:15 Sergei Trofimovich
2019-12-05  8:38 Agostino Sarubbo
2019-12-02 14:12 Ben Kohler
2019-05-30 21:11 Ben Kohler
2019-05-30 20:41 Ben Kohler
2019-05-30 20:41 Ben Kohler
2019-05-23  6:39 Aaron Bauman
2018-10-09  9:40 Mikle Kolyada
2018-09-13 14:31 Tobias Klausmann
2018-08-16  0:39 Thomas Deutschmann
2018-08-14  0:45 Mikle Kolyada
2018-08-09  6:09 Sergei Trofimovich
2018-08-08 16:25 Ben Kohler
2018-02-15 14:27 Patrice Clement

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1746774590.88a2f23c6c3b2bce6f45bbbc899380cfb456394d.eschwartz@gentoo \
    --to=eschwartz@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox