From: "Eli Schwartz" <eschwartz@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sci-electronics/spice/
Date: Fri, 04 Apr 2025 03:56:25 +0000 (UTC) [thread overview]
Message-ID: <1743738268.9f1ab1c993348c521d8371eb609c6f7145c335bf.eschwartz@gentoo> (raw)
commit: 9f1ab1c993348c521d8371eb609c6f7145c335bf
Author: Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
AuthorDate: Fri Apr 4 03:15:47 2025 +0000
Commit: Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
CommitDate: Fri Apr 4 03:44:28 2025 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f1ab1c9
sci-electronics/spice: "fix" Modern C issues by declaring defeat
The software is extremely crusty. As mentioned in the previous commit,
it hasn't been maintained since 1993 and there are derivative projects
which likely solve these issues. The code has "worked" since 1993 and I
suspect unlikely to ever be of much interest to new platforms, given
that it's only even useful as a point of reference compared to its
modern derivatives. Keep in mind the code is so old that it's from back
when the most recent brand new C revision supported implicit function
declarations.
Trying to solve its C issues seems unworthwhile. Just -std=c89 it.
Actually, gnu89 since it depends on `#define linux` to detect the
platform. :P
Closes: https://bugs.gentoo.org/919301
Closes: https://bugs.gentoo.org/944870
Closes: https://bugs.gentoo.org/945068
Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org>
sci-electronics/spice/spice-3.5.5-r4.ebuild | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sci-electronics/spice/spice-3.5.5-r4.ebuild b/sci-electronics/spice/spice-3.5.5-r4.ebuild
index 1fd93a015f94..86ec6e1741ec 100644
--- a/sci-electronics/spice/spice-3.5.5-r4.ebuild
+++ b/sci-electronics/spice/spice-3.5.5-r4.ebuild
@@ -41,6 +41,10 @@ src_prepare() {
# spice accepts -O1 at most
replace-flags -O* -O1
+ # The code is from 1989, later updated in 1993. It is deeply incompatible
+ # with Modern C (c99). It also needs `#define linux` from gnu...
+ append-flags -std=gnu89
+
# Avoid re-creating WORKDIR due to stupid mtime
touch ..
next reply other threads:[~2025-04-04 3:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 3:56 Eli Schwartz [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-04 3:56 [gentoo-commits] repo/gentoo:master commit in: sci-electronics/spice/ Eli Schwartz
2024-04-11 10:59 Arthur Zamarin
2023-12-16 3:05 Sam James
2023-09-12 7:13 Andrew Ammerlaan
2022-01-16 23:56 Mike Gilbert
2022-01-16 23:56 Mike Gilbert
2018-05-22 1:19 Matt Turner
2018-05-21 17:05 Aaron Bauman
2018-03-31 21:46 Aaron Bauman
2017-05-24 17:16 Thomas Beierlein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1743738268.9f1ab1c993348c521d8371eb609c6f7145c335bf.eschwartz@gentoo \
--to=eschwartz@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox