public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: profiles/features/time64/
Date: Sat, 29 Mar 2025 20:41:41 +0000 (UTC)	[thread overview]
Message-ID: <1743280880.14a601e15ab01beb11974a83930e8be4a91090a8.sam@gentoo> (raw)

commit:     14a601e15ab01beb11974a83930e8be4a91090a8
Author:     Jannik Glückert <jannik.glueckert <AT> gmail <DOT> com>
AuthorDate: Sat Mar 29 20:24:00 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Mar 29 20:41:20 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=14a601e1

profiles: fix illegal variable name

PMS 5.2.4 make.defaults
> A variable name must start with one of a-zA-Z

Signed-off-by: Jannik Glückert <jannik.glueckert <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/41374
Signed-off-by: Sam James <sam <AT> gentoo.org>

 profiles/features/time64/make.defaults | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/profiles/features/time64/make.defaults b/profiles/features/time64/make.defaults
index 0edc40fa682e..b8990b710b0b 100644
--- a/profiles/features/time64/make.defaults
+++ b/profiles/features/time64/make.defaults
@@ -3,12 +3,10 @@
 
 # Many profiles and stages override CFLAGS etc, and need then to eat their
 # own dogfood. For those who don't...
-__COMMON_FLAGS_TIME64="-D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64"
-
-CFLAGS="${CFLAGS} ${__COMMON_FLAGS_TIME64} -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-pointer-types -Werror=return-type -Werror=int-conversion"
-CXXFLAGS="${CXXFLAGS} ${__COMMON_FLAGS_TIME64}"
-FCFLAGS="${FCFLAGS} ${__COMMON_FLAGS_TIME64}"
-FFLAGS="${FFLAGS} ${__COMMON_FLAGS_TIME64}"
+CFLAGS="${CFLAGS} -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-pointer-types -Werror=return-type -Werror=int-conversion"
+CXXFLAGS="${CXXFLAGS} -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64"
+FCFLAGS="${FCFLAGS} -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64"
+FFLAGS="${FFLAGS} -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64"
 
 # We need to switch this explicitly on since it's explicitly disabled
 # in profiles otherwise.


             reply	other threads:[~2025-03-29 20:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-29 20:41 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-10 13:29 [gentoo-commits] repo/gentoo:master commit in: profiles/features/time64/ Andreas K. Hüttel
2025-05-29 12:22 Andreas K. Hüttel
2024-11-07  5:28 Michał Górny
2024-08-19 14:36 Andreas K. Hüttel
2024-06-22 18:25 Andreas K. Hüttel
2024-06-22 11:54 Andreas K. Hüttel
2024-04-06 17:33 Andreas K. Hüttel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1743280880.14a601e15ab01beb11974a83930e8be4a91090a8.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox