public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Eli Schwartz" <eschwartz@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/sysprof/
Date: Tue, 31 Dec 2024 05:59:55 +0000 (UTC)	[thread overview]
Message-ID: <1735624647.73a60ab1ebeea720bdbde5c4f5b3ba1a3ed7cf86.eschwartz@gentoo> (raw)

commit:     73a60ab1ebeea720bdbde5c4f5b3ba1a3ed7cf86
Author:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
AuthorDate: Tue Dec 31 00:28:02 2024 +0000
Commit:     Eli Schwartz <eschwartz <AT> gentoo <DOT> org>
CommitDate: Tue Dec 31 05:57:27 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73a60ab1

dev-util/sysprof: fix nastily propagating automagic dep

sysprof 45.0 and on introduce a systemd feature (journald integration)
which is implemented by depending on libsystemd.so if it is installed at
the time of building.

https://github.com/GNOME/sysprof/commit/88d0589fea80307fe8d49a9c4f93ef99cb6a5e8b

This dependency was never added during the version bump in ::gentoo. It
breaks, among other things, binhost caching. Fix by introducing
USE=systemd support to this package. We use strong blockers to prevent
systemd from even being installed when src_compile'ing with -systemd,
since otherwise it genuinely miscompiles. This is probably fine, since
people using systemd profiles have USE=systemd by default unless they go
out of their way to unset it, and people with non-systemd profiles
shouldn't have this USE set at all.

(Note that it's fine to install a binpackage built without systemd
support, even on a systemd profile.)

Straight to stable, the package nastily breaks on openrc systems and the
changes are purely to dependency metadata.

Fixes: 29d274e3ecdde94273ddd9f247efa9c5e12dab73
Fixes: https://github.com/gentoo/gentoo/pull/34771
Closes: https://bugs.gentoo.org/947256
Signed-off-by: Eli Schwartz <eschwartz <AT> gentoo.org>

 dev-util/sysprof/{sysprof-46.0.ebuild => sysprof-46.0-r1.ebuild} | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/dev-util/sysprof/sysprof-46.0.ebuild b/dev-util/sysprof/sysprof-46.0-r1.ebuild
similarity index 95%
rename from dev-util/sysprof/sysprof-46.0.ebuild
rename to dev-util/sysprof/sysprof-46.0-r1.ebuild
index 709f8ac2dcfc..43b8f904cba8 100644
--- a/dev-util/sysprof/sysprof-46.0.ebuild
+++ b/dev-util/sysprof/sysprof-46.0-r1.ebuild
@@ -12,7 +12,7 @@ LICENSE="GPL-3+ GPL-2+"
 API_VERSION="4"
 SLOT="0/${API_VERSION}"
 KEYWORDS="amd64 ~arm64 x86"
-IUSE="gtk test"
+IUSE="gtk systemd test"
 RESTRICT="!test? ( test )"
 
 RDEPEND="
@@ -23,6 +23,7 @@ RDEPEND="
 		x11-libs/cairo
 		x11-libs/pango
 	)
+	systemd? ( sys-apps/systemd )
 	dev-libs/json-glib
 	>=dev-libs/libdex-0.3.1
 	>=gui-libs/libpanel-1.3.0
@@ -31,7 +32,10 @@ RDEPEND="
 	>=dev-util/sysprof-common-${PV}
 	>=dev-util/sysprof-capture-${PV}:${API_VERSION}
 "
-DEPEND="${RDEPEND}"
+DEPEND="
+	${RDEPEND}
+	!systemd? ( !!sys-apps/systemd )
+"
 BDEPEND="
 	dev-libs/appstream-glib
 	dev-util/gdbus-codegen


             reply	other threads:[~2024-12-31  6:00 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-31  5:59 Eli Schwartz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-09-28 11:02 [gentoo-commits] repo/gentoo:master commit in: dev-util/sysprof/ Pacho Ramos
2025-08-04  8:16 Pacho Ramos
2025-08-03  9:34 Pacho Ramos
2025-08-03  9:34 Pacho Ramos
2025-08-02 17:42 Pacho Ramos
2025-08-02 17:42 Pacho Ramos
2025-06-28 20:48 Sam James
2025-06-28 18:47 Sam James
2025-04-24  8:16 Sam James
2025-01-26 15:01 Pacho Ramos
2025-01-26 15:01 Pacho Ramos
2025-01-24 10:49 WANG Xuerui
2024-12-31  5:59 Eli Schwartz
2024-11-10  0:42 Jakov Smolić
2024-11-09 10:40 Pacho Ramos
2023-05-03  6:33 Arthur Zamarin
2023-05-03  6:33 Arthur Zamarin
2023-03-18  2:28 Matt Turner
2022-10-30 15:42 Matt Turner
2022-09-24 20:05 Matt Turner
2022-03-25 18:25 Matt Turner
2021-12-19 16:59 Matt Turner
2021-07-17 23:14 Sam James
2021-06-13 20:25 Sam James
2021-06-07  1:06 Matt Turner
2021-02-17 18:42 Sam James
2021-02-17 14:21 Sam James
2020-12-04  1:32 Matt Turner
2020-12-04  1:32 Matt Turner
2020-07-04 12:00 Mart Raudsepp
2020-03-02 19:23 Mart Raudsepp
2020-03-01 16:18 Mart Raudsepp
2019-12-23 21:26 Mart Raudsepp
2019-07-27  8:36 Mart Raudsepp
2019-05-18 19:59 Mart Raudsepp
2018-12-17 15:08 Mart Raudsepp
2018-08-02 20:58 Mart Raudsepp
2018-02-19 20:03 Mart Raudsepp
2018-02-19 20:03 Mart Raudsepp
2018-02-06 18:36 Thomas Deutschmann
2018-01-26 15:03 Mikle Kolyada
2017-06-05  0:13 Mart Raudsepp
2017-06-05  0:13 Mart Raudsepp
2017-06-05  0:13 Mart Raudsepp
2017-04-18 11:14 Mart Raudsepp
2016-11-12 12:23 Gilles Dartiguelongue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1735624647.73a60ab1ebeea720bdbde5c4f5b3ba1a3ed7cf86.eschwartz@gentoo \
    --to=eschwartz@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox