From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-libs/lsp-plugins/
Date: Fri, 15 Mar 2024 02:53:47 +0000 (UTC) [thread overview]
Message-ID: <1710471190.2e1a1763119efca3eaa26835bafdc664ca039b7d.sam@gentoo> (raw)
commit: 2e1a1763119efca3eaa26835bafdc664ca039b7d
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Mar 15 02:53:10 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Mar 15 02:53:10 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e1a1763
media-libs/lsp-plugins: backport LTO filtering
Bug: https://bugs.gentoo.org/875833
Closes: https://bugs.gentoo.org/874339
Signed-off-by: Sam James <sam <AT> gentoo.org>
media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild | 11 +++++++++++
media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild | 11 +++++++++++
media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild | 11 +++++++++++
3 files changed, 33 insertions(+)
diff --git a/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild b/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild
index dde3a257e761..cb0430405e9a 100644
--- a/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild
+++ b/media-libs/lsp-plugins/lsp-plugins-1.2.3-r1.ebuild
@@ -59,6 +59,17 @@ PATCHES=(
)
src_configure() {
+ # -Werror=odr
+ # https://bugs.gentoo.org/875833
+ #
+ # Actually the whole thing is kind of a waste of time. It looks like
+ # programs use LDFLAGS, but libraries do not! So some things don't
+ # build with LTO, while other things don't build when LTO is enabled.
+ # Attempting to build with LTO is just a waste of time and cycles.
+ #
+ # This was reported upstream but the ticket closed. Abandon hope.
+ filter-lto
+
use doc && MODULES+="doc"
use jack && MODULES+=" jack"
use ladspa && MODULES+=" ladspa"
diff --git a/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild b/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild
index f8d5a15f29c2..564fb4512fb9 100644
--- a/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild
+++ b/media-libs/lsp-plugins/lsp-plugins-1.2.3.ebuild
@@ -55,6 +55,17 @@ DEPEND="
RDEPEND="${DEPEND}"
src_configure() {
+ # -Werror=odr
+ # https://bugs.gentoo.org/875833
+ #
+ # Actually the whole thing is kind of a waste of time. It looks like
+ # programs use LDFLAGS, but libraries do not! So some things don't
+ # build with LTO, while other things don't build when LTO is enabled.
+ # Attempting to build with LTO is just a waste of time and cycles.
+ #
+ # This was reported upstream but the ticket closed. Abandon hope.
+ filter-lto
+
use doc && MODULES+="doc"
use jack && MODULES+=" jack"
use ladspa && MODULES+=" ladspa"
diff --git a/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild b/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild
index f8d5a15f29c2..564fb4512fb9 100644
--- a/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild
+++ b/media-libs/lsp-plugins/lsp-plugins-1.2.6.ebuild
@@ -55,6 +55,17 @@ DEPEND="
RDEPEND="${DEPEND}"
src_configure() {
+ # -Werror=odr
+ # https://bugs.gentoo.org/875833
+ #
+ # Actually the whole thing is kind of a waste of time. It looks like
+ # programs use LDFLAGS, but libraries do not! So some things don't
+ # build with LTO, while other things don't build when LTO is enabled.
+ # Attempting to build with LTO is just a waste of time and cycles.
+ #
+ # This was reported upstream but the ticket closed. Abandon hope.
+ filter-lto
+
use doc && MODULES+="doc"
use jack && MODULES+=" jack"
use ladspa && MODULES+=" ladspa"
next reply other threads:[~2024-03-15 2:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 2:53 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-02 5:55 [gentoo-commits] repo/gentoo:master commit in: media-libs/lsp-plugins/ Arthur Zamarin
2024-04-02 5:55 Arthur Zamarin
2024-04-02 1:53 Sam James
2024-03-15 2:53 Sam James
2024-03-05 4:48 Sam James
2023-12-27 17:21 Marek Szuba
2023-05-05 9:50 Arthur Zamarin
2023-05-04 15:11 Arthur Zamarin
2023-05-04 11:21 Sam James
2022-10-19 3:47 Sam James
2022-10-03 1:57 Sam James
2022-10-03 1:57 Sam James
2022-10-03 0:49 Sam James
2021-12-06 14:59 Marek Szuba
2021-07-13 0:05 Sam James
2021-07-13 0:05 Sam James
2021-03-11 2:42 Sam James
2021-02-22 7:18 Sam James
2021-02-22 7:14 Sam James
2021-02-21 0:54 Sam James
2021-02-06 10:39 Miroslav Šulc
2021-02-06 10:35 Miroslav Šulc
2021-02-04 20:22 Miroslav Šulc
2021-01-06 6:34 Sam James
2020-12-31 5:20 Sam James
2020-08-16 19:20 Matthew Thode
2020-08-15 19:50 Matthew Thode
2020-06-16 18:56 Matthew Thode
2019-12-16 6:48 Matthew Thode
2019-04-14 0:59 Matthew Thode
2019-03-25 17:27 Matthew Thode
2019-03-20 23:35 Matthew Thode
2019-02-24 23:51 Matthew Thode
2019-02-24 22:03 Matthew Thode
2019-02-24 1:55 Matthew Thode
2019-02-23 22:25 Matthew Thode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1710471190.2e1a1763119efca3eaa26835bafdc664ca039b7d.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox