From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-libs/libcdaudio/
Date: Mon, 11 Mar 2024 14:24:09 +0000 (UTC) [thread overview]
Message-ID: <1710166969.fa245858213a0663022ff039f5ee7dbd2ec8575c.sam@gentoo> (raw)
commit: fa245858213a0663022ff039f5ee7dbd2ec8575c
Author: Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Mon Mar 11 02:48:36 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Mar 11 14:22:49 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fa245858
media-libs/libcdaudio: fully refresh autotools
It uses an extremely vintage 2004 edition that includes some kind of
horrible idea from the early days of the 21st century. Apparently, back
then, portability meant "autotools can convert your ANSI C code to K&R
C". This functionality has long since been removed from current
automake, so eautoreconf doesn't actually run until we remove a few
troublesome lines.
Needed to e.g. pass LTO warning flags through to the linker, and well, a
whole lot more.
Also fixes a build issue with conflicting definitions of mount?
Closes: https://bugs.gentoo.org/859910
Closes: https://bugs.gentoo.org/898236
Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>
media-libs/libcdaudio/libcdaudio-0.99.12-r5.ebuild | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/media-libs/libcdaudio/libcdaudio-0.99.12-r5.ebuild b/media-libs/libcdaudio/libcdaudio-0.99.12-r5.ebuild
index 173d115c8d84..d64a5a9ac226 100644
--- a/media-libs/libcdaudio/libcdaudio-0.99.12-r5.ebuild
+++ b/media-libs/libcdaudio/libcdaudio-0.99.12-r5.ebuild
@@ -3,6 +3,8 @@
EAPI=8
+inherit autotools
+
DESCRIPTION="Library of cd audio related routines"
HOMEPAGE="https://libcdaudio.sourceforge.net/"
SRC_URI="mirror://sourceforge/libcdaudio/${P}.tar.gz"
@@ -18,6 +20,16 @@ PATCHES=(
"${FILESDIR}"/${P}-m4-testprogram-fix.patch
)
+src_prepare() {
+ default
+
+ # replace vintage 2004 autotools collection complete with worrying
+ # code to "make it portable" by converting ANSI C into K&R C
+ sed -i '/AM_C_PROTOTYPES/d' configure.ac
+ sed -i '/ansi2knr/d' Makefile.am
+ eautoreconf
+}
+
src_configure() {
econf --enable-threads --disable-static
}
next reply other threads:[~2024-03-11 14:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 14:24 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-13 7:38 [gentoo-commits] repo/gentoo:master commit in: media-libs/libcdaudio/ Miroslav Šulc
2024-04-11 16:51 Arthur Zamarin
2024-04-11 10:32 Arthur Zamarin
2024-04-11 10:32 Arthur Zamarin
2024-04-11 9:58 Sam James
2024-04-11 9:00 Arthur Zamarin
2024-04-11 9:00 Arthur Zamarin
2024-03-11 14:24 Sam James
2024-03-11 14:24 Sam James
2024-03-11 14:24 Sam James
2023-07-07 7:31 Miroslav Šulc
2022-10-31 6:34 Miroslav Šulc
2022-10-25 10:44 Sam James
2022-10-25 9:49 Sam James
2022-10-23 19:36 Arthur Zamarin
2022-10-23 11:04 Sam James
2022-10-23 11:04 Sam James
2022-10-23 11:04 Sam James
2022-03-28 8:21 Miroslav Šulc
2022-03-28 6:53 Agostino Sarubbo
2022-03-28 6:51 Agostino Sarubbo
2022-03-26 19:45 Sam James
2022-03-26 19:11 Arthur Zamarin
2022-03-26 16:51 Arthur Zamarin
2022-03-26 16:49 Arthur Zamarin
2019-02-22 11:17 Mikle Kolyada
2019-02-22 11:15 Mikle Kolyada
2019-02-22 11:15 Mikle Kolyada
2019-02-12 21:03 Sergei Trofimovich
2019-02-12 8:12 Sergei Trofimovich
2019-02-12 8:11 Sergei Trofimovich
2019-02-11 7:13 Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1710166969.fa245858213a0663022ff039f5ee7dbd2ec8575c.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox