From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/rocm-opencl-runtime/
Date: Sat, 20 Jan 2024 13:10:30 +0000 (UTC) [thread overview]
Message-ID: <1705755738.af35827c5fdb9e5ae44b0b16c0ff2acd68f5edab.sam@gentoo> (raw)
commit: af35827c5fdb9e5ae44b0b16c0ff2acd68f5edab
Author: Sv. Lockal <lockalsash <AT> gmail <DOT> com>
AuthorDate: Tue Jan 9 13:55:57 2024 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Jan 20 13:02:18 2024 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af35827c
dev-libs/rocm-opencl-runtime: fix linker error for ld.lld: error: version script assignment issue
Upstream bug: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
Signed-off-by: Sv. Lockal <lockalsash <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/34720
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.1.3.ebuild | 10 +++++++++-
.../rocm-opencl-runtime/rocm-opencl-runtime-5.3.3-r1.ebuild | 10 +++++++++-
.../rocm-opencl-runtime/rocm-opencl-runtime-5.4.3-r1.ebuild | 10 +++++++++-
dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.5.1.ebuild | 10 +++++++++-
.../rocm-opencl-runtime/rocm-opencl-runtime-5.7.1-r1.ebuild | 10 +++++++++-
dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-6.0.0.ebuild | 10 +++++++++-
dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-9999.ebuild | 10 +++++++++-
7 files changed, 63 insertions(+), 7 deletions(-)
diff --git a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.1.3.ebuild b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.1.3.ebuild
index 9b54a7395c71..acf6d1e19593 100644
--- a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.1.3.ebuild
+++ b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.1.3.ebuild
@@ -3,7 +3,7 @@
EAPI=8
-inherit cmake edo flag-o-matic prefix
+inherit cmake edo flag-o-matic toolchain-funcs prefix
DESCRIPTION="Radeon Open Compute OpenCL Compatible Runtime"
HOMEPAGE="https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime"
@@ -59,6 +59,14 @@ src_prepare() {
}
src_configure() {
+ # Fix ld.lld linker error: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
+ # ideally we want !tc-ld-is-bfd for best future-proofing, but it needs
+ # https://github.com/gentoo/gentoo/pull/28355
+ # mold needs this too but right now tc-ld-is-mold is also not available
+ if tc-ld-is-lld; then
+ append-ldflags -Wl,--undefined-version
+ fi
+
# Reported upstream: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/120
append-cflags -fcommon
diff --git a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.3.3-r1.ebuild b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.3.3-r1.ebuild
index 3d3a0eca5d4a..d8fae3a7c08a 100644
--- a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.3.3-r1.ebuild
+++ b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.3.3-r1.ebuild
@@ -3,7 +3,7 @@
EAPI=8
-inherit cmake edo flag-o-matic
+inherit cmake edo flag-o-matic toolchain-funcs
DESCRIPTION="Radeon Open Compute OpenCL Compatible Runtime"
HOMEPAGE="https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime"
@@ -46,6 +46,14 @@ src_prepare() {
}
src_configure() {
+ # Fix ld.lld linker error: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
+ # ideally we want !tc-ld-is-bfd for best future-proofing, but it needs
+ # https://github.com/gentoo/gentoo/pull/28355
+ # mold needs this too but right now tc-ld-is-mold is also not available
+ if tc-ld-is-lld; then
+ append-ldflags -Wl,--undefined-version
+ fi
+
# Reported upstream: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/120
append-cflags -fcommon
diff --git a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.4.3-r1.ebuild b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.4.3-r1.ebuild
index 8dd67252e8b4..a5831a2339c3 100644
--- a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.4.3-r1.ebuild
+++ b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.4.3-r1.ebuild
@@ -3,7 +3,7 @@
EAPI=8
-inherit cmake edo flag-o-matic
+inherit cmake edo flag-o-matic toolchain-funcs
DESCRIPTION="Radeon Open Compute OpenCL Compatible Runtime"
HOMEPAGE="https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime"
@@ -53,6 +53,14 @@ if [[ ${PV} == "9999" ]]; then
fi
}
src_prepare() {
+ # Fix ld.lld linker error: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
+ # ideally we want !tc-ld-is-bfd for best future-proofing, but it needs
+ # https://github.com/gentoo/gentoo/pull/28355
+ # mold needs this too but right now tc-ld-is-mold is also not available
+ if tc-ld-is-lld; then
+ append-ldflags -Wl,--undefined-version
+ fi
+
cmake_src_prepare
pushd ${CLR_S} || die
diff --git a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.5.1.ebuild b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.5.1.ebuild
index 51b2ebd90ad8..eca90b34b094 100644
--- a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.5.1.ebuild
+++ b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.5.1.ebuild
@@ -3,7 +3,7 @@
EAPI=8
-inherit cmake edo flag-o-matic
+inherit cmake edo flag-o-matic toolchain-funcs
DESCRIPTION="Radeon Open Compute OpenCL Compatible Runtime"
HOMEPAGE="https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime"
@@ -61,6 +61,14 @@ src_prepare() {
}
src_configure() {
+ # Fix ld.lld linker error: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
+ # ideally we want !tc-ld-is-bfd for best future-proofing, but it needs
+ # https://github.com/gentoo/gentoo/pull/28355
+ # mold needs this too but right now tc-ld-is-mold is also not available
+ if tc-ld-is-lld; then
+ append-ldflags -Wl,--undefined-version
+ fi
+
# Reported upstream: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/120
append-cflags -fcommon
diff --git a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.7.1-r1.ebuild b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.7.1-r1.ebuild
index 00c9aabadb7c..ae568be79b96 100644
--- a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.7.1-r1.ebuild
+++ b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-5.7.1-r1.ebuild
@@ -4,7 +4,7 @@
EAPI=8
ROCM_SKIP_GLOBALS=1
-inherit cmake edo flag-o-matic rocm
+inherit cmake edo flag-o-matic toolchain-funcs rocm
DESCRIPTION="Radeon Open Compute OpenCL Compatible Runtime"
HOMEPAGE="https://github.com/ROCm-Developer-Tools/clr"
@@ -48,6 +48,14 @@ OB git-r3_checkout
}
src_configure() {
+ # Fix ld.lld linker error: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
+ # ideally we want !tc-ld-is-bfd for best future-proofing, but it needs
+ # https://github.com/gentoo/gentoo/pull/28355
+ # mold needs this too but right now tc-ld-is-mold is also not available
+ if tc-ld-is-lld; then
+ append-ldflags -Wl,--undefined-version
+ fi
+
# Reported upstream: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/120
append-cflags -fcommon
diff --git a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-6.0.0.ebuild b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-6.0.0.ebuild
index 20c734321744..1f792dd4cc24 100644
--- a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-6.0.0.ebuild
+++ b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-6.0.0.ebuild
@@ -4,7 +4,7 @@
EAPI=8
ROCM_SKIP_GLOBALS=1
-inherit cmake edo flag-o-matic rocm
+inherit cmake edo flag-o-matic toolchain-funcs rocm
DESCRIPTION="Radeon Open Compute OpenCL Compatible Runtime"
HOMEPAGE="https://github.com/ROCm-Developer-Tools/clr"
@@ -48,6 +48,14 @@ OB git-r3_checkout
}
src_configure() {
+ # Fix ld.lld linker error: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
+ # ideally we want !tc-ld-is-bfd for best future-proofing, but it needs
+ # https://github.com/gentoo/gentoo/pull/28355
+ # mold needs this too but right now tc-ld-is-mold is also not available
+ if tc-ld-is-lld; then
+ append-ldflags -Wl,--undefined-version
+ fi
+
# Reported upstream: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/120
append-cflags -fcommon
diff --git a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-9999.ebuild b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-9999.ebuild
index 493ab906785e..fab2b10ec262 100644
--- a/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-9999.ebuild
+++ b/dev-libs/rocm-opencl-runtime/rocm-opencl-runtime-9999.ebuild
@@ -3,7 +3,7 @@
EAPI=8
-inherit cmake edo flag-o-matic
+inherit cmake edo flag-o-matic toolchain-funcs
DESCRIPTION="Radeon Open Compute OpenCL Compatible Runtime"
HOMEPAGE="https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime"
@@ -59,6 +59,14 @@ src_prepare() {
}
src_configure() {
+ # Fix ld.lld linker error: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/155
+ # ideally we want !tc-ld-is-bfd for best future-proofing, but it needs
+ # https://github.com/gentoo/gentoo/pull/28355
+ # mold needs this too but right now tc-ld-is-mold is also not available
+ if tc-ld-is-lld; then
+ append-ldflags -Wl,--undefined-version
+ fi
+
# Reported upstream: https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/120
append-cflags -fcommon
next reply other threads:[~2024-01-20 13:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 13:10 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-06-14 22:42 [gentoo-commits] repo/gentoo:master commit in: dev-libs/rocm-opencl-runtime/ Sam James
2024-12-01 7:57 Patrick Lauer
2024-09-19 9:34 Patrick Lauer
2024-07-28 8:00 Patrick Lauer
2024-06-26 9:21 Sam James
2024-03-15 1:23 Sam James
2024-01-20 13:10 Sam James
2023-12-23 10:43 罗百科
2023-12-14 15:02 Benda XU
2023-10-19 10:38 罗百科
2023-10-11 10:41 罗百科
2023-10-09 12:34 罗百科
2023-09-03 6:31 罗百科
2023-07-05 18:22 Craig Andrews
2023-07-05 18:22 Craig Andrews
2023-03-02 16:30 罗百科
2023-02-20 9:36 Sam James
2023-02-20 9:36 Sam James
2023-02-20 9:36 Sam James
2023-02-09 20:21 Sam James
2023-02-08 4:18 Sam James
2022-12-20 9:26 罗百科
2022-03-22 16:26 罗百科
2022-02-11 16:12 Joonas Niilola
2021-12-26 13:44 Benda XU
2021-09-05 14:20 Craig Andrews
2021-07-20 1:07 Craig Andrews
2021-06-28 20:05 Craig Andrews
2021-03-28 21:20 Craig Andrews
2021-01-20 5:36 Benda XU
2020-12-21 12:55 Craig Andrews
2020-10-31 11:11 David Seifert
2020-09-26 15:43 Craig Andrews
2020-09-26 15:43 Craig Andrews
2020-08-25 21:08 Craig Andrews
2020-08-23 14:47 Craig Andrews
2020-08-23 14:47 Craig Andrews
2020-06-09 15:07 Craig Andrews
2020-04-08 21:58 Marek Szuba
2020-04-01 19:33 Craig Andrews
2020-03-02 0:39 Craig Andrews
2020-01-02 12:59 Craig Andrews
2019-12-27 4:54 Craig Andrews
2019-11-24 17:10 Craig Andrews
2019-10-05 14:32 Craig Andrews
2019-08-15 20:19 Craig Andrews
2019-08-15 20:02 Craig Andrews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1705755738.af35827c5fdb9e5ae44b0b16c0ff2acd68f5edab.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox